Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
From:   "NeilBrown" <neilb@suse.de>
To:     "Haowen Bai" <baihaowen@meizu.com>
Cc:     trond.myklebust@hammerspace.com, anna@kernel.org,
        chuck.lever@oracle.com, davem@davemloft.net, kuba@kernel.org,
        pabeni@redhat.com, linux-nfs@vger.kernel.org,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        "Haowen Bai" <baihaowen@meizu.com>
Subject: Re: [PATCH] SUNRPC: Increase size of servername string
In-reply-to: <1648103566-15528-1-git-send-email-baihaowen@meizu.com>
References: <1648103566-15528-1-git-send-email-baihaowen@meizu.com>
Date:   Fri, 25 Mar 2022 13:06:34 +1100
Message-id: <164817399413.6096.7103093569920914714@noble.neil.brown.name>
Precedence: bulk

On Thu, 24 Mar 2022, Haowen Bai wrote:
> This patch will fix the warning from smatch:
>=20
> net/sunrpc/clnt.c:562 rpc_create() error: snprintf() chops off
> the last chars of 'sun->sun_path': 108 vs 48
>=20
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
>  net/sunrpc/clnt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c
> index c83fe61..6e0209e 100644
> --- a/net/sunrpc/clnt.c
> +++ b/net/sunrpc/clnt.c
> @@ -526,7 +526,7 @@ struct rpc_clnt *rpc_create(struct rpc_create_args *arg=
s)
>  		.servername =3D args->servername,
>  		.bc_xprt =3D args->bc_xprt,
>  	};
> -	char servername[48];
> +	char servername[108];

It would be much nicer to use UNIX_PATH_MAX

NeilBrown


>  	struct rpc_clnt *clnt;
>  	int i;
> =20
> --=20
> 2.7.4
>=20
>=20