Received: by 2002:a05:6a10:2726:0:0:0:0 with SMTP id ib38csp1190541pxb; Tue, 29 Mar 2022 20:01:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyPTVtVNfNC4/rQ4VmQPryvPaDVeEuQlAkOK+wqkdOvfznDf4DhgHaqNyPP97sAc5hn655m X-Received: by 2002:a63:f04f:0:b0:382:692a:d4b1 with SMTP id s15-20020a63f04f000000b00382692ad4b1mr4427209pgj.606.1648609291807; Tue, 29 Mar 2022 20:01:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1648609291; cv=none; d=google.com; s=arc-20160816; b=h7Fu2e+0eEP6tVEnGY+k6pDweyG7WZD4a3XN2H9AEwrI/kbX8UVhkxhBokaG51zQex SfKnqqrAp5Jy01k35xYhXS9HnAKHGPXdvNdoAnODIWlEFx77vFah8VG9xsz7Ju/gfpkT 2tRSOGFrZhl57V5qAnKXyw6I8lPVY67gHfZ5a43JooUnTky6WzkmoC1U+uMu8p8AT9l5 U0jPHH2H+acSiNozEI4T3DlWtgALRCQ+4YFBLeG8D4oDOb932w0gCdWYU/Jb41Yjw70n yxij7dY4XpCwq0q85anc4Ovo43c5i5vI98Va32TJ9R5Os7s1woSz1CeUmU7tup+DTByD GfCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:from:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:date :dkim-signature:dkim-filter; bh=o+Rp/6vqThiRAONR1N9RGjikcnzSGysZQHo/LAlC8LA=; b=aNemdxcmk5KqOPxXDYrMJ4NKbpUPKB25Jw7UE8E5MAXgKLCeaVYiUK3Vctt4j2vAHz PgkfXce5ePqrUpUfpw0zIPaB3s1mP5r3oJNHkcQtdoSjASw8aEJ6hY/Ibft9g9Kznp4j w96EmzFjZyrZUCFCu7MVBgkdN7FIybyo7GydjT4CR0casKlfDLX/xC+Mo6DbC0nFN2pG TLuTg/w+9n+QvEX94DJL/khZ0YWWLt9mdMXIyKsRQXgFi/VOa2VGGAZiU36FRLYSDZ5r pljxDc2bSuujTwHQoTfh7AX7j/4OvUUFZp5tUUB5kjYDPjRY5lda8EQNO6jM8E0N6umh lYgg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fieldses.org header.s=default header.b=rKzzS0Yn; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j17-20020a170902759100b00153b2d164fasi11773730pll.258.2022.03.29.20.01.02; Tue, 29 Mar 2022 20:01:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@fieldses.org header.s=default header.b=rKzzS0Yn; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234378AbiC2PN1 (ORCPT + 99 others); Tue, 29 Mar 2022 11:13:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238347AbiC2PNZ (ORCPT ); Tue, 29 Mar 2022 11:13:25 -0400 Received: from fieldses.org (fieldses.org [IPv6:2600:3c00:e000:2f7::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1982E22C8E8 for ; Tue, 29 Mar 2022 08:11:42 -0700 (PDT) Received: by fieldses.org (Postfix, from userid 2815) id BC605BD6; Tue, 29 Mar 2022 11:11:41 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.11.0 fieldses.org BC605BD6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fieldses.org; s=default; t=1648566701; bh=o+Rp/6vqThiRAONR1N9RGjikcnzSGysZQHo/LAlC8LA=; h=Date:To:Cc:Subject:References:In-Reply-To:From:From; b=rKzzS0YnouHtkocFoWWOyWRStXmFY4eWnlnbEkivQbFsiKCMBFmODr3IvuSFB/8Ka l+gzMBNRaJAjUrKLYn2kRdmKIZ8393ybV+VOOQbD8h3DvlcONlW6FdVDLaJAOnOLEm Y1vDeA46b94SRLz9biL7Bz2U2Qft30qAxAkb6654= Date: Tue, 29 Mar 2022 11:11:41 -0400 To: Chuck Lever III Cc: Neil Brown , Benjamin Coddington , Steve Dickson , Trond Myklebust , Linux NFS Mailing List Subject: Re: [PATCH/RFC] NFSv4: ensure different netns do not share cl_owner_id Message-ID: <20220329151141.GA29634@fieldses.org> References: <164816787898.6096.12819715693501838662@noble.neil.brown.name> <164844195133.6096.11388357137493699567@noble.neil.brown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) From: bfields@fieldses.org (J. Bruce Fields) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Mon, Mar 28, 2022 at 02:08:31PM +0000, Chuck Lever III wrote: > Note also that the protocol allows a CLID_INUSE response to return > the IP address of the conflicting client, but NFSD doesn't do that, > I guess as a security measure. The information disclosure sounds mild and not too surprising--mountd already hands out information about v2/v3 clients (used by "showmount"). Chances are we just didn't get around to it. If it'd help debug this kind of problem, I think it'd be worth it. --b.