Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
From:   "NeilBrown" <neilb@suse.de>
To:     "David Disseldorp" <ddiss@suse.de>
Cc:     "Al Viro" <viro@zeniv.linux.org.uk>, linux-nfs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org,
        "LKML" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] VFS: filename_create(): fix incorrect intent.
In-reply-to: <20220331114949.02fae137@suse.de>
References: <164842900895.6096.10753358086437966517@noble.neil.brown.name>,
 <20220330101408.2bbb47ee@suse.de>,
 <164868118815.25542.13263176689793254608@noble.neil.brown.name>,
 <20220331114949.02fae137@suse.de>
Date:   Thu, 31 Mar 2022 21:40:39 +1100
Message-id: <164872323977.25542.8403385264176230518@noble.neil.brown.name>
Precedence: bulk

On Thu, 31 Mar 2022, David Disseldorp wrote:
> On Thu, 31 Mar 2022 09:59:48 +1100, NeilBrown wrote:
>=20
> > On Wed, 30 Mar 2022, David Disseldorp wrote:
> > > Hi Neil,
> > >=20
> > > I gave this a spin and was wondering why xfstests wouldn't start with
> > > this change...
> > >=20
> > > On Mon, 28 Mar 2022 11:56:48 +1100, NeilBrown wrote:
> > > ... =20
> > > >=20
> > > > diff --git a/fs/namei.c b/fs/namei.c
> > > > index 3f1829b3ab5b..3ffb42e56a8e 100644
> > > > --- a/fs/namei.c
> > > > +++ b/fs/namei.c
> > > > @@ -3676,7 +3676,6 @@ static struct dentry *filename_create(int dfd, =
struct filename *name,
> > > >  	int type;
> > > >  	int err2;
> > > >  	int error;
> > > > -	bool is_dir =3D (lookup_flags & LOOKUP_DIRECTORY);
> > > > =20
> > > >  	/*
> > > >  	 * Note that only LOOKUP_REVAL and LOOKUP_DIRECTORY matter here. Any
> > > > @@ -3698,9 +3697,11 @@ static struct dentry *filename_create(int dfd,=
 struct filename *name,
> > > >  	/* don't fail immediately if it's r/o, at least try to report other=
 errors */
> > > >  	err2 =3D mnt_want_write(path->mnt);
> > > >  	/*
> > > > -	 * Do the final lookup.
> > > > +	 * Do the final lookup.  Request 'create' only if there is no trail=
ing
> > > > +	 * '/', or if directory is requested.
> > > >  	 */
> > > > -	lookup_flags |=3D LOOKUP_CREATE | LOOKUP_EXCL;
> > > > +	if (!last.name[last.len] || (lookup_flags & LOOKUP_DIRECTORY))
> > > > +		lookup_flags |=3D LOOKUP_CREATE | LOOKUP_EXCL; =20
> > >=20
> > > This doesn't look right, as any LOOKUP_DIRECTORY flag gets dropped via
> > > the prior "lookup_flags &=3D LOOKUP_REVAL;". =20
> >=20
> > Arg.. thanks for testing - I clearly should have tested more broadly.
> >=20
> > I could leave the "is_dir" variable there I guess.
> > Or maybe the masking statement should be=20
> >     lookup_flags &=3D LOOKUP_REVAL | LOOKUP_DIRECTORY;
> > as that is a better match for the comment.
>=20
> Modifying "lookup_flags" results in changed filename_parentat() and
> __lookup_hash() parameters, which isn't an intended consequence IIUC. I
> think retaining "is_dir" would make sense.

I think retaining is_dir is ugly.
Given that LOOKUP_DIRECTORY is meaningful, why mask it off?

The only flag *ever* passed to filename_parentat() is LOOKUP_REVAL, so
maybe it would make sense to change the parameter to be called "reval"
to make the meaning more obvious.

The only other use of lookup_flags is to pass it to ->lookup().
I guess LOOKUP_DIRECTORY isn't really meaningful there .. though it does
say "this lookup is never for a non-directory"... might that be helpful?

Maybe I'll have another look in the morning.

Thanks,
NeilBrown