Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220228122126.37293-1-songmuchun@bytedance.com>
 <20220228122126.37293-13-songmuchun@bytedance.com> <YkXCWW7ru9Gxyy6G@casper.infradead.org>
In-Reply-To: <YkXCWW7ru9Gxyy6G@casper.infradead.org>
From:   Muchun Song <songmuchun@bytedance.com>
Date:   Fri, 1 Apr 2022 11:23:01 +0800
Message-ID: <CAMZfGtXiVDxO1hqiOChR2a_nwK5kUiWafEXML7=YfuPBy0zH5w@mail.gmail.com>
Subject: Re: [PATCH v6 12/16] mm: list_lru: replace linear array with xarray
To:     Matthew Wilcox <willy@infradead.org>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Michal Hocko <mhocko@kernel.org>,
        Vladimir Davydov <vdavydov.dev@gmail.com>,
        Shakeel Butt <shakeelb@google.com>,
        Roman Gushchin <roman.gushchin@linux.dev>,
        Yang Shi <shy828301@gmail.com>, Alex Shi <alexs@kernel.org>,
        Wei Yang <richard.weiyang@gmail.com>,
        Dave Chinner <david@fromorbit.com>,
        trond.myklebust@hammerspace.com, anna.schumaker@netapp.com,
        jaegeuk@kernel.org, chao@kernel.org,
        Kari Argillander <kari.argillander@gmail.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux Memory Management List <linux-mm@kvack.org>,
        linux-nfs@vger.kernel.org, Qi Zheng <zhengqi.arch@bytedance.com>,
        Xiongchun duan <duanxiongchun@bytedance.com>,
        Fam Zheng <fam.zheng@bytedance.com>,
        Muchun Song <smuchun@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Mar 31, 2022 at 11:01 PM Matthew Wilcox <willy@infradead.org> wrote:
>
> On Mon, Feb 28, 2022 at 08:21:22PM +0800, Muchun Song wrote:
> > @@ -586,27 +508,48 @@ int memcg_list_lru_alloc(struct mem_cgroup *memcg, struct list_lru *lru,
> >               }
> >       }
> >
> > +     xas_lock_irqsave(&xas, flags);
> >       while (i--) {
> > +             int index = READ_ONCE(table[i].memcg->kmemcg_id);
> >               struct list_lru_per_memcg *mlru = table[i].mlru;
> >
> > +             xas_set(&xas, index);
> > +retry:
> > +             if (unlikely(index < 0 || xas_error(&xas) || xas_load(&xas))) {
> >                       kfree(mlru);
> > +             } else {
> > +                     xas_store(&xas, mlru);
> > +                     if (xas_error(&xas) == -ENOMEM) {
> > +                             xas_unlock_irqrestore(&xas, flags);
> > +                             if (xas_nomem(&xas, gfp))
> > +                                     xas_set_err(&xas, 0);
> > +                             xas_lock_irqsave(&xas, flags);
> > +                             /*
> > +                              * The xas lock has been released, this memcg
> > +                              * can be reparented before us. So reload
> > +                              * memcg id. More details see the comments
> > +                              * in memcg_reparent_list_lrus().
> > +                              */
> > +                             index = READ_ONCE(table[i].memcg->kmemcg_id);
> > +                             if (index < 0)
> > +                                     xas_set_err(&xas, 0);
> > +                             else if (!xas_error(&xas) && index != xas.xa_index)
> > +                                     xas_set(&xas, index);
> > +                             goto retry;
> > +                     }
> > +             }
> >       }
> > +     /* xas_nomem() is used to free memory instead of memory allocation. */
> > +     if (xas.xa_alloc)
> > +             xas_nomem(&xas, gfp);
> > +     xas_unlock_irqrestore(&xas, flags);
> >       kfree(table);
> >
> > +     return xas_error(&xas);
> >  }
>
> This is really unidiomatic.  And so much more complicated than it needs
> to be.
>
>         while (i--) {
>                 do {
>                         int index = READ_ONCE(table[i].memcg->kmemcg_id);
>                         struct list_lru_per_memcg *mlru = table[i].mlru;
>
>                         xas_set(&xas, index);
>                         xas_lock_irqsave(&xas, flags);
>                         if (index < 0 || xas_load(&xas))
>                                 xas_set_err(&xas, -EBUSY);
>                         xas_store(&xas, mlru);
>                         if (!xas_error(&xas))
>                                 break;
>                         xas_unlock_irqrestore(&xas, flags);
>                 } while (xas_nomem(&xas, gfp));
>
>                 if (xas_error(&xas))
>                         kfree(mlru);
>         }
>
>         kfree(table);
>         return xas_error(&xas);
>
> (you might want to mask out the EBUSY error here)
>

I'm not familiar with xarray APIs.  I'll dig deeper to see if this code works
properly.  Thanks for your suggestions.