Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 5 Apr 2022 11:00:42 +0200 (CEST)
From:   Geert Uytterhoeven <geert@linux-m68k.org>
To:     trondmy@kernel.org
cc:     linux-nfs@vger.kernel.org
Subject: Re: [PATCH] NFS: Replace readdir's use of xxhash() with hash_64()
In-Reply-To: <20220331033023.718688-1-trondmy@kernel.org>
Message-ID: <alpine.DEB.2.22.394.2204051056580.2010216@ramsan.of.borg>
References: <20220331033023.718688-1-trondmy@kernel.org>
User-Agent: Alpine 2.22 (DEB 394 2020-01-19)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII; format=flowed
Precedence: bulk

 	Hi Trond,

On Wed, 30 Mar 2022, trondmy@kernel.org wrote:
> From: Trond Myklebust <trond.myklebust@hammerspace.com>
>
> Both xxhash() and hash_64() appear to give similarly low collision
> rates with a standard linearly increasing readdir offset. They both give
> similarly higher collision rates when applied to ext4's offsets.
>
> So switch to using the standard hash_64().
>
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>

Thanks for your patch!

> --- a/fs/nfs/Kconfig
> +++ b/fs/nfs/Kconfig
> @@ -4,10 +4,6 @@ config NFS_FS
> 	depends on INET && FILE_LOCKING && MULTIUSER
> 	select LOCKD
> 	select SUNRPC
> -	select CRYPTO

I'm extremely grateful for this part! ;-)

While updating shmobile_defconfig, I was wondering why I was suddenly
asked about all those crypto drivers...

> -	select CRYPTO_HASH
> -	select XXHASH
> -	select CRYPTO_XXHASH
> 	select NFS_ACL_SUPPORT if NFS_V3_ACL
> 	help
> 	  Choose Y here if you want to access files residing on other

Gr{oetje,eeting}s,

 						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
 							    -- Linus Torvalds