Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 7 Apr 2022 12:49:56 -0300
From:   Jason Gunthorpe <jgg@nvidia.com>
To:     Max Gurtovoy <mgurtovoy@nvidia.com>
Cc:     Ariel Elior <aelior@marvell.com>, Anna Schumaker <anna@kernel.org>,
        Jens Axboe <axboe@fb.com>,
        Christian Benvenuti <benve@cisco.com>,
        Potnuri Bharat Teja <bharat@chelsio.com>,
        Bernard Metzler <bmt@zurich.ibm.com>,
        Bart Van Assche <bvanassche@acm.org>,
        Chuck Lever <chuck.lever@oracle.com>,
        "David S. Miller" <davem@davemloft.net>,
        Dennis Dalessandro <dennis.dalessandro@cornelisnetworks.com>,
        Christoph Hellwig <hch@lst.de>,
        Keith Busch <kbusch@kernel.org>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Leon Romanovsky <leon@kernel.org>, linux-cifs@vger.kernel.org,
        linux-nfs@vger.kernel.org, linux-nvme@lists.infradead.org,
        linux-rdma@vger.kernel.org,
        Mike Marciniszyn <mike.marciniszyn@cornelisnetworks.com>,
        Michal Kalderon <mkalderon@marvell.com>,
        Mustafa Ismail <mustafa.ismail@intel.com>,
        Nelson Escobar <neescoba@cisco.com>, netdev@vger.kernel.org,
        Paolo Abeni <pabeni@redhat.com>, rds-devel@oss.oracle.com,
        Sagi Grimberg <sagi@grimberg.me>,
        samba-technical@lists.samba.org,
        Santosh Shilimkar <santosh.shilimkar@oracle.com>,
        Selvin Xavier <selvin.xavier@broadcom.com>,
        Steve French <sfrench@samba.org>,
        Shiraz Saleem <shiraz.saleem@intel.com>,
        target-devel@vger.kernel.org,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Yishai Hadas <yishaih@nvidia.com>,
        Zhu Yanjun <zyjzyj2000@gmail.com>
Subject: Re: [PATCH v2] RDMA: Split kernel-only global device caps from
 uverbs device caps
Message-ID: <20220407154956.GO2120790@nvidia.com>
References: <0-v2-22c19e565eef+139a-kern_caps_jgg@nvidia.com>
 <810e22f7-a48c-dd65-5665-8db757f3ae29@nvidia.com>
 <20220406215431.GK2120790@nvidia.com>
 <6f577f5e-deb8-b961-ef45-1aa31f440578@nvidia.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <6f577f5e-deb8-b961-ef45-1aa31f440578@nvidia.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?CDYiWlfPkj+Fd6VsWscXKRw91wUTA98aeOwPfcSN8BVMEDwu3f1tVcSC0sle?=
 =?us-ascii?Q?yw5RR2+GVpWi/TrfUDPFz06GYp+1iuC81wY1FDb9K9QNKmIK4W8lWpRalY89?=
 =?us-ascii?Q?zeYfhwpLHTPQAqrY5zt8FoBdjYQ40dOidPxFWlZDqTcPY3FbcMn5fuzkbZnT?=
 =?us-ascii?Q?UBgPbKHce+KpILHNsGmk94pdxxW6cazxqqUkOucvA+rJ3V9SBnrXFF7xpBMO?=
 =?us-ascii?Q?oNWCqS9BAmmOYVfBVuWrt2HTA98MrQia5GkxZ2h7hUi+FFHuuPK8ers1n67j?=
 =?us-ascii?Q?a+X1/u97DgCNmIpAuNRZeC8LIzXcEh0IEGlvTGbcOgNg2ZAO3w56NwOT2ga4?=
 =?us-ascii?Q?D54eVO4XI+lU8lyWBASsI/41HuwYFhzvqF5fhTwW8B5h0+Me+KCVh9kvTpwQ?=
 =?us-ascii?Q?KQLGbyLw0fCLOFIl8DpCroi0HkF4IIIFm5l2sOZnbVroY4Hrk3dlSfJxqOb+?=
 =?us-ascii?Q?lxoJvBhNhuGgGvWS+aOhBd/2212UMqTZXSRaTGkX8w6l/RhAxaEtRPFWMlpo?=
 =?us-ascii?Q?AjXNPurybrbLw56TGu7r8SNKEt7dVqIutAk7nmOKdktqqs9V16ZOsirAqSKR?=
 =?us-ascii?Q?QiPl0kWhTHQ57pyA3hyV7Vd2VZSF0rzdxJL+ONdNobdL8lmT1yNB2ykzOUze?=
 =?us-ascii?Q?sIWOj3xMWGNj9elj2HmaKdDel33Lm32x1Jg2voRr12K5v/zDQ9F1b587vMVy?=
 =?us-ascii?Q?p3m03jVWs2eWEJQmlzuq8CX/Owo5fMfXMue51yj5lO/RY/LjTNdukPXMUtCT?=
 =?us-ascii?Q?FC5+2G0hy/N8y3mjhLQyx4bG3hos1H59YBKxehNf3+UrBtNAY7u+PEwoDRix?=
 =?us-ascii?Q?FHYlPWkADOe/hUF2ZGX//6khqyWTXyWGreYLgn9EwqyLDtfIlTPe8wmxx0I9?=
 =?us-ascii?Q?gED47GnL3Z8E/TKL2j/noZ/rkUlszp/sAPeRxVH4qxbkJemI2MJB3ytY7RgG?=
 =?us-ascii?Q?SRWb9/Dgt0Z9ASpJYKr6+L3fcFa/i48o7NMbpx+SM7YG7qqLh0/6A9rl2P4a?=
 =?us-ascii?Q?lUY6xxgDF++pD1/xp8yTz1prSiFFwgGeRU3FfYq7Vz69ktrcXWpJS/fLlIA1?=
 =?us-ascii?Q?1f9JHToHwcbrPoLluqUNCQ4PafDvTTHY4pnwjF467Sh7NyfxptOcgTaSTmlv?=
 =?us-ascii?Q?uM13yHKH44WNfo44BCuyaE6D/Ooz26a7OYMjCGQrahNlFAY4qzWRF/vBfax2?=
 =?us-ascii?Q?a07/9SeT7HrLsNibpLW0vzxIVzHsUTwUKaEBExqNbwHraQ07nwyRt6EOJ513?=
 =?us-ascii?Q?GMg65otqkgBkfGxBe9muabkdiXAspWeK8v2cUUptg99fKcyyzeQ8Qwxmgl9Y?=
 =?us-ascii?Q?E6TX391tlLklOULqORkAXHf7sQDfzSpJtFguDL9zJrdVHHoT74Q9wOZCNVEE?=
 =?us-ascii?Q?wzh0y/0hKHlrHSTeDKDhq/mBR4DBp5FALTfHig9qBBbT4ibFte5jcsw122jt?=
 =?us-ascii?Q?8J1euP99iiguQE959L+v5hUH9M+FEOCdZaPzNwr2kj15MYCN7gyXpu1vx4Bx?=
 =?us-ascii?Q?9RO1u1thEsR7WH30t6Ir8rTX1jOTtPz9SEZy3T0BYDYNzdYaoIin+4FU7HHG?=
 =?us-ascii?Q?45HAhvl9phWgTR5vLCjQRX0aZZT3MIsxl4ylv+xNy9xBX3bNxcWq+TmbSW1l?=
 =?us-ascii?Q?FmR+X3fiup4bmNDhfZ9vd66o2pl0hej/S3ezK87zdPJLUAfEshDoGj4PsW9I?=
 =?us-ascii?Q?CwIbvuLy7vTyok9tgCSwMpA7CMn5C2w14O1swH9rEUKG+WUGCo4R8pkIfNS+?=
 =?us-ascii?Q?KzkxQDwk+w=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: adee98ab-983e-4ef7-52c7-08da18ae4481
X-MS-Exchange-CrossTenant-AuthSource: MN2PR12MB4192.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2022 15:49:58.0454
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: d+IT6Y49z7fOtfHZSJ+YIqU+AsNZMeHd4ZIp9WCCB/9zyVcvpuE61riQCn7raz3u
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB3975
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

On Thu, Apr 07, 2022 at 10:09:04AM +0300, Max Gurtovoy wrote:
> 
> On 4/7/2022 12:54 AM, Jason Gunthorpe wrote:
> > On Thu, Apr 07, 2022 at 12:01:44AM +0300, Max Gurtovoy wrote:
> > 
> > > > @@ -267,59 +258,53 @@ enum ib_device_cap_flags {
> > > >    	 * stag.
> > > >    	 */
> > > >    	IB_DEVICE_MEM_MGT_EXTENSIONS = IB_UVERBS_DEVICE_MEM_MGT_EXTENSIONS,
> > > MEM_MGT_EXTENSIONS is used also in the kernel ULPs (storage)
> > It is not about where it is used, it is about if it is part of the
> > uapi or not. Cleanly separating uapi from not uapi
> 
> from the commit message:
> 
> "
> 
> This cleanly splits out the uverbs flags from the kernel flags to avoid
> confusion in the flags bitmap.
> 
> "
> 
> so it was not clear, at least to me, that some user flags are part of both
> the uapi and the kapi.

I tidied it a bit:

 Split out flags from ib_device::device_cap_flags that are only used
 internally to the kernel into kernel_cap_flags that is not part of the
 uapi. This limits the device_cap_flags to being the same bitmap that will
 be copied to userspace.

Thanks,
Jason