Received: by 2002:a05:6a10:83d0:0:0:0:0 with SMTP id o16csp55694pxh; Thu, 7 Apr 2022 13:49:50 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwi3yTLzQvuP3a+R1VgHARUhRlV5dQS0ioTRiTddqKsjbBEGa3lpAHI7nud/+a7o2Jd43MF X-Received: by 2002:a65:57cc:0:b0:384:3370:e161 with SMTP id q12-20020a6557cc000000b003843370e161mr12652091pgr.364.1649364590168; Thu, 07 Apr 2022 13:49:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1649364590; cv=none; d=google.com; s=arc-20160816; b=I9CfGZYTq8fN0kphLGdzcJVi78DWenpD+q2tKdxFVNZxgdSTA+yii5xdqEslW1PqWx DBRF56ESNXcHi79ewtUglAgdjrw9zV7f2OwSC1Mju+jY2wWYMZ6xlnFaYN3DCoWnAtrb f5fGa78siR2jPgMorsEQ0vwkMQZ9TiXQ07IOhlFbvNuM8mJOOSMawctsD2EZi03uVYMj qSg/HdqXaIlJLAzIdxBZbX/15pHqTxTBG4Qv793EOTYNvnWQW8RLeEupBQ9lTGaIztvJ kaTBDz1QgilwvywfwYv5CRA7f8vMjaYHcksCyQtJtQuKrv5UylqAwXnW2hALTz4tPzV6 Ym7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:message-id:date:cc:to:from:subject; bh=9BZezg/gtKzB9X0TJLJhXmhlDHPBDWH04FAqkR4b07M=; b=Qh2ACltoWnRBpBFXs3dvy3pvpn8ScPF/OJP7URR4r5a/ipil/GoRZ5/CXSSIBN2K3Q m6NCQPBnEMiyo9Rbko02bNZsw8AtJhD6mr/Y+FLQwDlZ4ysnQCJz3anNGT1blRU/9ODm UeQa9K1fLVoRsIS0yv2tdQm5adZBxYu9ZolcZvVfLjkJPz55oCHHc3UPcGDlZrcjA3ir hXpMkHTM2MAPxBtDhJS6NV+LfdY72Trp+Von9RIc483b51XxR4Sg3QStWuWDviceGl9/ nqgwoVvMzKnQsLfuRfEew13SP7qrx4YzM5VV1CHP8y1nxUVOsCNpeklnWDJFReggIgc1 No3w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id t5-20020a654b85000000b003816043ee9dsi15901516pgq.146.2022.04.07.13.49.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Apr 2022 13:49:50 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 330633E7C45; Thu, 7 Apr 2022 12:56:48 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346522AbiDGRpe (ORCPT + 99 others); Thu, 7 Apr 2022 13:45:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44338 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346505AbiDGRpc (ORCPT ); Thu, 7 Apr 2022 13:45:32 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3427322C6F8 for ; Thu, 7 Apr 2022 10:43:31 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D19F9B826B6 for ; Thu, 7 Apr 2022 17:43:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6703FC385A0; Thu, 7 Apr 2022 17:43:17 +0000 (UTC) Subject: [PATCH v3 0/2] Fix request deferral for NFS/RDMA From: Chuck Lever To: linux-nfs@vger.kernel.org Cc: rostedt@goodmis.org Date: Thu, 07 Apr 2022 13:43:16 -0400 Message-ID: <164935330144.76813.17862521591948764594.stgit@klimt.1015granger.net> User-Agent: StGit/1.5.dev1+g8516920 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Last week Trond reported a server crash in svc_rdma_sendto() that seemed related to deferral of a request incoming on an RPC/RDMA transport. A link to that report appears in the first patch below. The first patch in this series addresses the crash, and the second fixes a related observability crash. The other patches from v1 of this series have been postponed to 5.19. Comments, opinions, and Reviewed-by's are appreciated! Since v2: - Fix "has unsafe dereference" warnings in patch 2/2 Since v1: - Series trimmed down to just what will go to 5.18-rc - 2nd patch re-worked so it can be backported to recent stable - Addressed a few checkpatch.pl nits --- Chuck Lever (2): SUNRPC: Fix NFSD's request deferral on RDMA transports SUNRPC: Fix the svc_deferred_event trace class include/linux/sunrpc/svc.h | 1 + include/trace/events/sunrpc.h | 7 ++++--- net/sunrpc/svc_xprt.c | 3 +++ net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 2 +- 4 files changed, 9 insertions(+), 4 deletions(-) -- Chuck Lever