Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Trond Myklebust <trondmy@hammerspace.com>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v2 7/8] SUNRPC: svc_tcp_sendmsg() should handle errors
 from xdr_alloc_bvec()
Thread-Topic: [PATCH v2 7/8] SUNRPC: svc_tcp_sendmsg() should handle errors
 from xdr_alloc_bvec()
Thread-Index: AQHYSrHLX5I/eg2I+UeD2O5FrZV3o6zk1G0AgAACHQA=
Date:   Thu, 7 Apr 2022 19:30:40 +0000
Message-ID: <3E14CFA4-BE55-4736-9C74-FE1A55016B0B@oracle.com>
References: <20220407184601.1064640-1-trondmy@kernel.org>
 <20220407184601.1064640-2-trondmy@kernel.org>
 <20220407184601.1064640-3-trondmy@kernel.org>
 <20220407184601.1064640-4-trondmy@kernel.org>
 <20220407184601.1064640-5-trondmy@kernel.org>
 <20220407184601.1064640-6-trondmy@kernel.org>
 <20220407184601.1064640-7-trondmy@kernel.org>
 <38e0bc33775687622bacf16385efe6267aa98a2b.camel@hammerspace.com>
In-Reply-To: <38e0bc33775687622bacf16385efe6267aa98a2b.camel@hammerspace.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?g947ulMrwXmsFrnkw8Ta/PMWJRcKVT4FNTW0m4+Iq6IXKlCFFTwDydlMaCZ4?=
 =?us-ascii?Q?NwuslqGO85by+Q3fqZwjOVgplYYFhe2jQfUBMa3YqDibhhg7FaJiqQqknlQf?=
 =?us-ascii?Q?tn3Rjr5zS4vUabJsIV+svUOsumZ16d7qrBLIXus/vFOpq5N/FZe0/9x23xqb?=
 =?us-ascii?Q?4n9BnSn7dZ7frR4mWbmzT/80264NIb/+jG/8Mw8tqSZBbstdBqQ3mk00CeCF?=
 =?us-ascii?Q?uX4tDjbY+j6iQjRvU1RRWh+W0aDGzFyVVcORyeIeoLxUjbWIFfqya8tDI8zg?=
 =?us-ascii?Q?pXrKUBea6OEJflfrO00PUF/jNS4kHVn24zZ8huBBfOWieh1M67pjkrQNY/3F?=
 =?us-ascii?Q?dVLM4tFoMrJOXfgfL+brXcTtuVxnPb/Lrgghpd51DUuVwdSKd33i4ycXizoM?=
 =?us-ascii?Q?1VmHXm30QpVGnzob3ZeJKfKRYsjKzkiEo+kMnI9tpIN539pIzI/lmXQhif1U?=
 =?us-ascii?Q?y7mObtfsclYgj6V/kVmNPSnkDPYK0ZFRhmE2irbnaIXTHc0aQN8940wUmU/Z?=
 =?us-ascii?Q?bCtL/BzeVfRo5fpGp1ZGiI4pbR4FlZwZ5atXT2Tk5d2Of3gS4kJ1CSHmOzHS?=
 =?us-ascii?Q?pNQnUogDucDLERiEDTeu2DiUogDkI8U/YIJPP1mk20UjEdCbrryOxf3E19Sf?=
 =?us-ascii?Q?OxgZEm4cWhck5qjnCfCQ7uy6bJ2FuJXwwJWyhBJUFWTbHB3+yfSrNunRRA1G?=
 =?us-ascii?Q?98TIm+V3xoWjT5yG35pH0gc/SlWpA3u57oqZMhNL0J2W0+iOJt4lbjXyJt5W?=
 =?us-ascii?Q?gDIvV/2UVxlmnCdLxbu6IAy3ezZsOMy1XCI0GoCxJOzUbxUtfo81ZEbApNDm?=
 =?us-ascii?Q?Af6gEe8bqQmkFelpDIaTIgKlAsDiY2xGfqxWtfZfJfjoz96alKSY9+lPbF9Y?=
 =?us-ascii?Q?VNHfY0mrN9/bnsb4/08c6aM7WyOi9hsUdrgseGuEDdA1DabBvdhWihtUxIAh?=
 =?us-ascii?Q?MrJo5HlhYFK14imkL79hlV0H4nYHTTfEV6N6EogLMQi6aCaxlqalgvdtELz8?=
 =?us-ascii?Q?btiyg9dhHQM2eIlKccmeXklKX/7VdYNubfGIOsTJqJjiU40G5SqmPMk/cC57?=
 =?us-ascii?Q?BnrI3t7sABb/PlwMu6L+ODJbgaSRb1LHzaknukeYehG3PG+K+UlvgupqhE/d?=
 =?us-ascii?Q?D8MRIwBrYebnY9jJWIdx0h/CWyVLg0k60r5B9dbbYcdQv/ku/oYunMJWuKvq?=
 =?us-ascii?Q?3R0dnKExuscFWhmbYSSAn/p8iXubXWr523OX26hF+DtAxyaZAWn7ShV25eJN?=
 =?us-ascii?Q?VOE8E9A4UnJPW8NdiLdOnON0dTrmeowuNMjd9AJp76IKal5VU2dYZXamp1rO?=
 =?us-ascii?Q?t/N5boCyiide6aDl2nKb6dDVdIcqA1hZqLgiR+w8KEEFnxBNEXbuxPIF/CnG?=
 =?us-ascii?Q?2pQvDEmw1hf37LdhiJQq2OmScr+ZYBvf3KEqmF3lwTuVRX1W3PW2bFSaRHuk?=
 =?us-ascii?Q?FHoR6V75q1EiGwoc+jcz7HhcuP0uNsZOz8sQ0rEYoXWWe+NMiBbAoyQGt/yT?=
 =?us-ascii?Q?hkfTcpd8N8twb6dGKBJ2rsUa+yFsK25H8bmDL8A7f3sYZYNSsFV2Eur+Jlw5?=
 =?us-ascii?Q?B40iRwvSWGdL0ViKRKrzrU6N6bye5Cro3pNcgmdy/7K8SMP0tDcB42gOJ1IM?=
 =?us-ascii?Q?QXXkNNaBDOEeCSde9Up9qTJuPWHlPkULiFSnmqfvvWSPtxlkSBR7kZ15htog?=
 =?us-ascii?Q?W+bgwuTzhOQGJw+EjLSX/wUAdgXIh3vJGPykpV0v3yA3XiOLAj9+O+6CS3ZI?=
 =?us-ascii?Q?WM3sRCL+AzZEUbd+Qpd2MgaDfi5g064=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <CFCC850B94F4A14AB6A92A7EE3B72696@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a24c8614-5e9d-4c2c-c72e-08da18cd19c7
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2022 19:30:40.5294
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: o5rCLGe0+zDJSbAqGtPduSm18/u63i01bLRfNw07rDBevSbMXyZXltIf4GAETKYLypAJ/qoeI27lUCt3diLffA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR10MB2628
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.425,18.0.850
 definitions=2022-04-07_01:2022-04-07,2022-04-07 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 malwarescore=0
 mlxscore=0 suspectscore=0 bulkscore=0 adultscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204070064
X-Proofpoint-ORIG-GUID: EDPDcRQkcPliOWQYFwX8kkvIgH6d9an7
X-Proofpoint-GUID: EDPDcRQkcPliOWQYFwX8kkvIgH6d9an7
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Apr 7, 2022, at 3:23 PM, Trond Myklebust <trondmy@hammerspace.com> wro=
te:
>=20
> On Thu, 2022-04-07 at 14:46 -0400, trondmy@kernel.org wrote:
>> From: Trond Myklebust <trond.myklebust@hammerspace.com>
>>=20
>> The allocation is done with GFP_KERNEL, but it could still fail in a
>> low
>> memory situation.
>>=20
>> Fixes: 4a85a6a3320b ("SUNRPC: Handle TCP socket sends with
>> kernel_sendpage() again")
>> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
>> ---
>>  net/sunrpc/svcsock.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>=20
>> diff --git a/net/sunrpc/svcsock.c b/net/sunrpc/svcsock.c
>> index 478f857cdaed..6ea3d87e1147 100644
>> --- a/net/sunrpc/svcsock.c
>> +++ b/net/sunrpc/svcsock.c
>> @@ -1096,7 +1096,9 @@ static int svc_tcp_sendmsg(struct socket *sock,
>> struct xdr_buf *xdr,
>>         int ret;
>> =20
>>         *sentp =3D 0;
>> -       xdr_alloc_bvec(xdr, GFP_KERNEL);
>> +       ret =3D xdr_alloc_bvec(xdr, GFP_KERNEL);
>> +       if (ret < 0)
>> +               return ret;
>> =20
>>         ret =3D kernel_sendmsg(sock, &msg, &rm, 1, rm.iov_len);
>>         if (ret < 0)
>=20
>=20
> Chuck,
>=20
> Do you mind if I send this and the 8/8 as part of the client pull
> request? I saw this while I was digging through the code and separating
> out the client and server uses of xdr_alloc_bvec().

I browsed through these a few minutes ago. I don't see any technical
issues. But as you're listed as a maintainer of the SUNRPC code, I
didn't think I needed to give explicit permission.


--
Chuck Lever