Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6219ec61-d359-1272-aa8f-26a1f76c45c3@huawei.com>
Date:   Mon, 11 Apr 2022 22:03:21 +0800
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.1
Subject: Re: [PATCH 2/2] NFS: Don't report write errors twice
To:     <trondmy@kernel.org>, <linux-nfs@vger.kernel.org>
CC:     Scott Mayhew <smayhew@redhat.com>,
        "zhangxiaoxu (A)" <zhangxiaoxu5@huawei.com>,
        "zhangyi (F)" <yi.zhang@huawei.com>
References: <20220409200108.94208-1-trondmy@kernel.org>
 <20220409200108.94208-2-trondmy@kernel.org>
From:   "chenxiaosong (A)" <chenxiaosong2@huawei.com>
In-Reply-To: <20220409200108.94208-2-trondmy@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk

在 2022/4/10 4:01, trondmy@kernel.org 写道:
> From: Trond Myklebust <trond.myklebust@hammerspace.com>
> 
> Any errors reported by the write() system call need to be cleared from
> the file descriptor's error tracking. The current call to nfs_wb_all()
> causes the error to be reported, but since it doesn't call
> file_check_and_advance_wb_err(), we can end up reporting the same error
> a second time when the application calls fsync().
> 
> Reported-by: ChenXiaoSong <chenxiaosong2@huawei.com>
> Fixes: ce368536dd61 ("nfs: nfs_file_write() should check for writeback errors")
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
> ---
>   fs/nfs/file.c | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/nfs/file.c b/fs/nfs/file.c
> index 81c80548a5c6..54dc6f176f5c 100644
> --- a/fs/nfs/file.c
> +++ b/fs/nfs/file.c
> @@ -677,9 +677,10 @@ ssize_t nfs_file_write(struct kiocb *iocb, struct iov_iter *from)
>   	/* Return error values */
>   	error = filemap_check_wb_err(file->f_mapping, since);
>   	if (nfs_need_check_write(file, inode, error)) {
> -		int err = nfs_wb_all(inode);
> -		if (err < 0)
> -			result = err;
> +		nfs_wb_all(inode);
> +		error = file_check_and_advance_wb_err(file);
> +		if (error < 0)
> +			result = error;
>   	}
>   	nfs_add_stats(inode, NFSIOS_NORMALWRITTENBYTES, written);
>   out:
> 

After merging this patchset, second `dd` of the following reproducer 
will still report unexpected error: No space left on device.

Reproducer:
         nfs server            |       nfs client
 
-----------------------------|---------------------------------------------
  # No space left on server    |
  fallocate -l 100G /svr/nospc |
                               | mount -t nfs $nfs_server_ip:/ /mnt
                               |
                               | # Expected error: No space left on device
                               | dd if=/dev/zero of=/mnt/file count=1 
ibs=10K
                               |
                               | # Release space on mountpoint
                               | rm /mnt/nospc
                               |
                               | # Unexpected error: No space left on device
                               | dd if=/dev/zero of=/mnt/file count=1 
ibs=10K