Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <ed6893fa-fbb1-36a7-226a-4436edd34644@oracle.com>
Date:   Mon, 25 Apr 2022 11:16:54 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [PATCH RFC v21 0/7] NFSD: Initial implementation of NFSv4
 Courteous Server
Content-Language: en-US
To:     "J. Bruce Fields" <bfields@fieldses.org>
Cc:     chuck.lever@oracle.com, jlayton@redhat.com,
        viro@zeniv.linux.org.uk, linux-nfs@vger.kernel.org,
        linux-fsdevel@vger.kernel.org
References: <1650739455-26096-1-git-send-email-dai.ngo@oracle.com>
 <20220425161722.GC24825@fieldses.org> <20220425175327.GD24825@fieldses.org>
From:   dai.ngo@oracle.com
In-Reply-To: <20220425175327.GD24825@fieldses.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?NWc3eUtDNUJYeHluY0RoY3kvNS83NURRVEdOZ1IvNXFCWEJ6TkNQWmVXbWVF?=
 =?utf-8?B?anBuUGM3b1I0VENoczJZazdUVVVqZ3VtdkZhaTl1WXFxU01Qc1dxb0FKUC91?=
 =?utf-8?B?aWRJYStmaHFxc3NuK3pnT003NkxuRzRhWXk0cnRzbjZHMndQOWpUSm9HRSty?=
 =?utf-8?B?YTlSWXM4ZC9aMVorbXB4c0ZqNXNUNlp5bDJJemR5ZkxyUHZHem5RcEEvejZp?=
 =?utf-8?B?anNFaFdGbVY3OXJYS1p4MXZVWGZ4L0JQblVsZkZIUGJRZ0psSG5tYjhjMU5Y?=
 =?utf-8?B?Y2RWQktQN2kvejJzbHFNQ2dvdWcyOXNXSUo4SkV5WmdEUExyd3BNMTgzVzVH?=
 =?utf-8?B?VlJvRjlPYjJUWkxybXl3RE80WVhLK1Vmdmk4U3MvazlVL3lhWmp0QnI0ajdT?=
 =?utf-8?B?MnFvaVZSYWpQYjlzcm5DUDNlc0ZiM1hBbEEwWHlTRmxpV2dCNXdWZHZpaFNq?=
 =?utf-8?B?VTNpSG5zVk9scXdnUm9HYUNSMlJLcVZVS2NDNzROZFdZak5LYXpidnBBNlNU?=
 =?utf-8?B?TjdteklqNU5ieGE1NWYydENSZGd2QmdHVjQzMGdBc1RBTmlTZGo5Zk53Tm9V?=
 =?utf-8?B?cC9BamJPTHFMeGJKSlF1Wld1RmxRT250cFVzR0trcnRnV0dmbCtZUmxYZnJO?=
 =?utf-8?B?Q25aQXNrNmpkUzdzeUxuTFRGQkx6ZVd2Mi9jdUpTR2tTNm5IejhZSEl4ZWhs?=
 =?utf-8?B?VTFBSXQrc3BwWnZmTXI3dWhHdy9UZE0vSmM5ZU00b1d5T1NoMkhBT2FEWElJ?=
 =?utf-8?B?azdIdTcxczl2ZlFiZElhb1VITkl2MjBoeXphMTRtVFA4elhWWWxsQS9lTG5q?=
 =?utf-8?B?TFIxT0VMaGtGajlXb05hQmVRZmE0V0EydVJIazNZODVBeTgzM1BZT0xLT25t?=
 =?utf-8?B?ME45TmM1eDlhT09lOFhLYUNCaWdIV0hwaG0xVW1obmkwZWFIWHltVUk0YTlV?=
 =?utf-8?B?MXZFRjIvelhUcWRYMW41ZTNVYWRoSXkxSjNoU0tjSi8wbFM1VVkwaVBUY0wy?=
 =?utf-8?B?K08rb2xSL01laXpWV2lFSnpLWHNFb2JramZ3aDFCaUY4NGIyVXFtZkZhTW1n?=
 =?utf-8?B?VVdEdzk3TlRzNnpkVEpaQ3BVVzdZdDA4Q3hLaEZGQlpaV1kreEJoRUYrWUZk?=
 =?utf-8?B?OEdETE5ia1VzMitmZGw3UGx4b1BjNDN6UTRSUms3OTIrM3hibzVtN2Z3K2pZ?=
 =?utf-8?B?SlBtRkRQRkpha0k0S3VNNkM0MEphdU9TalV3ODBqN1NUVXFOTU1JdU8vb3VE?=
 =?utf-8?B?UEY3M0JVaFcybDBnbUh0NFBTM0l4eWdrdGFDT3BVWTZ2Tm5oRFZmSnhKZWFp?=
 =?utf-8?B?dUwyNXBKVkErRE9neS9kQzAyL3BFRjcwT2VIMkFiMTBobE9rWXc2UzhBZ290?=
 =?utf-8?B?cnV6QlczMEhtYnh1ZytaL2plUG0rWlY1dlV5UmFyQ21HTHFuVlZhdHBqUlFZ?=
 =?utf-8?B?MnF1TTlNK3ZCK0J6STY3QmZGb0UxUElnaWhqa2UzSXIvZnJCWWFQa3M2NDRI?=
 =?utf-8?B?ejV3OUtHNUxEUUorWjBNbncrS3NndndJc01VQ2J5bWFQQ2ZkeEJ5QXlOU0U5?=
 =?utf-8?B?RUczNWxKWGlaTDNIUGZMMjEzTUNiNndTd2Q0SzFNQ1YzRElVaVV5UWlBbHFW?=
 =?utf-8?B?UVR2NVhqN0FCMTVNcHhSWjNyZ09Bb3FWeUNZYlc4Zmk0UThmZ2xNblZJQ2lV?=
 =?utf-8?B?a1NrNGo4MmhSZUt3WjdMb0FlMjFuVnZXdGdESytJczRsdysrZTRML2hJVGZh?=
 =?utf-8?B?a2NwM096T2RmVVg0WCt5eFpSSXkxRW94Qml2RmRZaVJrNVJlS0JpM25KR01k?=
 =?utf-8?B?YzU4SGF4bkRmRnpXZG1IVXcrblJ0UkJMbGJkTHhuZE42clFNN0ZxME9SQlpW?=
 =?utf-8?B?bC9oc1ZpWEZYb0ZkRE1HTUw4YzJLcVFLUlRHVzZ4N3ZEakJ6dXpkU3hZQ2hH?=
 =?utf-8?B?eml3ZktZWHZUeE42WDE3dlBuRDd2Qy93bG9mZ2U5VndsaFlRVVl6bitoSDl4?=
 =?utf-8?B?L0wzVkVoZHNyQllURS9iNUIyRWd4TFE4TWtMMW11Rk54UktDbTRYM3cwZWw2?=
 =?utf-8?B?VHY5ZWxZY1BPSmtnenkycGxvdG0zR0UwWmYrNmg2azE5LzBTQXpsTlY5cDVn?=
 =?utf-8?B?dm5pWFJ2aWphYkJHTzNZSkZCdHNmK1I4cEdZMVZJZGNKa2tZRHFodVBzUkI4?=
 =?utf-8?B?ZGJuUXM2ei9HSklQb3htWHVDc2hHN3RZZmR2S2luVDBNMmFvZ2x3UXdxeG0x?=
 =?utf-8?B?ZVVCSXZjQzR2S1lwMTBMVjZTbmo2cml5bXUwV0J1Y1ZWVGJ3L1NqTXF2ZzB2?=
 =?utf-8?B?bnpnWEdCL0haazh3Z3pZYlVkVk1qL0grNHFCUnBlalhXMTZ0b0hQUT09?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3cb313a4-3867-4a4b-bef5-08da26e7c81c
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4257.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Apr 2022 18:16:56.4537
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3FwPY2w1EsBI15hHmYbvRRCdcD/G7jObHCbxvCvdcN81jXQvqrrJBhGph3Lz9abC9Ef+AsiGZWPzDbpcUmg7iA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR10MB3570
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-25_08:2022-04-25,2022-04-25 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 suspectscore=0
 malwarescore=0 spamscore=0 phishscore=0 bulkscore=0 mlxlogscore=999
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204250082
X-Proofpoint-GUID: OnORi3KsRGdgt1trfeiWOy-OSfJmxY8K
X-Proofpoint-ORIG-GUID: OnORi3KsRGdgt1trfeiWOy-OSfJmxY8K
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


On 4/25/22 10:53 AM, J. Bruce Fields wrote:
> I'm getting a few new pynfs failures after applying these.  I haven't
> tried to investigage what's happening.
>
> --b.
>
> **************************************************
> RENEW3   st_renew.testExpired                                     : FAILURE
>             nfs4lib.BadCompoundRes: Opening file b'RENEW3-1':
>             operation OP_OPEN should return NFS4_OK, instead got
>             NFS4ERR_DELAY
> LKU10    st_locku.testTimedoutUnlock                              : FAILURE
>             nfs4lib.BadCompoundRes: Opening file b'LKU10-1':
>             operation OP_OPEN should return NFS4_OK, instead got
>             NFS4ERR_DELAY
> CLOSE9   st_close.testTimedoutClose2                              : FAILURE
>             nfs4lib.BadCompoundRes: Opening file b'CLOSE9-1':
>             operation OP_OPEN should return NFS4_OK, instead got
>             NFS4ERR_DELAY
> CLOSE8   st_close.testTimedoutClose1                              : FAILURE
>             nfs4lib.BadCompoundRes: Opening file b'CLOSE8-1':
>             operation OP_OPEN should return NFS4_OK, instead got
>             NFS4ERR_DELAY

with this patches, OPEN (v4.0 and v4.1) might have to handle NFS4ERR_DELAY
if there is a reservation conflict. I had to modify open_confirm (v4.0) and
open_create_file (v4.1) to handle the NFS4ERR_DELAY error.

-Dai