Received-SPF: softfail (google.com: domain of transitioning linux-nfs-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Jakub Kicinski <kuba@kernel.org>
CC:     netdev <netdev@vger.kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        "linux-cifs@vger.kernel.org" <linux-cifs@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "ak@tempesta-tech.com" <ak@tempesta-tech.com>,
        "borisp@nvidia.com" <borisp@nvidia.com>,
        "simo@redhat.com" <simo@redhat.com>
Subject: Re: [PATCH RFC 4/5] net/tls: Add support for PF_TLSH (a TLS handshake
 listener)
Thread-Topic: [PATCH RFC 4/5] net/tls: Add support for PF_TLSH (a TLS
 handshake listener)
Thread-Index: AQHYU0RqwCfhD8h+BkiXOp6ayeNVBq0A6XOAgAFYlQA=
Date:   Tue, 26 Apr 2022 13:48:20 +0000
Message-ID: <E8809EC2-D49A-4171-8C88-D5E24FFA4079@oracle.com>
References: <165030051838.5073.8699008789153780301.stgit@oracle-102.nfsv4.dev>
 <165030059051.5073.16723746870370826608.stgit@oracle-102.nfsv4.dev>
 <20220425101459.15484d17@kernel.org>
In-Reply-To: <20220425101459.15484d17@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?bzZG9Q2j3C2k7fjjuinlDQ3v+wiaHgGmygMIjX+Ou3oim+Srw2iHOyotAbOu?=
 =?us-ascii?Q?Vk+1UxvH2T/8u2n73SZxubK5F3ND8MOdPJcAVTduaBU0YPFB1dup/8SxvgTg?=
 =?us-ascii?Q?C/lcg2TCbR2RtWBaClkL76xyQPb0RqqyB8qD8x3xL10+gcb6veBWA4LV2Kb7?=
 =?us-ascii?Q?+Y+m293l4OgvDZNzIEsIDcYMCCv3Qfxo5JzIC80e6ZlkSdaueXekR9ClcD2T?=
 =?us-ascii?Q?nqdhgME5UhO3ksorSgfYmgz/QqshtPxlKAKdKE1C/gWtyIvO2ertVISjpkDG?=
 =?us-ascii?Q?yurNbeINbMZhreCZLICT8vQ/UHFFVmYPEaIH8W67cxfspRwPxEe/0y1+nE9i?=
 =?us-ascii?Q?3mS0EziIJPzA3TYc3/DFvm8uCFSppXn3/61asdDeT7JWQvXGhtG1xyA6rwuN?=
 =?us-ascii?Q?WyKX/WZLIS8JPDL5GEqzotbLDdDUZe5mdpGYHGu4dJzPvzpssZM6oY0R380p?=
 =?us-ascii?Q?SpA5TMAWVIVYsihF7GWb9YADteNdaXABKNaLXnoyJ+3S8Q/C0tSyzHZNtC0V?=
 =?us-ascii?Q?37F2pSP7ex2Aj5uWG9TQFaH0qOjHsG4xwyn9vwCzfNRlsbja6zOWLG7fvwFl?=
 =?us-ascii?Q?PhfcBQ7NHhiZlk70ITkjqLlI0fSagAvh/EPYP137BC+g8ANtAIAWNDE1wYEf?=
 =?us-ascii?Q?ta1FoXJ/oFI1o5hKzUdHJCv5YlwsbvnUMbpGhbAQL026VV84JFpPS9dB2bxM?=
 =?us-ascii?Q?1NCx8o3dyRPN93hP9cDhwvXH/l59Wuir7aRVU/EHiJlU+Yae9SDAMQYhbCUy?=
 =?us-ascii?Q?13JlxLZ8PYEkWD01o73L9tIUGbg03UmlZdglECYjsKtpqRcZuqupN8tqXSei?=
 =?us-ascii?Q?yxpCUW2wVn/OenM6/bfbQzZ9yDeJ59xFSvObu/d4599z4MkCDhb3lSAs7oNS?=
 =?us-ascii?Q?JeHJO4nlUD5yZqBTJBjJT1zIPidA1WY+aK/weltuagyOBWZex0oWw8CVD+kT?=
 =?us-ascii?Q?wcgkw3OVV5k/QqiqKi68tJ+cCwITc58ZofZ9GplL923Vl/mw0Hc1v01n//Wr?=
 =?us-ascii?Q?8z8UXbpYfu1xxhl0CFrzrTUR7R4kRWS0mNC9FrgG7ewKy1hAQvBrd2PVGZN9?=
 =?us-ascii?Q?gkjAfOrDlHaOILhRWJj7OIvKHUYDZYZu+rm4A/RxoatkKEn64PVO6rqEX2rM?=
 =?us-ascii?Q?qAx8EUYf7FmhPEigoopNdI8b5JHDAq7sSbvLA6lYPJ4/tATq0Z7pm/e77rsA?=
 =?us-ascii?Q?Q1yq5PtcX1rElYC457YchXieoOi7zEdcekDgq/0LudgqoEFr6FDa2k8/8Qyu?=
 =?us-ascii?Q?DQ/E+PvAeBLU7t7cDlnHttAPuk9XB0t66hEZCi1g7XTfigtiN6HR1tTCSUXp?=
 =?us-ascii?Q?awQxmbDXnkE4N6/YdioWObicBPbHJuk+71iMa3E+tB1qvSOuEDbeUBi6LVX6?=
 =?us-ascii?Q?1Uju2jRSmNkgkMYf4QpXQExugouMpOo0SLbBJhPiDxHZaFbifO/nMfUJJYkW?=
 =?us-ascii?Q?rmma4oXHuQISRBLnuJg0f/5AFING8w/bkFXSjnRcnnOEh5pEoE7XiC3COd5I?=
 =?us-ascii?Q?IrOx1voiC9mfsAsxjMUdYZBwTetm0AAoeohBwmShMTv/ehVrm7LCjkkEBRd5?=
 =?us-ascii?Q?ib4NG+9bsQBim7ydpGd3JeEPvW6yuN/WTW3G2DZ4xHUIAB4szYH7k3uGsAbA?=
 =?us-ascii?Q?10ystYEjBhrybPNTrIKT9uLONe9BSO5SSnKwitk9phGRCKpMxK2Husq96st5?=
 =?us-ascii?Q?bAHF8HDxqwBTbbwcoSfTu2AJGS8V/UNvnUyhGCSWWrfzVjRID8OpMYa49DHM?=
 =?us-ascii?Q?T+J0tKVYq68lKdjVCvynW5LcKyJmdnE=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <87054F540B3238479BE4D816F52ADBF8@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c6213d43-d5f3-4066-f945-08da278b6ce6
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Apr 2022 13:48:20.6891
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: CPjNJTJNkGbh8GtiUX4XCWZjeyD2yS8voTJ+b0JPuCL82N11S7/9wmpCkG/OZyePqiY6/xQV9sWXU4QAqEcsaw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB4775
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-26_02:2022-04-26,2022-04-26 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=872
 malwarescore=0 mlxscore=0 phishscore=0 bulkscore=0 adultscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2202240000 definitions=main-2204260087
X-Proofpoint-ORIG-GUID: jYGzYmMKi85vQTUXhpgBJ2DomSjPrKYP
X-Proofpoint-GUID: jYGzYmMKi85vQTUXhpgBJ2DomSjPrKYP
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE autolearn=no
	autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

Hi Jakub-

> On Apr 25, 2022, at 1:14 PM, Jakub Kicinski <kuba@kernel.org> wrote:
>=20
> On Mon, 18 Apr 2022 12:49:50 -0400 Chuck Lever wrote:
>> In-kernel TLS consumers need a way to perform a TLS handshake. In
>> the absence of a handshake implementation in the kernel itself, a
>> mechanism to perform the handshake in user space, using an existing
>> TLS handshake library, is necessary.
>>=20
>> I've designed a way to pass a connected kernel socket endpoint to
>> user space using the traditional listen/accept mechanism. accept(2)
>> gives us a well-understood way to materialize a socket endpoint as a
>> normal file descriptor in a specific user space process. Like any
>> open socket descriptor, the accepted FD can then be passed to a
>> library such as openSSL to perform a TLS handshake.
>>=20
>> This prototype currently handles only initiating client-side TLS
>> handshakes. Server-side handshakes and key renegotiation are left
>> to do.
>>=20
>> Security Considerations
>> ~~~~~~~~ ~~~~~~~~~~~~~~
>>=20
>> This prototype is net-namespace aware.
>>=20
>> The kernel has no mechanism to attest that the listening user space
>> agent is trustworthy.
>>=20
>> Currently the prototype does not handle multiple listeners that
>> overlap -- multiple listeners in the same net namespace that have
>> overlapping bind addresses.
>=20
> Create the socket in user space, do all the handshakes you need there
> and then pass it to the kernel.  This is how NBD + TLS works.  Scales
> better and requires much less kernel code.

The RPC-with-TLS standard allows unencrypted RPC traffic on the connection
before sending ClientHello. I think we'd like to stick with creating the
socket in the kernel, for this reason and for the reasons Hannes mentions
in his reply.

--
Chuck Lever