Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4804b08a-52bb-1bb8-02de-8d861c439925@oracle.com>
Date:   Wed, 27 Apr 2022 11:50:11 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.8.1
Subject: Re: [PATCH RFC v22 6/7] NFSD: add support for lock conflict to
 courteous server
Content-Language: en-US
From:   dai.ngo@oracle.com
To:     chuck.lever@oracle.com, bfields@fieldses.org
Cc:     jlayton@redhat.com, viro@zeniv.linux.org.uk,
        linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
References: <1651049573-29552-1-git-send-email-dai.ngo@oracle.com>
 <1651049573-29552-7-git-send-email-dai.ngo@oracle.com>
In-Reply-To: <1651049573-29552-7-git-send-email-dai.ngo@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Y3pJTzVQT20rZXdGOUJ2OHlPTzh1RDBCenl2bDZwZyt0bEY4emhiaGdZeHEz?=
 =?utf-8?B?VGowbjVBa2VqM083dDA4dFI2WUpDd1dtcENjVUdvMXRkWUpxSkJKN0R2ZGtU?=
 =?utf-8?B?SnR0cGxmaXRQTDZwQ09OdHJFbXpOa2ZxZHNNUktrQWNLblVkSzVzQ1pBZ214?=
 =?utf-8?B?NHNyMUd3dGtMNVZFR0pQQ1VRMDNlTm5Tb3N4U3N5RmhKckMzbmNqR3UwT0NZ?=
 =?utf-8?B?ZnEzbzhjTjJScUFtRU14N1JQeHF4dnRtdVBjOEhBTUUyck1reUg5MzNqOWgx?=
 =?utf-8?B?VUFtUUlESjlmUHBCOFFuQnVGQmlxckFjZkVtSmFxVmVTVTFQaHM4bXlFQTFM?=
 =?utf-8?B?Z1hjbm9qYW5WTy9vK1Z4WERCMnJ3ZEVhaFBlNWZvR2FaNmNuZlZIb0hEMWYx?=
 =?utf-8?B?SE5CQXlaTDNUakhnOVdaSThnSmxQS1BPb3JLcCtKa25qUjZ6MkQzcGpWc21M?=
 =?utf-8?B?Q1hxaEVSbTNyM1RZRkFGNzZGVEFqb0FwbkoyeC9MblhnNEpYcndLRUdreHQz?=
 =?utf-8?B?Z01OUzJkZGpRcDFHdGRxb2dZS00rdWlMUWxpNi85emUyK3lYbXluaVRLc0xI?=
 =?utf-8?B?elhKT1dLUk44UVdsYk1GVTBMZG1Hc3FFbmdFUlBpMm1mMHZ4YmxBNGNlSmFm?=
 =?utf-8?B?SVQwQ1lJdC9kUGVkTDE2RjBzYVRMQm9OUk0yblRFbXkrb0I1NFBLa3VoYXEw?=
 =?utf-8?B?SXhPSjdCNFhKQmRIejFmL1J3V285UHNYcFpObEJEdVJRQldEcFFsUGVRZEtY?=
 =?utf-8?B?T2h1VWdjUjRUaHRGU0JMdWFDd2tKRjF5c1NBZW1ZaUpNT0hmWUd5c3FoaitX?=
 =?utf-8?B?TlVzWTNnNG5ic1l5VkI5N3JKTnF3bk9iT29UMUpJWDdFWHpTajdsNHpPcTRt?=
 =?utf-8?B?YWpTYW1DanlmTUNUOENFc2xVWFhiUG13VUh1L20rZlRCZnFMYzJWcGN2aFFD?=
 =?utf-8?B?YjIwcGMrTTNtelhGNUZ3TEp3Z21XRE80T3BXSlJoaklBLzVXTWxpcHZzbU5j?=
 =?utf-8?B?V3NkUzF2TjBjSFhXQ1I2eStTZjhqbXpIemF0VVR0UUNHNWcybFhVMFRTYm9K?=
 =?utf-8?B?WXNMUlZwTW0yenpMNVZja0NibG5xakN2ZWFySUZ3T1pvOXlQL3phUml2R0ps?=
 =?utf-8?B?V3hBV0dUVEl3NGpYRWpsVlN0UDZlaG5rWGhXejNIQ0gwVVdiWnBleHVYbkJR?=
 =?utf-8?B?ZG1oVW5ocytORSs4dE9XK1A5QzA5OVpITmRyNERYN0p2T2I0dWU3dWpzY2hu?=
 =?utf-8?B?K3oySWJwbTg4WGhpNkNWTElvTmpYZ25IY05WZ2I5S1VsS1hmUHZBTVVrTTdX?=
 =?utf-8?B?QWRON3hpMmI5MkNrazNBdjVQN1VkanJHVVVhVWs0MFJlWDNlUWxYUzRIc2Jr?=
 =?utf-8?B?U3k2czZ2NjdpbTB3M0U2K3RXZ2Z2S1Y4eWNrck1ieUM2VkF5U1ZPTGIxcFFE?=
 =?utf-8?B?RTZEUzhPb3JCSTRhZlJ0ZE5MM2R0T1Fja29ISjhNS0ROZEJRTTd4cVVSbU50?=
 =?utf-8?B?YVFlZldsKzZFcUFaTjZ1M3o2dlYvTXpVZlJNOGg5Z2REYi9jRUNJUE5LY1Fh?=
 =?utf-8?B?S3RpQXJ3UWllVEtRZ1pGaTRhK0luaTFaMTdJZERUcVduOTRPYUJCdnFwZXRj?=
 =?utf-8?B?RmZkWit3V0tlSjZJNmNQT1RrakQ4TEVCYmZiV3dmcDJ4QWtaMkJieFVKdGRM?=
 =?utf-8?B?dml5b29rTExFNkh2aFhINUMxVWRtWSt3MjVMZVFIYnk1Q0VaazlCOFR4V2Iy?=
 =?utf-8?B?aXFYNjB1WUptdDVPNTRaOHhuNTAwb3pwd0tjb3BsZTE3ZjJPbm40S0ZHaXNw?=
 =?utf-8?B?bmllMDU5MUlRbGh3NXNnTlk1dFR4ZkZ4SHBjYVhocTRYSjhEUDdSdVNGQkov?=
 =?utf-8?B?dFI3SzR0WDFJZVg1cWltUTZuc2U1RVlZWEs1Zm43UUZQTXBiQW11Uk1SYStp?=
 =?utf-8?B?S2oxTDc5bGU1QkZ0aU00TE1QZk1IQXZaRUEwODByQWVYVnp1NXNYYkV6T3Fl?=
 =?utf-8?B?MFJmQW9HekFDcGx4ZmR0b21yaXRKRGpPWjl0OWlMR0ttZDZQOE5FTFEwOWpw?=
 =?utf-8?B?bXJNTGNtb3oyYUFKNEZmMFpLY0QxL1hMN1JZazZsQ2ZIVEk2b2JuOGpqcVBE?=
 =?utf-8?B?SXZ6azdQc0htSXA3L0xOMW85bk5kazBjNmJnTkFrc0pYM3RTUy9xaVlMdDE1?=
 =?utf-8?B?OGdoWTNXejBtRDBLT2dzcXlhYkxDcjBJZHBQNXdwRGtRRTNZY3dJZzIxOThm?=
 =?utf-8?B?LzVNRkhnOCtOM0hRb0w4UmQ3a1RsbkNmdm5EVXdKdzUxNnhSVzJjZWNJZFA1?=
 =?utf-8?B?aXVqRGtLbUpJclRIMXI2RHZGRFNzT2FpRGJNdExCa25FNm0zRzZxUT09?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bb52edf5-3c21-474b-0b40-08da287ec3ff
X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB4270.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Apr 2022 18:50:14.9201
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 1SaI604iaIPa3VEGDlnkPTK9FK/RoYoS+ucncxKLIS3k+0Mpr5UpphKJpveYpaYlqrPZtjtUlHKfTzO8chaRWA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4303
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-27_04:2022-04-27,2022-04-27 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=995 mlxscore=0
 suspectscore=0 malwarescore=0 spamscore=0 adultscore=0 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204270117
X-Proofpoint-ORIG-GUID: 5FT-m76etqc1YuRBrT_Swe1YvT_Vos05
X-Proofpoint-GUID: 5FT-m76etqc1YuRBrT_Swe1YvT_Vos05
X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> +/* return pointer to struct nfs4_client if client is expirable */
> +static void *
> +nfsd4_lm_lock_expirable(struct file_lock *cfl)
> +{
> +	struct nfs4_lockowner *lo = (struct nfs4_lockowner *)cfl->fl_owner;
> +	struct nfs4_client *clp = lo->lo_owner.so_client;
> +
> +	if (try_to_expire_client(clp))

I dropped the mod_delayed_work here, will add it back.

> +		return clp;
> +	return NULL;
> +}

-Dai