Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp1200386iob; Thu, 28 Apr 2022 23:03:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwfPCQkSwQU4KUfskgsWyoJ6IbBzWr70cxs20546e7eSYmU3CnjZfmp+r3aRxVtSxhxc0sC X-Received: by 2002:a17:90a:e507:b0:1d9:5cdd:b16d with SMTP id t7-20020a17090ae50700b001d95cddb16dmr2157411pjy.105.1651212227920; Thu, 28 Apr 2022 23:03:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1651212227; cv=none; d=google.com; s=arc-20160816; b=UTfr8D2JERyWaFZtCvHXfG5YTUuWNjDXhEw4IeRphdXimcaMyu3LoSlxNNlmw2ERlz 6NKLT6oMlkNwq/dB0OW/VH1eqWnsYlIPvTUev+veYr5I6kcma/vOTUf2U7xjNt1mwtsA BpOmXcUX7oaadE0XnfYTolEHgFXbI+gjt8eUgKqaoDvdWCYSCTNTzJA1bnsk30BZRA5L EuL0dIWr2lgFOhgho6CErgcRixbp/IdbyXyUJaBbjMRxaJ/3qdqwH2q0ZK/2xrM9TTqY Vmj5jOZJIyntmzogPM8xfBUTePfwun4v41uzHHlh57p07aW1PTCk/h3dk3DdND2xvtZS iZdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=hUFZTlBrf5xG/QAXxAFAnqWfNJaBhS2igTHYH2v5Oio=; b=f0vt0O7RA6N97qw7Jfgawr7zS2Gy2mxSfZP2/TlCJuqjQSE1TzfokvxninlteT06Z8 XXvPuOAuSADL8lweh26lsO7QLI+Sg41IK3hGzfelRU6/EkxhzFHHXdJQH2SoPNCzol2I R+IqE7AnLNSXDcWoorYcer1tNTLiUgInieT3IxVdnSNg7TXvGdTh9QRFgJtx64ssfAi0 rs6r586iLe0lNRYKsuI7jrmHNv8PqDeac5bN3QmJlejdK9IGZZu5iMweXjMAu0ybDBDD mwSJnVnog8QeDxxrGqZ/vdP6RW04F2niYz+keiaIrv6kIFW/Ff/IrwhwjUgmEh6IVES7 6nDw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=zBivJB6U; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id 12-20020a17090a08cc00b001cb7d1e6b6csi5615123pjn.129.2022.04.28.23.03.24; Thu, 28 Apr 2022 23:03:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=korg header.b=zBivJB6U; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352786AbiD2B1M (ORCPT + 99 others); Thu, 28 Apr 2022 21:27:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1352507AbiD2B1M (ORCPT ); Thu, 28 Apr 2022 21:27:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 11810BF315; Thu, 28 Apr 2022 18:23:56 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 99CBB621FC; Fri, 29 Apr 2022 01:23:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B552DC385AA; Fri, 29 Apr 2022 01:23:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1651195435; bh=mBusurNeyDtGczzb973dlSBIA8MS4x2y599fFWUGS9I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=zBivJB6U3T/XhOw/3CpVT6LHXe2lAXqyivhFYXBwWM8pHcI7P26b5sMkW1HnCXEJ7 HtehwgofjE0TEdV25EJVK8Ygf1y5P6Bsmujuj9Tnh1umoxQJCqlKj9iZm9Wu4Q5OFe NoaQYf3+Wco1r6FmSuGBPQ67Xor/ni40tLgPI/Jo= Date: Thu, 28 Apr 2022 18:23:53 -0700 From: Andrew Morton To: NeilBrown Cc: Geert Uytterhoeven , Christoph Hellwig , Miaohe Lin , linux-nfs@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] NFS: rename nfs_direct_IO and use as ->swap_rw Message-Id: <20220428182353.d79ae288e1bb0cae5116d989@linux-foundation.org> In-Reply-To: <165119301493.15698.7491285551903597618.stgit@noble.brown> References: <165119280115.15698.2629172320052218921.stgit@noble.brown> <165119301493.15698.7491285551903597618.stgit@noble.brown> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Fri, 29 Apr 2022 10:43:34 +1000 NeilBrown wrote: > The nfs_direct_IO() exists to support SWAP IO, but hasn't worked for a > while. We now need a ->swap_rw function which behaves slightly > differently, returning zero for success rather than a byte count. > > So modify nfs_direct_IO accordingly, rename it, and use it as the > ->swap_rw function. > This one I insertion sorted into the series after mm-introduce-swap_rw-and-use-it-for-reads-from-swp_fs_ops-swap-space.patch. I can later fold this patch into that one of you think that's a better presentation?