Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 0/6] Minor NFSD fixes and clean-ups for 5.19
Thread-Topic: [PATCH 0/6] Minor NFSD fixes and clean-ups for 5.19
Thread-Index: AQHYW9juTZ29QDTEgEe/mhN/xVjtX60G+rAA
Date:   Fri, 29 Apr 2022 14:55:41 +0000
Message-ID: <45545156-4667-422D-84D7-9B9356F557E8@oracle.com>
References: <165124376329.1060.17013198516228928515.stgit@bazille.1015granger.net>
In-Reply-To: <165124376329.1060.17013198516228928515.stgit@bazille.1015granger.net>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tXARZtFik0mI7PLH/Vxg3vzVKZIME9yErDmg9b2uNiwuwUFezrbaaLQ4AA0i?=
 =?us-ascii?Q?lyivfRJktZSPw2b0P3qvFS0xThVNDO+ogyK9jPWGxMq4Pnun6RyWr9LPCTri?=
 =?us-ascii?Q?Mn7OB7ldrn7eQL4szgQSUUhelg6WO/HzXteiRCRoSzU1cgIJW0FoUbMHQIyW?=
 =?us-ascii?Q?luVjmsarBu+CTKGrwb1tAUjoedonWieNBJPnYSFvA3ghSrMLUG4F2/+K/uT9?=
 =?us-ascii?Q?xeM9KIkbuTpiTTRYbMr+N4dkfeE1sTObefecRXSw4LzPjG0n+sCQ0h5iKYk9?=
 =?us-ascii?Q?Ow0aqQSsqBkNJDXuwse6L6zciiobk0GuaTFb4Ui8G5kmR3m1tRMlP1gLIzLI?=
 =?us-ascii?Q?b6bEuCaxaf9OBjxgy6Af/R7b83pW42s+5TxQWnoHtP4pn+Q5fYJore3QBeRt?=
 =?us-ascii?Q?RoAp3x1Gy0hgYWG+rKO2uPK+i4NNQaqJpO4EepgBQtecKcxOWf+IlR+4QAk3?=
 =?us-ascii?Q?Bi/5xuL51HWarHo3IFcmhIfL6XwhCqlfDaV2lBzrk8jcurlJcxVZ6GsRcLJo?=
 =?us-ascii?Q?gchcnX5NXyQhB/8wEyFuNmgXh5eF3CQ/7LRrR/jDV6okI8iUQLPnz4ymWlPF?=
 =?us-ascii?Q?T46QArsMLh7XPj5l1Olhi7jvawsvTcyb0AvOdtE8o0JXXqBDFMhOxW4176aO?=
 =?us-ascii?Q?ZR8GW8yAipkaiPgI/PvRyKND9/ya9pugSnuWwCsB0KnLKaf03zLvVJ3trv8i?=
 =?us-ascii?Q?O81iCch0iQ17DmUubBO3Dc/pEjuFOAtNqMIpEj2k3Xgt1M/lEtuEti3r4NHx?=
 =?us-ascii?Q?O/sNOAyb4hkexzY5O3Sq2knPUZyNyr8/PPToBXyc1g41NYuq/D0yPEgOfvqf?=
 =?us-ascii?Q?jLUC5cioz7eDeMsbFRd9AKbx5HzVciIuIRyTn2yRjWovYsDPsi3eAxcywwM/?=
 =?us-ascii?Q?r9h6KGzTd8t8X0SNqKLjyTnm1hAY5NjcD76AQuK+hf7PykRELJ8j1Efu9/a8?=
 =?us-ascii?Q?anAqrOdgExcExaYATbw/IKHZGNZ15llDzz54fda9nT6CoghII4Z0zpCg4lbI?=
 =?us-ascii?Q?Q+ZJsMjV57k/mNMSN51DkO77imHWomtHFLqsyQJoFXcgrqPZSyahbRDTYIJV?=
 =?us-ascii?Q?o7cHmHrB5Vsr3QAEq8ljKk/2BynQ6egnpMZd+78DKufkuR+mV3FuYd/0+szm?=
 =?us-ascii?Q?YiPYUkWj8kgmX/ZRq7nezI1nJcX/ncRIk7/UPegvnB9A9COy/HmtIIOqOL0T?=
 =?us-ascii?Q?s3y+AYXta/IVPQxRbGQm04OXt0rrr2oPAoSXwLRyYUInJJA7OFYlPzxCjkuO?=
 =?us-ascii?Q?fPHNhGhJvhfByBHNHEDzQ3pLA4/W6dYoTUS7SWJPndWOJknFTZMOpY+ZtR7l?=
 =?us-ascii?Q?6MfPHaoDKQD+t62fWq5ZNCzETASv3V9XLWg+tNbLqNi16ANEg4890C/tvbEJ?=
 =?us-ascii?Q?vIeuaREoQs1g69BFtCU0VvCUo5kElZr3a2QdSIvbe+nh+v3bdwOg7Y6H3SmL?=
 =?us-ascii?Q?T8qxhgQiwGHfC+vp2O7k26rDpzxeIZSSp0hiPufVaEZZ5/HooDvjPeC+SQg4?=
 =?us-ascii?Q?+Ed0SMlFxenOfBhHFtkBcpFVW4qXkGaNz5UxBkPpoKyXEgH3KaY/sJ3iWlds?=
 =?us-ascii?Q?EEtnzUgg999ejydyrVpGGKUzCBXBMhVVepre3vbDb+tI9uf3JRgFm+NWn+Os?=
 =?us-ascii?Q?JkgO61lCbVEUP/09qa6ubKBZHbrwwpBs/nrgDK2nAkZkwBtZYEKI1K4YG8QN?=
 =?us-ascii?Q?m6Q38g/ps1s3jggCNG6ri7dsQ+hkxvwmoUrscw6qkhs0JdaNDV9hwYw0Hmx4?=
 =?us-ascii?Q?u/WpFgZoN9EJdYyJo0sq8KjIhCWJsB4=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <A8E59CD276EE9546BA98AC283FDC5988@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d6d87e5d-89e4-4bd8-e174-08da29f054b6
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2022 14:55:41.6338
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 7P40O9QmTya6lncTCsW+Jn2dsq5+E09upo4l6yOoq1AB/1pW6+oQsfPoC/bzHIQK/EHapST7U2gG8aBbO6/fzg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1832
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.858
 definitions=2022-04-29_05:2022-04-28,2022-04-29 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 spamscore=0 adultscore=0
 mlxscore=0 bulkscore=0 suspectscore=0 malwarescore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2204290082
X-Proofpoint-GUID: _m3bKLiC6m0Yiq_6fuoaUG7aMjRdHNKo
X-Proofpoint-ORIG-GUID: _m3bKLiC6m0Yiq_6fuoaUG7aMjRdHNKo
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Apr 29, 2022, at 10:53 AM, Chuck Lever <chuck.lever@oracle.com> wrote:
>=20
> I've gotten confirmation that the NFSv3 OPEN(CREATE) fixes posted
> previously:

Argh. "NFSv4 OPEN(CREATE)".


> https://lore.kernel.org/linux-nfs/20220420192418.GB27805@fieldses.org/T/#=
t
>=20
> are effective and so far, have not resulted in any regression. I've
> pushed these to my for-next branch.
>=20
> On top of these I have collected a few related clean-ups and fixes
> that were found along the way, posted here for review.
>=20
> ---
>=20
> Chuck Lever (6):
>      NFSD: Remove dprintk call sites from tail of nfsd4_open()
>      NFSD: Fix whitespace
>      NFSD: Move documenting comment for nfsd4_process_open2()
>      NFSD: Trace filecache opens
>      NFSD: Clean up the show_nf_flags() macro
>      SUNRPC: Use RMW bitops in single-threaded hot paths
>=20
>=20
> fs/nfsd/filecache.c                      |  5 +-
> fs/nfsd/nfs4proc.c                       | 67 +++++++++++-------------
> fs/nfsd/nfs4state.c                      | 12 +++++
> fs/nfsd/nfs4xdr.c                        |  2 +-
> fs/nfsd/trace.h                          | 34 +++++++++---
> net/sunrpc/auth_gss/svcauth_gss.c        |  4 +-
> net/sunrpc/svc.c                         |  6 +--
> net/sunrpc/svc_xprt.c                    |  2 +-
> net/sunrpc/svcsock.c                     |  8 +--
> net/sunrpc/xprtrdma/svc_rdma_transport.c |  2 +-
> 10 files changed, 85 insertions(+), 57 deletions(-)
>=20
> --
> Chuck Lever
>=20

--
Chuck Lever