Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp605603iob; Thu, 12 May 2022 00:06:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyvuMITjBKMIScVGc+z2k50Mwk54m1efLTUFX5y7pN3DGULHlNunIY/xCeTc/D0NeErbNrp X-Received: by 2002:a05:6638:1385:b0:32b:bada:53ef with SMTP id w5-20020a056638138500b0032bbada53efmr15041182jad.286.1652339217791; Thu, 12 May 2022 00:06:57 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1652339217; cv=none; d=google.com; s=arc-20160816; b=jJ/A1MwItrc2MylREXxH5Mi3mmlGMGQyqxNq4cSVHI18XMm+M4uAtlFBRaHPo4WK/9 sUCPveJWo1IBH8TTmr3mAUtQpSX661Zgi+NYF5Y/EgytmwB48fRSfEwZ8iUIKxdxCuRy Fn4PlF6q4pVac6bSStfJjFd454FzJCumWcJtxB26Nt7OEr7R58ZhzI73WrtkZKLEGBzz rFoccT7NBZCdbf2j8i979fOeYn+oaPyna965N/tkpgkgJld+8ttBDxsvhCUDMb+NDFjw wS8jcTKVEsiawRl1/5pCg+q1xqNvZPyIqSxR+ZauYdnSqkm7GuIwNO8t0QwBiusN54a8 XlRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:message-id:date:cc:to:from:subject; bh=7Qg7mjLpCt2/ZMBnyjFGOqpaZ2bV9hPZ9ltNCH04RdQ=; b=Auv/b/Z0Nt7M7f37na8Sz6O7i7rCwPb+C9bsugRhCoHgCRSGwCfXk1WXQ+JOFSAQXh PffW6/zXiO5P/cA6wHrkl4ZXm5dHuEjzMRYoVlXb8hlgirb3uy+mi2XVSxBFTeAwjSL+ dHTCZuPJ7KXorsqJKYJZRLubYnSpIfcwMhSontQNDzAYqQ4revU77dFuQ49LG2Q3YLBa I2ZjD8JvJCCHEteUxErjUe0vFowFyEQRsGreKVpZzWvWm7xhZKAsdnqJzfj0AlcZN8GM X+C3RYFP/xdzsFC+UK6ZCg9vrzqEU93+e9mePWnZs96CSn+Qa1QDi1Ye1cHGD6LazyGW hrhw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b22-20020a5d8916000000b0065ac39cea94si4424306ion.47.2022.05.12.00.06.33; Thu, 12 May 2022 00:06:57 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238018AbiEKVww (ORCPT + 99 others); Wed, 11 May 2022 17:52:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230306AbiEKVwu (ORCPT ); Wed, 11 May 2022 17:52:50 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 58D44F68A1 for ; Wed, 11 May 2022 14:52:49 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 11490B82630 for ; Wed, 11 May 2022 21:52:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 63C33C340EE; Wed, 11 May 2022 21:52:46 +0000 (UTC) Subject: [PATCH RFC 0/2] Fix "sleep while locked" in RELEASE_LOCKOWNER From: Chuck Lever To: linux-nfs@vger.kernel.org Cc: trondmy@hammerspace.com, bfields@fieldses.org, jlayton@redhat.com, dai.ngo@oracle.com Date: Wed, 11 May 2022 17:52:44 -0400 Message-ID: <165230584037.5906.5496655737644872339.stgit@klimt.1015granger.net> User-Agent: StGit/1.5.dev1+g8516920 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org This short series passes the usual tests on NFSv4.0. We still do not have a reproducer for the splat, though, so it's not known if the issue has been fully addressed. Because this is a long-standing issue and we do not have a reproducer, I'm inclined to be conservative and push this in v5.19 rather than in v5.18-rc. Thoughts, questions, and virtual rotten fruit welcome. --- Chuck Lever (2): NFSD: nfsd4_release_lockowner() should drop clp->cl_lock sooner NFSD: nfsd_file_put() can sleep fs/nfsd/filecache.c | 2 ++ fs/nfsd/nfs4state.c | 56 ++++++++++++++++++++------------------------- 2 files changed, 27 insertions(+), 31 deletions(-) -- Chuck Lever