Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Thiago Becker <tbecker@redhat.com>
To:     linux-nfs@vger.kernel.org
Cc:     steved@redhat.com, Thiago Becker <tbecker@redhat.com>
Subject: [PATCH] nfsrahead: getopt return type is int
Date:   Fri, 13 May 2022 16:18:08 -0300
Message-Id: <20220513191808.2930668-1-tbecker@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

While compiling for aarch64, the compiler throws the warning below
because char is unsigned for aarch64.

main.c: In function ‘main’:
main.c:145:48: warning: comparison is always true due to limited range of data type [-Wtype-limits]
  145 |         while((opt = getopt(argc, argv, "dF")) != -1) {
      |

This makes nfsrahead to run forever. Fix opt type to the same as getopt
type.

Signed-off-by: Thiago Becker <tbecker@redhat.com>
---
 tools/nfsrahead/main.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/tools/nfsrahead/main.c b/tools/nfsrahead/main.c
index 5fae941c..c83c6f71 100644
--- a/tools/nfsrahead/main.c
+++ b/tools/nfsrahead/main.c
@@ -135,10 +135,9 @@ static int conf_get_readahead(const char *kind) {
 
 int main(int argc, char **argv)
 {
-	int ret = 0, retry;
+	int ret = 0, retry, opt;
 	struct device_info device;
 	unsigned int readahead = 128, log_level, log_stderr = 0;
-	char opt;
 
 
 	log_level = D_ALL & ~D_GENERAL;
-- 
2.35.1