Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Sat, 14 May 2022 21:59:46 -0400
From:   "J.Bruce Fields" <bfields@fieldses.org>
To:     trondmy@kernel.org
Cc:     Steve Dickson <SteveD@redhat.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 0/6] Allow nfs4-acl-tools to access 'dacl' and 'sacl'
Message-ID: <20220515015946.GB30004@fieldses.org>
References: <20220514144436.4298-1-trondmy@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220514144436.4298-1-trondmy@kernel.org>
User-Agent: Mutt/1.5.21 (2010-09-15)
Precedence: bulk

On Sat, May 14, 2022 at 10:44:30AM -0400, trondmy@kernel.org wrote:
> From: Trond Myklebust <trond.myklebust@hammerspace.com>
> 
> The following patch set matches the kernel patches to allow access to
> the NFSv4.1 'dacl' and 'sacl' attributes. The current patches are very
> basic, adding support for encoding/decoding the new attributes only when
> the user specifies the '--dacl' or '--sacl' flags on the command line.

Seems like a reasonable thing to do.

I'd rather not be responsible for nfs4-acl-tools any longer, though.

--b.

> 
> Trond Myklebust (6):
>   libnfs4acl: Add helpers to set the dacl and sacl
>   libnfs4acl: Add support for the NFS4.1 ACE_INHERITED_ACE flag
>   The NFSv41 DACL and SACL prepend an extra field to the acl
>   nfs4_getacl: Add support for the --dacl and --sacl options
>   nfs4_setacl: Add support for the --dacl and --sacl options
>   Edit manpages to document the new --dacl, --sacl and inheritance
>     features
> 
>  include/libacl_nfs4.h             | 18 +++++++
>  include/nfs4.h                    |  6 +++
>  libnfs4acl/Makefile               |  2 +
>  libnfs4acl/acl_nfs4_copy_acl.c    |  2 +
>  libnfs4acl/acl_nfs4_xattr_load.c  | 14 +++++-
>  libnfs4acl/acl_nfs4_xattr_pack.c  | 22 ++++++--
>  libnfs4acl/nfs4_ace_from_string.c |  3 ++
>  libnfs4acl/nfs4_get_ace_flags.c   |  2 +
>  libnfs4acl/nfs4_getacl.c          | 84 +++++++++++++++++++++++++++++++
>  libnfs4acl/nfs4_new_acl.c         |  1 +
>  libnfs4acl/nfs4_setacl.c          | 49 ++++++++++++++++++
>  man/man1/nfs4_getfacl.1           | 14 ++++++
>  man/man1/nfs4_setfacl.1           |  8 +++
>  man/man5/nfs4_acl.5               | 10 ++++
>  nfs4_getfacl/nfs4_getfacl.c       | 73 ++++++++++++++++++++++++---
>  nfs4_setfacl/nfs4_setfacl.c       | 67 ++++++++++++++++++++++--
>  16 files changed, 359 insertions(+), 16 deletions(-)
>  create mode 100644 libnfs4acl/nfs4_getacl.c
>  create mode 100644 libnfs4acl/nfs4_setacl.c
> 
> -- 
> 2.36.1