Received: by 2002:a6b:500f:0:0:0:0:0 with SMTP id e15csp2505115iob; Fri, 20 May 2022 10:46:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyhDAX5GkK8e5rPzsD4EKqPW6DFOWMM17ztw8ZC4cB6JqLV8Cn/FJdfEOG7sGJa7UtAFaGH X-Received: by 2002:a17:903:44f:b0:161:5ef:2ea7 with SMTP id iw15-20020a170903044f00b0016105ef2ea7mr10840390plb.74.1653068808620; Fri, 20 May 2022 10:46:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1653068808; cv=none; d=google.com; s=arc-20160816; b=To2ZeHtiG/l/Jb4LZ2A605qYa44YcoK39SBGU8St/5/f5QbR9iBZstQE1pXI8M4+Q7 bgbZUhByH5yHGgJ1kdpqSZLtKFaYvb2Jy5JPh36JoTp6AaQuJQdARG74SmmUUfo5YKSq JSi5fcCXr5EaHfkXlXW/lp4CTyBGW0vC1LICI8c3M7WktqID2drxQhAThOhwFT4hyxEc F2bppmscjXxd606d8RrGrf72OyY+PgE70c+3ikvN8di1YZq9rYNU8JtoUB07YB5xZfdc GTOBx8sryJgE9nmgLbB+Bt9O4xkMFwJRchjMNaHnnsgMxadY4AYLslnM/IfO25ATkchh mm7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=N22RTNjNiOoeCyukDfey1BC2Fv6UeTKWJCGnb5nPt1Y=; b=Fceq2FMJPiRdrjqkxddEW4NE+EpVt4k9LvaBjBJzZ40QSEFVISbyaOPk/NzScduf4A afJpl7NstRiytV10fS58g2zQ2kRYxq1vh5QlRtITuAqdpiMuSl6R9XA6Jc6a+8zzC379 swChwTpZjFNQ+No28uqZE0DOVDFeFaxCPV5hbCL7KKAwfibpREYnm/nb+9JFn5QmhQDI HCyJeuOdQfAW+BvOTBBhwpthyeQsS56prL+wjE6VdQVyHO3SmsiYnv5RhjT8cwvZIME/ zVXIS2PYXqwknN8zEM9V1C7bEQjmi6qeqk8XB+QxB98K3nQfV8FYUuhIOALYW1WM5vBD kayQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=c0VUf9Y7; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pi13-20020a17090b1e4d00b001da48da4de3si4596606pjb.102.2022.05.20.10.46.24; Fri, 20 May 2022 10:46:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=c0VUf9Y7; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349379AbiETMld (ORCPT + 99 others); Fri, 20 May 2022 08:41:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36632 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1349575AbiETMlb (ORCPT ); Fri, 20 May 2022 08:41:31 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 451DC18B01 for ; Fri, 20 May 2022 05:41:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1653050489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=N22RTNjNiOoeCyukDfey1BC2Fv6UeTKWJCGnb5nPt1Y=; b=c0VUf9Y7n93KeYsd/PieH5Z9JtqFNO5gB9dNnxAkCMF3fFhBhV/mNeQ4dqWpKoOYwOZVNW 6TL8bhEHBN/ok/WGlYeZL3ITm+pislD2pEDw97eeSPwBjlLPncBwRjbayoJWIECVK5hA1H V025N9/M9uHEqkfX0iJohBdCGeLXmYY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-201-KphpiQiNPXSVG0ro4fr9xw-1; Fri, 20 May 2022 08:41:27 -0400 X-MC-Unique: KphpiQiNPXSVG0ro4fr9xw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1DECE3C138BE; Fri, 20 May 2022 12:41:27 +0000 (UTC) Received: from [172.16.176.1] (ovpn-64-66.rdu2.redhat.com [10.10.64.66]) by smtp.corp.redhat.com (Postfix) with ESMTPS id C62AB1121319; Fri, 20 May 2022 12:41:26 +0000 (UTC) From: "Benjamin Coddington" To: "Javier Abrego Lorente" Cc: trond.myklebust@hammerspace.com, anna@kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] nfs: removed goto statement Date: Fri, 20 May 2022 08:41:26 -0400 Message-ID: In-Reply-To: References: <20220520115714.47321-1-javier.abrego.lorente@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On 20 May 2022, at 8:00, Javier Abrego Lorente wrote: > final version, I promise. Javier, please read "7) Centralized exiting of functions" in Documentation/process/coding-style.rst. The maintainers are unlikely to take this patch because it doesn't (my opinion) improve the readability, and removing a goto isn't a valid reason on its own. The use of goto is an acceptable practice in the linux kernel for some patterns. Ben