Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Hannes Reinecke <hare@suse.de>
CC:     Alexander Krizhanovsky <ak@tempesta-tech.com>,
        Boris Pismenny <borisp@nvidia.com>,
        netdev <netdev@vger.kernel.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        CIFS <linux-cifs@vger.kernel.org>,
        "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH RFC 2/5] tls: build proto after context has been
 initialized
Thread-Topic: [PATCH RFC 2/5] tls: build proto after context has been
 initialized
Thread-Index: AQHYU0RpxVnRY+Drn0ePT6rxyiRYi60oKekA
Date:   Fri, 20 May 2022 16:39:50 +0000
Message-ID: <A3B90CCA-6C9F-4459-AE11-02AB93BDF25A@oracle.com>
References: <165030051838.5073.8699008789153780301.stgit@oracle-102.nfsv4.dev>
 <165030057652.5073.10364318727607743572.stgit@oracle-102.nfsv4.dev>
In-Reply-To: <165030057652.5073.10364318727607743572.stgit@oracle-102.nfsv4.dev>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gavfK+pe+qmPRgEK13WIk1Uy3yDeL3tkCqgSlhtnfGtcQdxyrtdACfqHONPE?=
 =?us-ascii?Q?Yoxbgap8dvTefmG65inK+6SrZkmn9PLv1iz9D5CuptuOZSZqfZUoqTXXGmYx?=
 =?us-ascii?Q?6MmNR3f9gPcIBKW8eyWLwvBWFWFmH/88Kndb6ILNCmZL46cQ7vwXBGsrlyBj?=
 =?us-ascii?Q?ofL+x++rigI1hy3dzMaZB6VhY5KDF7rgAPf7a03IkmlobRxT9UV/AjC4BssA?=
 =?us-ascii?Q?XkJIoljLBTBNh11/KhLWaJiROqoiW3vtOzR1KoJo44ICKC8w7YLbT0FeH8R3?=
 =?us-ascii?Q?JXyckdGq8oDj9mgiD45doY0giMo9DS2UKtdVKI9jxt5P4cziVSGEEU+UyMte?=
 =?us-ascii?Q?OP6FaOkAdjLcuUwk18m7OrHKYePY9TqQsF3jGeVCBzVGryaV1kqvnW2oeNLP?=
 =?us-ascii?Q?M5EqGHHUM9xMxJnhypzn5w/eReYesSjt/Oxd+dwx+LnHghwuzZhuRsnE4s/v?=
 =?us-ascii?Q?RF2n5iXpTTCPEuJftSQlz4cTPr9J5DteX2BGThYZ3c0zqZsYzADn71K5UxsD?=
 =?us-ascii?Q?WzPz4bgQW4N9lWiVHsWYuS3oeSMU2P7TltKfmENuAdua2My7UQ/zjhTjFw3N?=
 =?us-ascii?Q?Tb83Lb2nNS0sBnV5XwVuC6FCIz7Y5anoVHlPnNjgmfEUrPUYjXEbaYqBDoO7?=
 =?us-ascii?Q?jkndrS+H6mFkJ/1LYYmpz/tAle8x6Kp7oGIFuOYeySx8aDu94zNqNIaBe0P/?=
 =?us-ascii?Q?gNGWz6hZLASPP0sfaVnuE0W7PtgtpkzNTVzPQFUYdKiyMNZPhDmc0pwLYtHf?=
 =?us-ascii?Q?y6NuDGtxAatwGBxdOnMPkfKOw6H86HD1WrpSDp/fio9VRrr1vniq85R7r0nm?=
 =?us-ascii?Q?o8lgNwh/NuJ0JU2PJmy9LIVEtUpnzIGSlr20uYhzq4LO2KJ8brZA6ANyx1cJ?=
 =?us-ascii?Q?1PQ684GKIAW4o7z5qa//HZMxvL5AmzI5SlbWkxzlL0M67UGtWFkH3F4kBz9S?=
 =?us-ascii?Q?JwDyRHQxCBv8xZL8uTmxtIX1xtJMVoG8H03DB45l+8+2k6S/vs1p1bcXFhay?=
 =?us-ascii?Q?TwxOLSJshtvIxW28uBxOXB1TnJ/+VO+/cIIoz63pNFQQdytkrvfPx2hQGyTZ?=
 =?us-ascii?Q?YZOVY57JGjrn7amaGK8onkpU2SR/nFiQYqromKxrG66hKsJIr6qZBokRkUdN?=
 =?us-ascii?Q?aaomQZNsm7MYd+xCbZFaRHc2jPyvl0EvW/O4ttD8RyaeIEqH11freBK4XIfz?=
 =?us-ascii?Q?HW2zBbIxuH4/PmIUg6LFpYvaLjiiEUROJCWQcwsbUk3VcsZLqoGmI2lTFThi?=
 =?us-ascii?Q?BsrUptCSxuAY6cNCoLVX+rTOjAcSOviDRicSCbCASyJeHZj0YW1NBH3bbE5s?=
 =?us-ascii?Q?PylgS/YoitillsDh2NI9FsLxuAjobucM+/yfa5MUKb0VCtJLAk/P7lHESr86?=
 =?us-ascii?Q?K/0V/Q2MY0NttUnm4bwGFGlklBRZV5EmJ4v5g8tIy50E8egoUZIpbYsAeZGz?=
 =?us-ascii?Q?VVpiKxVsx5PHnSYgB+3DLp/P7giUQon7lGBzP5zw3adANwut4MYmP5Ocegl8?=
 =?us-ascii?Q?iyCsQTuDezHn7ZC92nyMBIKppeNpo/Lgi5h6a+Nwvw+f/GzuK/gN8qV22+zO?=
 =?us-ascii?Q?pmGb+MDwnsdEvPG65O0qCXRy5Xul2rWzWHFYJRLu4sxW1faWz+e8B20i2du4?=
 =?us-ascii?Q?Gjq8REASgSay56OUCpWHw+vObt+G9mVZhSnAgFMtDXoFMg2MPlEVbe0hDmst?=
 =?us-ascii?Q?ZV7nLdRqdIOEoOAJo5WOk4aC9g187pw+47AJjEWnsLMX+5GyypP1vPmbS1d3?=
 =?us-ascii?Q?UJetUoL/7GSW/r+V/CR50w5LM/LFU8g=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <DAFCFE3BFE05AC4CA4302D2BD70DDEDD@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ca1ff08-bdb4-4d29-cfe0-08da3a7f5c4b
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 May 2022 16:39:50.9763
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: DYpE1BjmaL4Ai3piLFzQP68wi5GSC1IoS7AHpYzfngANoxWaMilZ2JPko6wdDiLUk1ccLcMAW89lvwiHt+TEMA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1001MB2187
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.874
 definitions=2022-05-20_04:2022-05-20,2022-05-20 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 mlxscore=0
 phishscore=0 bulkscore=0 mlxlogscore=999 adultscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2205200107
X-Proofpoint-GUID: 9OCgjPpgICkhJtCp_3XBXst532OjXhQY
X-Proofpoint-ORIG-GUID: 9OCgjPpgICkhJtCp_3XBXst532OjXhQY
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Apr 18, 2022, at 12:49 PM, Chuck Lever <chuck.lever@oracle.com> wrote:
>=20
> From: Hannes Reinecke <hare@suse.de>
>=20
> We have to build the proto ops only after the context has been
> initialized, as otherwise we might crash when I/O is ongoing
> during initialisation.
>=20
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> net/tls/tls_main.c |    3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>=20
> diff --git a/net/tls/tls_main.c b/net/tls/tls_main.c
> index 7b2b0e7ffee4..7eca4d9a83c4 100644
> --- a/net/tls/tls_main.c
> +++ b/net/tls/tls_main.c
> @@ -836,8 +836,6 @@ static int tls_init(struct sock *sk)
> 	struct tls_context *ctx;
> 	int rc =3D 0;
>=20
> -	tls_build_proto(sk);
> -
> #ifdef CONFIG_TLS_TOE
> 	if (tls_toe_bypass(sk))
> 		return 0;
> @@ -862,6 +860,7 @@ static int tls_init(struct sock *sk)
>=20
> 	ctx->tx_conf =3D TLS_BASE;
> 	ctx->rx_conf =3D TLS_BASE;
> +	tls_build_proto(sk);
> 	update_sk_prot(sk, ctx);
> out:
> 	write_unlock_bh(&sk->sk_callback_lock);
>=20
>=20

While we're working on a better upcall mechanism, I'm dropping
this one from the series. tls_build_proto() can grab a mutex,
so tls_init() can't call it while holding sk_callback_lock.


--
Chuck Lever