Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Dai Ngo <dai.ngo@oracle.com>
CC:     Bruce Fields <bfields@fieldses.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 1/1] Add pynfs4.0 release lockowner test RLOWN2
Thread-Topic: [PATCH 1/1] Add pynfs4.0 release lockowner test RLOWN2
Thread-Index: AQHYbt1B7qnH8pZxnU6G9O3o9v4isq0s9SCA
Date:   Mon, 23 May 2022 21:09:46 +0000
Message-ID: <26E7B9B8-6401-4053-9865-C1DCF68DD921@oracle.com>
References: <1653334950-8762-1-git-send-email-dai.ngo@oracle.com>
In-Reply-To: <1653334950-8762-1-git-send-email-dai.ngo@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?aokZFRyV0zLtnM687ccZOzyJFJums/q0hSeKFj2kZvbyfzoDAEyBiiw3uomp?=
 =?us-ascii?Q?awDHt3s7Q9jBS3QVVacRir40tHuzUZmUgn2i8Xe/uta+0rdsTqj/MdglLUh2?=
 =?us-ascii?Q?owa65MPsTbmHjxKqq/FTKycMAXlZ3XfzN4Kka0qcSlnB4l36sfKdYCWv/47U?=
 =?us-ascii?Q?/mvI7igHVp2hLR6PYlQMeVlX0PYHzl245zktOTS8MZ4w/OgnpR8Df7aqLHJF?=
 =?us-ascii?Q?DWs4EcU1khfBKbJhT9JP+glUiHbSD2CJCtsF/QLtU/qm0Q4AP+vt8BbNXrs3?=
 =?us-ascii?Q?Slg2L8K4r/ln/tbgvRmh2a/lBVG39iXevQrjgAqNzREhteyxnbCa/TyjZHYB?=
 =?us-ascii?Q?3oJ8FB2ZBHevFPsJGMyKojrwQcBhHgJ3RUbDBCOYCBqaC7n957yr8hpMUHmK?=
 =?us-ascii?Q?FkhXtOhu96DfQn0CtslpSrg/EBazUgWDxebmxzMexXKQNsoETtMlJZrX6LQJ?=
 =?us-ascii?Q?OYCKsx6+fMnQu+flNa858BBdee+uQlm1G43fCR4D5ykl50pSscj20KYXQZrd?=
 =?us-ascii?Q?y009gSR1cj2FZJOb4s+rFAFJnwuFVO3Pneye9/cpiXXfzR9wew8GtqBwaSB+?=
 =?us-ascii?Q?XdAT5qniNKzACw/Wh/XbzT8b1+8oo45a3U9VAI8roHblwpjOnczS+T5tI0fp?=
 =?us-ascii?Q?U7Lwe/RuvyAcSjD1dnt2EsR5pO8BObPZBQURx85Sn1pk1O8Tavw/xUvWXgWk?=
 =?us-ascii?Q?LszbQUe0E+lI0U1BeK5DwLIEEhAXf9rKY2U+8jCLNVZSMmDnppgtMobDEVJe?=
 =?us-ascii?Q?A8fX/DqycRhktGL/mJwfz06JFFnVkzTPF/f7xmetbhW/Ik4pCiI50OoySXA6?=
 =?us-ascii?Q?4jI8ejh0TsPLy/kWTqKbZq0eh5c+k8RUb/QdpDlQJmJZncirXMaGEOrgLX08?=
 =?us-ascii?Q?X9B72Ko6UfVwWS4Mz414e/niKrDdIlr9sS65b0/+LDMcPPfC1ZvDeHCq+OUm?=
 =?us-ascii?Q?xfTmlnmciCLcObu3+YU+U7GfIMx1eEPjfvElVaCHvSiAJ1eBq5CA23EKozDr?=
 =?us-ascii?Q?IRJ5bq7c3Fuvd77of0e7EtW+4HBPECKlknrgvFOEZDiysbuclrQBvbG92Ejv?=
 =?us-ascii?Q?fMvIP++9nrIbdOGFFwL4RgPUVE9Uose2TQ9WdvaoTR+6avfzppDTHS6Cnt4r?=
 =?us-ascii?Q?Jy6JqJaC97KaAGev5Qg+f/xxnjdJynV8ui4qWIctdbadWB9vFymkhSz2g0Qn?=
 =?us-ascii?Q?MhEDArO7j1oj6C019Jp+ZJBKmWmzzy3NSnL8Wn2zsz8BmzKY7UuXIOUsjVuT?=
 =?us-ascii?Q?+RXdmHh07SPUQCxJ26FNChack7yjL4GbHAAJ+UnTDcmxgq2WJ3X+2xI+9fA2?=
 =?us-ascii?Q?4mx+7jHRuannY0XKANlhmAVv9stiFcikas3x3TkBAiNBcrRdoUc/YbVuBE6K?=
 =?us-ascii?Q?KqCBN5+m9r5NNAK8eFS5KZZYfDskteGO3OkmSC2pRggp3NZ8BpPebUVuobpw?=
 =?us-ascii?Q?wEJ7BqRoOSALcmutdaMBYejRMv7yw1eox0ctPEHAp3JZmdtqFTtCsrHarRg5?=
 =?us-ascii?Q?zHHF5wemUaorEnMEzDWaDYjCZQM2oyEfDdxtPf4uMdofNoGYyg/gIUSPugfB?=
 =?us-ascii?Q?q9P+Ht1372HrkyVBgpt8xB2oPE2LyPPlqUbbaD1bpVX1AEAqs0TXendijVNN?=
 =?us-ascii?Q?QbtbcizRs/N/N4RHNljG/Tl6G+Q7N+L3iPH+nhliqmY51mG9bDIVj9xDplyr?=
 =?us-ascii?Q?Kc61mHu6OwieaChld3lsLIpTomuLa2DLkjyv1ibJYS52Gpr1YHtV0Sa3DMli?=
 =?us-ascii?Q?D8QcOkbfU4+swRwwlpUCw9jt+WkuqQA=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <8D546A5F88A7D54BBB9A36F1854398C8@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fb73e762-895b-48a6-2d5a-08da3d0090ac
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 May 2022 21:09:46.2218
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: tshSsVzpGLCpb6xDmzzH3r01XPUj5r7MD8thZseY+aTYMBNx6+flzlERwujiF5SPOtAWfYH3qaYNQlGC8aNlYg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1001MB2362
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.486,18.0.874
 definitions=2022-05-23_09:2022-05-23,2022-05-23 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 spamscore=0 mlxscore=0
 phishscore=0 mlxlogscore=999 adultscore=0 malwarescore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2202240000
 definitions=main-2205230110
X-Proofpoint-GUID: g9uFDX83kIHBp7H7HwGsacm2gLXOC10d
X-Proofpoint-ORIG-GUID: g9uFDX83kIHBp7H7HwGsacm2gLXOC10d
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On May 23, 2022, at 3:42 PM, Dai Ngo <dai.ngo@oracle.com> wrote:
>=20
> From: root <root@nfsvme14.us.oracle.com>
>=20
> Add RLOWN2, similar to RLOWN1 but remove the file before release
> lockowner. This test is to exercise to code path causing problem
> of being blocked in nfsd_file_put while holding the cl_client lock.
>=20
> Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
> ---
> nfs4.0/servertests/st_releaselockowner.py | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>=20
> diff --git a/nfs4.0/servertests/st_releaselockowner.py b/nfs4.0/servertes=
ts/st_releaselockowner.py
> index ccd10ff..50cef88 100644
> --- a/nfs4.0/servertests/st_releaselockowner.py
> +++ b/nfs4.0/servertests/st_releaselockowner.py
> @@ -24,3 +24,28 @@ def testFile(t, env):
>     owner =3D lock_owner4(c.clientid, b"lockowner_RLOWN1")
>     res =3D c.compound([op.release_lockowner(owner)])
>     check(res)
> +
> +def testFile2(t, env):
> +    """RELEASE_LOCKOWNER 2 - same as basic test but remove
> +    file before release lockowner.
> +
> +    FLAGS: releaselockowner all
> +    DEPEND:
> +    CODE: RLOWN2
> +    """
> +    c =3D env.c1
> +    c.init_connection()
> +    fh, stateid =3D c.create_confirm(t.word())
> +    res =3D c.lock_file(t.word(), fh, stateid, lockowner=3Db"lockowner_R=
LOWN1")

Should probably be b"lockowner_RLOWN2"


> +    check(res)
> +    res =3D c.unlock_file(1, fh, res.lockid)
> +    check(res)
> +
> +    ops =3D c.use_obj(c.homedir) + [op.remove(t.word())]
> +    res =3D c.compound(ops)
> +    check(res)
> +
> +    # Release lockowner
> +    owner =3D lock_owner4(c.clientid, b"lockowner_RLOWN1")

Ditto.


> +    res =3D c.compound([op.release_lockowner(owner)])
> +    check(res)
> --=20
> 1.8.3.1
>=20

--
Chuck Lever