Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <4deae036-d3a7-abc5-446c-8f102c7da455@redhat.com>
Date:   Thu, 26 May 2022 13:34:06 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH v2 1/2] rpcctl: Use the correct function for setting xprts
 offline and online
Content-Language: en-US
To:     Anna Schumaker <anna@kernel.org>, linux-nfs@vger.kernel.org
References: <20220519154727.3577715-1-anna@kernel.org>
From:   Steve Dickson <steved@redhat.com>
In-Reply-To: <20220519154727.3577715-1-anna@kernel.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5/19/22 11:47 AM, Anna Schumaker wrote:
> From: Anna Schumaker <Anna.Schumaker@Netapp.com>
> 
> Otherwise the tool will tell us:
>      'Namespace' object has no attribute 'set_state'
> 
> Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Committed... (tag: nfs-utils-2-6-2-rc5)

steved.
> ---
>   tools/rpcctl/rpcctl.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/rpcctl/rpcctl.py b/tools/rpcctl/rpcctl.py
> index b8df556b682c..2a69eacd3103 100755
> --- a/tools/rpcctl/rpcctl.py
> +++ b/tools/rpcctl/rpcctl.py
> @@ -142,7 +142,7 @@ class Xprt:
>                   xprt.set_state("offline")
>                   xprt.set_state("remove")
>               else:
> -                args.set_state(args.property)
> +                xprt.set_state(args.property)
>           print(xprt)
>   
>