Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Dongliang Mu <mudongliangabcd@gmail.com>
CC:     Dongliang Mu <dzm91@hust.edu.cn>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nfsd: make destory function more elegant
Thread-Topic: [PATCH] nfsd: make destory function more elegant
Thread-Index: AQHYdo09Led0teFie0eOL9JGzaRrQ609tLwAgAADVgA=
Date:   Fri, 3 Jun 2022 14:02:41 +0000
Message-ID: <5D082BBB-B440-437C-9C3A-AAC29FFA3910@oracle.com>
References: <20220602055633.849545-1-dzm91@hust.edu.cn>
 <53417E03-4D3C-44DC-AA8A-5F9FE340483A@oracle.com>
 <CAD-N9QUAvTZMFz6A+=NxvyHaO102mrc7+5gL4K9xV5j3AEuvjQ@mail.gmail.com>
In-Reply-To: <CAD-N9QUAvTZMFz6A+=NxvyHaO102mrc7+5gL4K9xV5j3AEuvjQ@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hOM40ysrjbyg4AvQjkxPnD8UGHN2dSC6Af/c3q+T4SVhLvQ0YN/5YmP0nrT1?=
 =?us-ascii?Q?f8klmrroLGWRHuWazyiNmI2Ctu8yfVFuLKuZ8/lPjAxwN073dIO42rA+Wvi3?=
 =?us-ascii?Q?Lt125/qryQRBkBjTIXKbAuG8l4naQw0LG/OT+orktke0NS4YE3E4sGRn9YQP?=
 =?us-ascii?Q?1yLPbzzm3NVj1Ta6a2RlN8IyD5n/9gpyrF0joKeAvvTaHDXJQTr4+LvWKMKE?=
 =?us-ascii?Q?IZ/HDcPHYSKjgirKo+f9I+vuaV7G4zwBF5Nak8yeyXUUHvGhlLHt+40Vtf1M?=
 =?us-ascii?Q?TIuJqCaCRkDxmVUSlhCrq5WPMCtgM5VvDTC6KXUZKbiQg6+aMABpTr3haVPq?=
 =?us-ascii?Q?cPNmPyJwAptmgsxGm0t9gSobVHsCeGXwr1xe01XAu5bc5zBS18mqaPMJMIMb?=
 =?us-ascii?Q?2VwvrIsPY0IXcehhXdm9M/HPghr8vqvteYTr3L1twn3+EUnrZlkGuMMiEqBd?=
 =?us-ascii?Q?ad9aGDOX7tg0J1umfsy4NHVELtWit84EtHA+Ycez2CeoH11+m5lvTl3Foso6?=
 =?us-ascii?Q?vHPWVz+0OXH9Aoqlk7dyniz+KRc3AsSEmXdFgNXz6xgSB/QK79XJ20Avm5+d?=
 =?us-ascii?Q?OV71nXqTOjHdgRa78yrzhEgwlaZsI3JOY30Om78jFkKKvHarqyigjqgAuGGh?=
 =?us-ascii?Q?wuFnxzSxPpennSYBEZguEfAgYGpPA5FinXMLmEbtbej3QmNShjApsCDQhTJ0?=
 =?us-ascii?Q?XjOrhQh4aQiuLQdSv4VkUY8T/a2eeX96jyaSJlrhk6k9bA5sMZiectj6nYVs?=
 =?us-ascii?Q?HYyt795EpM7md9jxlq/ww+Zyj+PslX8xveOD5DmhIJogOXYaAWTyq7AvE1KT?=
 =?us-ascii?Q?1nfOSf8PXmRu3MV5U5II77sXhR/vUt/bAI1Ki30o+6FQesJs9wAEt0bXy1YK?=
 =?us-ascii?Q?fwYhb/9mccT3Mf22OOiOemmIjFEPkGwKG3gUZhN2Jg9reGskfQukwL+SgjZ0?=
 =?us-ascii?Q?jqbRBivXqcLww0+EEar237AEYR3KRKHVWBzyH1AvJnJ/VCJSipTSJq9dI7GD?=
 =?us-ascii?Q?czPkPx8JTYVOi7IUeKwj7O2GDyfqvEHWEKnjzdSCuhwZULMM9Qa87+2rdE/l?=
 =?us-ascii?Q?zVxLKcso59W9wVReACobLacYnleTIvwQi3wquj/giElSi8t8hzGVcwvCGvZH?=
 =?us-ascii?Q?+1Bp+fJYbH50yOWlB/ZXp28CAUr4LHaUvWOGpFAYG0QFaFfWWlS0x5kCIeYB?=
 =?us-ascii?Q?c+yUcsstKIxtqpuEEnHWTjdb5IooZvFeMGmIARrT25kpcZcPtCTLjp3NRX92?=
 =?us-ascii?Q?pIkHseISmx/eK1YjNbFhn/JmydAbWpbkkCgZ8jk/TZA1kcHA4xg8F6hvNSti?=
 =?us-ascii?Q?W3LJiYRYRyIEwTdObONFusqq7qfuPicmHQZvsAFowVuexWOpxHqr5n2cn1ST?=
 =?us-ascii?Q?O9nAHA9forDA87Ucp2XwUR321gAJzbejcgvIwsogTfp/F5JvBEUh6sIUfxGS?=
 =?us-ascii?Q?EG7ZRXMl/wO+po0cFQp3b0mK3Id6NxlqwiDg/hsueGvT0h50uu5WkcDu6BRL?=
 =?us-ascii?Q?SuqIjymcBxtfv4WmpmceKHDeTMyDL4b5tXR1Sp2QqxYfSNhaa+xB0/H3Ya/O?=
 =?us-ascii?Q?1T1QW/SZ1ul9KZjGXn2EQIb3plID/zia9qQiU/cVr+xh4FVGjzPMWHWD9a/G?=
 =?us-ascii?Q?e+M5tzn6D/b3dgEADq6fN/b4GIJCaErL5RMDDzwYHfnwoyJKHup1796KqYRt?=
 =?us-ascii?Q?UN7SgIDV53EDIA6mBQel/q8lGQXB+JXOeYyMnvvCqX/x4QHYZsQ7LLZ67qjE?=
 =?us-ascii?Q?uz+m7tKpp9l4GBWxX3gFxTCkh1Id2/8=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D22FF4515BEB8E4491AD5E58DDA87265@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 24abf912-0f35-4494-2155-08da4569b9b2
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jun 2022 14:02:41.5063
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: NpbUdbgO1bFbza/BNVL7LOExCUOW6lltqoV6JZeVWJMPAPvhq6r80HdFWrCjveY286VbJc1ZEc8Gbivg6h1XPw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN0PR10MB4840
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-03_04:2022-06-02,2022-06-03 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999
 phishscore=0 suspectscore=0 malwarescore=0 mlxscore=0 adultscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206030062
X-Proofpoint-GUID: MJeNy7lGM4KAyM_bEgixm4bJFIcrtHn0
X-Proofpoint-ORIG-GUID: MJeNy7lGM4KAyM_bEgixm4bJFIcrtHn0
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Jun 3, 2022, at 9:50 AM, Dongliang Mu <mudongliangabcd@gmail.com> wrot=
e:
>=20
> On Thu, Jun 2, 2022 at 10:30 PM Chuck Lever III <chuck.lever@oracle.com> =
wrote:
>>=20
>>=20
>>=20
>>> On Jun 2, 2022, at 1:56 AM, Dongliang Mu <dzm91@hust.edu.cn> wrote:
>>>=20
>>> From: Dongliang Mu <mudongliangabcd@gmail.com>
>>>=20
>>> In init_nfsd, the undo operation of create_proc_exports_entry is:
>>>=20
>>>       remove_proc_entry("fs/nfs/exports", NULL);
>>>       remove_proc_entry("fs/nfs", NULL);
>>>=20
>>> This may lead to maintaince issue. Declare the undo function
>>=20
>> "maintenance"
>=20
> Sorry for the typo.
>=20
>>=20
>>=20
>>> destroy_proc_exports_entry based on CONFIG_PROC_FS
>>=20
>> IIUC, the issue is that if CONFIG_PROC_FS is not set,
>> fs/nfsd/nfsctl.c fails to compile?
>=20
> The answer is no. There is no bug in the code.
>=20
> At first, I thought this might cause the miscompilation or bug. But
> actually the code is fine.
>=20
> Because remove_proc_entry is defined as an empty function if
> CONFIG_PROC_FS is not set,

Code inspection does suggest there could be a problem,
but I'm glad there isn't one. I can drop this one.


>>> Signed-off-by: Dongliang Mu <mudongliangabcd@gmail.com>
>>> ---
>>> fs/nfsd/nfsctl.c | 16 ++++++++++++----
>>> 1 file changed, 12 insertions(+), 4 deletions(-)
>>>=20
>>> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
>>> index 0621c2faf242..83b34ccbef5a 100644
>>> --- a/fs/nfsd/nfsctl.c
>>> +++ b/fs/nfsd/nfsctl.c
>>> @@ -1450,11 +1450,21 @@ static int create_proc_exports_entry(void)
>>>      }
>>>      return 0;
>>> }
>>> +
>>> +static void destroy_proc_exports_entry(void)
>>> +{
>>> +     remove_proc_entry("fs/nfs/exports", NULL);
>>> +     remove_proc_entry("fs/nfs", NULL);
>>> +}
>>> #else /* CONFIG_PROC_FS */
>>> static int create_proc_exports_entry(void)
>>> {
>>>      return 0;
>>> }
>>> +
>>> +static void destroy_proc_exports_entry(void)
>>> +{
>>> +}
>>> #endif
>>>=20
>>> unsigned int nfsd_net_id;
>>> @@ -1555,8 +1565,7 @@ static int __init init_nfsd(void)
>>> out_free_subsys:
>>>      unregister_pernet_subsys(&nfsd_net_ops);
>>> out_free_exports:
>>> -     remove_proc_entry("fs/nfs/exports", NULL);
>>> -     remove_proc_entry("fs/nfs", NULL);
>>> +     destroy_proc_exports_entry();
>>> out_free_lockd:
>>>      nfsd_lockd_shutdown();
>>>      nfsd_drc_slab_free();
>>> @@ -1576,8 +1585,7 @@ static void __exit exit_nfsd(void)
>>>      unregister_cld_notifier();
>>>      unregister_pernet_subsys(&nfsd_net_ops);
>>>      nfsd_drc_slab_free();
>>> -     remove_proc_entry("fs/nfs/exports", NULL);
>>> -     remove_proc_entry("fs/nfs", NULL);
>>> +     destroy_proc_exports_entry();
>>>      nfsd_stat_shutdown();
>>>      nfsd_lockd_shutdown();
>>>      nfsd4_free_slabs();
>>> --
>>> 2.25.1
>>>=20
>>=20
>> --
>> Chuck Lever

--
Chuck Lever