Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Wang Yugui <wangyugui@e16-tech.com>
CC:     Frank van der Linden <fllinden@amazon.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Matthew Wilcox <matthew.wilcox@oracle.com>,
        Liam Howlett <liam.howlett@oracle.com>
Subject: Re: filecache LRU performance regression
Thread-Topic: filecache LRU performance regression
Thread-Index: AQHYcfvwqM9TwnG0lkutiJn4EA8Bxq0zLyiAgAAP6gCABnuxAIABBV+AgAAHvgCAAJpHgIAEDbiA
Date:   Sat, 4 Jun 2022 15:44:05 +0000
Message-ID: <1D00FCD4-8EFE-4080-A706-61FD7886CA52@oracle.com>
References: <20220601161003.GA20483@dev-dsk-fllinden-2c-d7720709.us-west-2.amazon.com>
 <4C14DB3A-A5C1-41A9-8293-DF4FC2459600@oracle.com>
 <20220602094956.A396.409509F4@e16-tech.com>
In-Reply-To: <20220602094956.A396.409509F4@e16-tech.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2vgklmQVTxbDDEC0H/oHhz6G4n2Jx30Lsh1zcmNUNIos5Jvwh7KgCJW0iJ4j?=
 =?us-ascii?Q?95UJfPW8l2DZxWz9KVKbqeWSlD1UyK8cRY9NC0T0BcNcBq5+9TrJ1Vvq3y8o?=
 =?us-ascii?Q?g7SYExd9PQL0TB2ydZoM6La7g9ATt9FX+5Wgzk4o6Ez2yI6JANSC1e7Nyc+L?=
 =?us-ascii?Q?ocZfB9a2b8AHYvtgPboAfxUU8RZlr6NZjbKG3NAAiwjR1AoudT6n61WEtgo0?=
 =?us-ascii?Q?qKeFTNr6AjG8BWSSTWRYALn3cQ21W1kwSt19gDXgtHsRL4gqei2g+U88pdiQ?=
 =?us-ascii?Q?s9JH1sNce635R3zNuka5KsVuf06Nd5bqsPjYAXQMS0iXN4HBaXNpkjzWqDB8?=
 =?us-ascii?Q?vsjeEMAR2re6S6AIXjthetZJSdjQSTDNCiUTBo+K718gf7SUORKy7i0/pHLO?=
 =?us-ascii?Q?IL/WYUHWgTzuBO3RWDLf+F8etoGWvZvBu7hXN9EL8CiwSsjZPPUowelShz8M?=
 =?us-ascii?Q?WAq6IPvQGM+5huEP1bbiUAQVN+wN6m8i4MgvGxVN4ggflRNlX3LccHTnYHEA?=
 =?us-ascii?Q?eTBAyJ70zjbbOH6PM8mKkYl5w2G4aWeMCn+rX+rtX5gKK/GydixT9DsMw+wl?=
 =?us-ascii?Q?i+/ue+kzg2Y0LEvkjAjadjSFgh4qR6S3bxEiM0ifbGPNy8WC4rBrZK5LTegi?=
 =?us-ascii?Q?GrObePRkSbmwelpMpNU8l8k+gukzZdGGyrg6T2D2Qcq6ln9b/x+Re+DVgnd6?=
 =?us-ascii?Q?rL6Cm5Lr/NYd4F3cTkhUVeZlAW5KcgtgmHiAXtcYYPse0hq5qUEayzOfoSJk?=
 =?us-ascii?Q?HBXsvOcxiVZcfUrhB6TULvKT2yKY8NFC+qMNFsNMRLaVk+InqHI+2fC6E8O7?=
 =?us-ascii?Q?BJYT4wYiqhclCLO2DuvGDuslFWQJWuM6ThxO/iN+RsUvcHYTKjdij1hR0KVU?=
 =?us-ascii?Q?8hT93CS/qIL5fK66IvVkDBPloEVqfi1YalvD3xjF6n1Gndbh9zlv+3wSrUT1?=
 =?us-ascii?Q?3U9H8dcVKjriEsKLzT5yYloQnxgE0YuzsoP2/C9v0azrt8NPAFxwxu/892Ni?=
 =?us-ascii?Q?PNggupPzuqn1KEevbOsaCkz9MavN2QSUBx0KOSvySv9PnPAFCbDv4fd0sWKB?=
 =?us-ascii?Q?0d1nKkdRyaqDSzL+57JTk++JEKWaZZWUCM/JVKj9OzxAD2aKgAF093vc0u0D?=
 =?us-ascii?Q?FcC9EugraX0qv4o4e6CR+90IGjb4EwFDV+COoSVi82OROKf8+U3xf7vJRIgq?=
 =?us-ascii?Q?8Pn+9RAHgod0iGiWDN6CCYAD2Pw9ORgxvfkx4WhnYtkl7TVPCf/UuFURYbQF?=
 =?us-ascii?Q?GGYgkCFtmO2x57deFI5YhfECAeap78d7Q4KiETsG7kmM7bKw8d4EDwdVADuC?=
 =?us-ascii?Q?6hRp18Ph5yo7Ve6BoE5Yn+EEruZU0zaRdlGzt89ubo0KWu+XZfNxtq+K3BmW?=
 =?us-ascii?Q?CrrPNaf5tNijP89Ec+SKT+8PfDYT+1YV+xG9UOLVdWMvozeM/hkJCTRU2k8X?=
 =?us-ascii?Q?ofnsPhKEbxQD+4YHCuhvuOEdE9QKkOX4OqJ9/3F4meVZD5me8lRyuMgLzdnH?=
 =?us-ascii?Q?vn/EyCbEAcS/ftjuzijeaEz2v62HW53WYjPzGcxDLIqdF40fb40doWEKe5Wn?=
 =?us-ascii?Q?sWFWjdJwzmK6VY8dlHNfaD/ma7EBj9xwOwY1FXHs8LBAZCsKcMgMHGmxDfLu?=
 =?us-ascii?Q?+G7eXjtuuFqm6YInvGZdcXBP5p7FgRprkLYwxXKUWpp6FoXzrSYy1vX8mljj?=
 =?us-ascii?Q?dwSscQF7cZSlD+NI2ECb4pjHa6iwxfzFhfUSEMQqg9DQvj5l7gZeRPSoWnoW?=
 =?us-ascii?Q?Kth1tltRyBSiJ2seZHZNlEOKxyBd4Qs=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <ECF25890A3E83249B1C7386E22C6A449@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 603061ad-d706-49d8-dfc1-08da46410eb4
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jun 2022 15:44:05.9431
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: vtaywnVwsXS4+LjuRMwT6MwZm4ml/733IfYUoZy3FH0dykEHFzQ6AdJpFM+iR9d7Q3wyygj3z86RfnSRlpyxOQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR10MB2692
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-04_04:2022-06-02,2022-06-04 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0
 malwarescore=0 mlxlogscore=915 adultscore=0 mlxscore=0 phishscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206040075
X-Proofpoint-GUID: hBBi9eVk6UnidH-yV2kIE-D8smuN_wvr
X-Proofpoint-ORIG-GUID: hBBi9eVk6UnidH-yV2kIE-D8smuN_wvr
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Jun 1, 2022, at 9:49 PM, Wang Yugui <wangyugui@e16-tech.com> wrote:
>=20
> Hi,
>=20
>> Certainly, though, the filecache plays somewhat different roles
>> for legacy NFS and NFSv4. I've been toying with the idea of
>> maintaining separate filecaches for NFSv3 and NFSv4, since
>> the garbage collection and shrinker rules are fundamentally
>> different for the two, and NFSv4 wants a file closed completely
>> (no lingering open) when it does a CLOSE or DELEGRETURN.
>=20
> if NFSv4 closed a file completely (no lingering open) when it does a
> CLOSE or DELEGRETURN,
> then the flowing problem seems to be fixed too.
> https://lore.kernel.org/linux-nfs/20211002111419.2C83.409509F4@e16-tech.c=
om/

I agree, that's probably related.

But let's document this issue as a separate bug, in case it
isn't actually as related as it looks like at first. Can you
open a bug report on bugzilla.linux-nfs.org? kernel/server

--
Chuck Lever