Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
From:   "NeilBrown" <neilb@suse.de>
To:     "Chuck Lever" <chuck.lever@oracle.com>
Cc:     linux-nfs@vger.kernel.org
Subject: Re: [PATCH v1 5/5] SUNRPC: Remove pointer type casts from
 xdr_get_next_encode_buffer()
In-reply-to: <165445913079.1664.5467024491080755855.stgit@bazille.1015granger.net>
References: <165445865736.1664.4497130284832282034.stgit@bazille.1015granger.net>,
 <165445913079.1664.5467024491080755855.stgit@bazille.1015granger.net>
Date:   Tue, 07 Jun 2022 11:08:39 +1000
Message-id: <165456411905.22243.16914535455796677784@noble.neil.brown.name>
Precedence: bulk

On Mon, 06 Jun 2022, Chuck Lever wrote:
> To make the code easier to read, remove visual clutter by changing
> the declared type of @p.

Oh yes - that's much nicer!

Reviewed-by: NeilBrown <neilb@suse.de>

Thanks,
NeilBrown

>=20
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
>  net/sunrpc/xdr.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/net/sunrpc/xdr.c b/net/sunrpc/xdr.c
> index 89cb48931a1f..4e4cad7aeec2 100644
> --- a/net/sunrpc/xdr.c
> +++ b/net/sunrpc/xdr.c
> @@ -955,9 +955,9 @@ EXPORT_SYMBOL_GPL(xdr_commit_encode);
>  static noinline __be32 *xdr_get_next_encode_buffer(struct xdr_stream *xdr,
>  						   size_t nbytes)
>  {
> -	__be32 *p;
>  	int space_left;
>  	int frag1bytes, frag2bytes;
> +	void *p;
> =20
>  	if (nbytes > PAGE_SIZE)
>  		goto out_overflow; /* Bigger buffers require special handling */
> @@ -986,12 +986,12 @@ static noinline __be32 *xdr_get_next_encode_buffer(st=
ruct xdr_stream *xdr,
>  	 * xdr_commit_encode() has shifted this one back:
>  	 */
>  	p =3D page_address(*xdr->page_ptr);
> -	xdr->p =3D (void *)p + frag2bytes;
> +	xdr->p =3D p + frag2bytes;
>  	space_left =3D xdr->buf->buflen - xdr->buf->len;
>  	if (space_left - nbytes >=3D PAGE_SIZE)
> -		xdr->end =3D (void *)p + PAGE_SIZE;
> +		xdr->end =3D p + PAGE_SIZE;
>  	else
> -		xdr->end =3D (void *)p + space_left - frag1bytes;
> +		xdr->end =3D p + space_left - frag1bytes;
> =20
>  	xdr->buf->page_len +=3D frag2bytes;
>  	xdr->buf->len +=3D nbytes;
>=20
>=20
>=20