Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Neil Brown <neilb@suse.de>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v1 0/5] Fix NFSv3 READDIRPLUS failures
Thread-Topic: [PATCH v1 0/5] Fix NFSv3 READDIRPLUS failures
Thread-Index: AQHYeRajF2lLZmuctEyl8+xbU047dq1D08MAgAAsdYA=
Date:   Tue, 7 Jun 2022 14:16:37 +0000
Message-ID: <E97EF595-3712-4BEA-82D8-EF8A1E08E0AB@oracle.com>
References: <165445865736.1664.4497130284832282034.stgit@bazille.1015granger.net>
 <165460185094.22243.5006042503446283679@noble.neil.brown.name>
In-Reply-To: <165460185094.22243.5006042503446283679@noble.neil.brown.name>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?GhzhzcyQphPUM6f8aNK8IxyyM2Pd3/tQXUcVtdAPd8DaTFcmjs9x5Slvc0rk?=
 =?us-ascii?Q?9tmWVkD7owryDRofG2AS2TfW8O1zP0cZJFVnNeUBQ1vP+bRsA2us7Av3CR73?=
 =?us-ascii?Q?JMi3m4Ej670+/UkeU8Tf8YmbS78qcF/XBFqmmgVrRycbUKz+jCzPk3gJ6sox?=
 =?us-ascii?Q?Br79UwR9KvMSWINTZTOOwBhSAmwDqsVkqjL/c9ajugf+xjmzbJkrnM7TS050?=
 =?us-ascii?Q?7LUkNJxflvnEn3j+y89wVEwI4QJEPsOhXsTN89L1i6KOsNUuSyOXa+F9Ymy8?=
 =?us-ascii?Q?p/j4q4KtVZW9lFrz+sCx4ai8KLV3BNwp2NUXIDG1ka75dj5yODJiG+MuFH7L?=
 =?us-ascii?Q?iuFAB88xkv4u0+GQIxyrVLu9RYtKqX8uSmrO7EJdn2BZjvJfTQkhOwQeVfX0?=
 =?us-ascii?Q?1PjqKkkJ7niyI5Io/MpttSSS55JD2pXzv2/GV2OcuZkjpDB8k4l3Bb2PEtv/?=
 =?us-ascii?Q?2BF+zT+ObzxvMKoailtePhbhPGQNZ0i6v6/6l63fuDB1bvWvbpWoXdY6Y7Lv?=
 =?us-ascii?Q?9Z74sJnhM4CeYjV5DQv8/RZIGrlNAZ8Q9LHYSqYuBMNHH+HPWq8OKPuK+C7a?=
 =?us-ascii?Q?S9Zrsz5XG1JBnoG9WSls9vuxuErDj9lKHkTs9p81e9rVdXzFkk7x/YUwb1F8?=
 =?us-ascii?Q?+WHZN9OU0Mnt1iqdquQsxP87YlX1e4JvrE5025wNXn0LcYOkLqKk3PBOAatr?=
 =?us-ascii?Q?dm6YDYlBe+Bxz8cur+ZpJ6Eyf42Hun75SJGsunDCHeDoREVm/niNza3ga5ag?=
 =?us-ascii?Q?JVPfMjGPW8/W7GbbR8kKxzzSh87VKojYWv+JSBqEeTqGNNyxm4imd1WmbyOv?=
 =?us-ascii?Q?TTLo3S/Dlr0rFs5Fxbi5MMP4KIdwndnE08iN8eCQ0EMWF8NZA2YZYr8Te0jg?=
 =?us-ascii?Q?kTCfMBOt+KE0Au7dKhvUJxIkeZe/jOZ2hvH7DCqQxdG5kmmkf7qodakmo0+e?=
 =?us-ascii?Q?s4Tw5luWKEjvzSI7olMYcqtuwM+C7LrrkeK2rurC7h58DVCSeSL8n0cCf+/H?=
 =?us-ascii?Q?dBjojaKqi9ilqkjkb5CIE+ZwR0PTzwzVp/BfmTlEWb/r9NtTSxRLZqnVdBZ3?=
 =?us-ascii?Q?fGCxmaRXQXe/jEc9UvqIs4B2d66DwoY5KZuJNKo5RbwV/6MA07MdLhhIE9zc?=
 =?us-ascii?Q?UoBWEkNVMfvFYCrgHAXgXIcu9CYf1w0qXpG/9GVZ/w956CsP/ngA8QEaDPHj?=
 =?us-ascii?Q?OfRcIQ9cgTvvfKC/L5B7drmVYsydPfiKhBD9Hx5baa8xawnkUCDjgfCizhQ+?=
 =?us-ascii?Q?+4A1eTkTJxQuUvrQDWchb4ereYEtOLgvL+cShZL3rNeT0d8w1tMhPRZwhp1s?=
 =?us-ascii?Q?c6+jcOq7q7vbxD+V1H8iLsbUhAJDIBWUruWpNisIb75dWT/9xx8NHZM88FV6?=
 =?us-ascii?Q?kpTFATIGqxp4SBmdNPRB9rYKnc4VPB34O9Spndlg039GZxg/AGuDihjDBSU8?=
 =?us-ascii?Q?FGJ9j1uL3xqAYTnQ0y2Q9z0AtOAUPFXnsVdNhIuLMPdfgmUV250lHHGt0jDd?=
 =?us-ascii?Q?37h2QHsdwygXjrjS8+7hV6d5rQYkZdQD0oaCMPEpBuftRja60ERJFlyqeKA0?=
 =?us-ascii?Q?2Ouu4wtZpT/8MQ1SuEVjhKp6iy+HgdGCpxBi7PfiQ1JJfZ8z1woWQhHsmNbP?=
 =?us-ascii?Q?MKiCmBalhVWyEy1tgtyFbatVA6fNT1N2EnQkduYcGc+RJGylXZYK6QwjtDii?=
 =?us-ascii?Q?l9FODdrvIpeRfn5ZncEcu+c3/gQB9LM1MiPIOXPftIN6k2nOMT90TdxC5MS+?=
 =?us-ascii?Q?9Rl5yWEAT3uInRTtRTmtHmyof6Xv+yw=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <A877F758EEE9194ABF3BD3712B86A230@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5d5bbade-2f2d-4be2-b557-08da48905599
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Jun 2022 14:16:37.4348
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: qq+3C7vP1I3GMNdqt7nBwci7tq7YIlDxiuYzyuXpsfpByV5rHaWdisrtwNwC36FOUZ6foM8QHSBVO+Wkf4b1Ug==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1914
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-07_06:2022-06-07,2022-06-07 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 bulkscore=0
 malwarescore=0 mlxlogscore=999 adultscore=0 mlxscore=0 phishscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206070058
X-Proofpoint-ORIG-GUID: E7cl8G-GkPqC7iUUwJjotftVPk4NDxUt
X-Proofpoint-GUID: E7cl8G-GkPqC7iUUwJjotftVPk4NDxUt
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Jun 7, 2022, at 7:37 AM, NeilBrown <neilb@suse.de> wrote:
>=20
> On Mon, 06 Jun 2022, Chuck Lever wrote:
>> While looking into the filecache CPU soft lock-up issue, I ran
>> across this problem. I thought I could run it down in just an
>> afternoon (I was wrong) and that this problem probably affects more
>> users than the soft lock-up (jury's still out).
>>=20
>> Anyway, NFSD's new READDIRPLUS dirent encoder blows past the end of
>> the directory payload xdr_stream when the client requests more than
>> a page worth of directory entries. I tracked this down to how
>> xdr_get_next_encode_buffer() computes xdr->end. First patch in this
>> series is the fix. The remaining patches are clean-ups and
>> optimizations.
>>=20
>> I want to get this into 5.19-rc quickly. I would appreciate getting
>> at least two R-b's for this series.
>=20
> Just for completeness:
>  Reviewed-by: NeilBrown <neilb@suse.de>
> for the whole series. Nothing I saw would justify any delay.

Thanks for your review. I have some thoughts about how to deal
idiomatically with your inlining optimization suggestion. I will
post a v2, I think that patch will be the only update.


> NeilBrown
>=20
>>=20
>> ---
>>=20
>> Chuck Lever (5):
>>      SUNRPC: Fix the calculation of xdr->end in xdr_get_next_encode_buff=
er()
>>      SUNRPC: Optimize xdr_reserve_space()
>>      SUNRPC: Clean up xdr_commit_encode()
>>      SUNRPC: Clean up xdr_get_next_encode_buffer()
>>      SUNRPC: Remove pointer type casts from xdr_get_next_encode_buffer()
>>=20
>>=20
>> net/sunrpc/xdr.c | 31 ++++++++++++++++++++++---------
>> 1 file changed, 22 insertions(+), 9 deletions(-)
>>=20
>> --
>> Chuck Lever

--
Chuck Lever