Received-SPF: softfail (google.com: domain of transitioning linux-nfs-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <86b11317-f663-602b-0459-129aa2101ba1@redhat.com>
Date:   Tue, 7 Jun 2022 16:52:57 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH nfs-utils] autoconf: change tirpc to check for a file, not
 for an include
Content-Language: en-US
To:     NeilBrown <neilb@suse.de>
Cc:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>
References: <165352672998.11129.5573262612495384287@noble.neil.brown.name>
 <165352679825.11129.7422243280120268766@noble.neil.brown.name>
From:   Steve Dickson <steved@redhat.com>
In-Reply-To: <165352679825.11129.7422243280120268766@noble.neil.brown.name>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5/25/22 8:59 PM, NeilBrown wrote:
> 
> Recent autoconf don't like variables in AC_CHECK_INCLUDE so we get a
> warning.
> In libtirpc.m4 we only need to check for the existence of a file, we
> don't need to extra  support for includes, such as defining HAVE_TIRPC_H
> or whatever.
> 
> So change from AC_CHECK_INCLUDE to AC_CHECK_FILE.
> 
> Signed-off-by: NeilBrown <neilb@suse.de>
Committed... (tag: nfs-utils-2-6-2-rc6)

steved.
> ---
>   aclocal/libtirpc.m4 | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/aclocal/libtirpc.m4 b/aclocal/libtirpc.m4
> index f7de5193c177..bddae0226931 100644
> --- a/aclocal/libtirpc.m4
> +++ b/aclocal/libtirpc.m4
> @@ -49,9 +49,9 @@ AC_DEFUN([AC_LIBTIRPC_OLD], [
>     dnl Also must have the headers installed where we expect
>     dnl to look for headers; add -I compiler option if found
>     AS_IF([test "$has_libtirpc" = "yes"],
> -        [AC_CHECK_HEADERS([${tirpc_header_dir}/netconfig.h],
> -                          [AC_SUBST([AM_CPPFLAGS], ["-I${tirpc_header_dir}"])],
> -                          [has_libtirpc="no"])])
> +        [AC_CHECK_FILE([${tirpc_header_dir}/netconfig.h],
> +                       [AC_SUBST([AM_CPPFLAGS], ["-I${tirpc_header_dir}"])],
> +                       [has_libtirpc="no"])])
>   
>     dnl Now set $LIBTIRPC accordingly
>     AS_IF([test "$has_libtirpc" = "yes"],