Received: by 2002:a5d:9c59:0:0:0:0:0 with SMTP id 25csp2327173iof; Wed, 8 Jun 2022 02:34:04 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzlKmTD0/TeDViUt78chiG3T9CLu7jWI2/jmLtmHWHGYd5ILK+jzFLzyvFrvWAFwLpADW7N X-Received: by 2002:a17:903:124e:b0:168:906e:acfb with SMTP id u14-20020a170903124e00b00168906eacfbmr3879581plh.0.1654680844051; Wed, 08 Jun 2022 02:34:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654680844; cv=none; d=google.com; s=arc-20160816; b=vt+xozXWAeOxqOAdsooweiUsw/dl59tc+WgsT94iyYi5xJII61XlH5IUYiOKToNeYX sE4xIawz9K760ji1JqyegtyUin+dDVfXpkOjtGAnhX/qDttq8cNIObQWUyvdEoC6wt2e wozsacEX3ODj7X4IIi+oeflY11Y5iNUMzeGrliw6wd5BKA35uf/U/ipzwcA8FE0ExSCo BjHOz0xkN0tdrYnuzJ+/1QkUxAoBcHOuYk3QRABj7b4UIhthX06iIw3Ut9Wh/P4AIXiO OIb6Abiq0eC+epY0IfFLidz58mwWR2s3ZXKGoz4wA2+KE8Ao+E2sj4KYrTcbXPLXopbg x9OA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=WeN0C3DdlZFELzEbLwkwOePH1x8klG/LHokEE+8tpD8=; b=ly/q6cDs1hro6lydzAmA8XaNVG/Od9V1T3NraCNjgdO91uW2a/dQ5FhvJI5F1XTdm4 hmA2BjYTY1O5D/nHwVDausXIX+VdGqtVxwXVWaitURqVAilEMLYArqBAOOOpBQTn/NKE OBxElSm9ap9kl9V8IueRva8Xc9ZettbcQClisqd5PupDaNWPDqT4LLqjV1cr4J1DlN+t nl2+1Otp2ZqngU0aFM5fY/ycyGKCGbwN0XQ0GW9pvQo1LnMYEhvyAPo8PCOKi0ZWmw9Q CGkc3lkFcN/afnzsnR0PfNDZtF7ixKGHVhD2SLr4fjnWU+uLVFTXsJsp9PfgZHZQX70f dQWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=wsH9uiJg; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id a2-20020a17090ad80200b001e34b8a4f18si28230012pjv.115.2022.06.08.02.34.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Jun 2022 02:34:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=wsH9uiJg; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6E620182A44; Wed, 8 Jun 2022 02:05:00 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233430AbiFHJE4 (ORCPT + 99 others); Wed, 8 Jun 2022 05:04:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233234AbiFHJCe (ORCPT ); Wed, 8 Jun 2022 05:02:34 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 240811A812; Wed, 8 Jun 2022 01:22:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=WeN0C3DdlZFELzEbLwkwOePH1x8klG/LHokEE+8tpD8=; b=wsH9uiJgejXz47LPZei+oWZJ8A IZnlV7edXHL4ha1oTvUSLDvPACCVildTVD97JYH+YvS9NQD9RErL2PLvTzmcgr4cEZ8aBBtU7ZwCY aHPMjH7G+wdRRxpAX/QKY6yOL0jhQ2PN0eLeui9tcc/n9UU64j1idJz8iDtPo/1JxWLSpPRJL94f5 NWFciD5tp8SfpISOi+rfKNtyER4G/F9X18tK/5bl3JEm66RhJ8d/wiXf7827VEZC+s/qMucFL87VG yj+VOb/XYsvobGBH3310knK3mTGpH5ks9wfGuRdLMe9BXnPKMkPuVQyYjxoDqSve7J4GXAN4+E9b2 URgJZjTA==; Received: from hch by bombadil.infradead.org with local (Exim 4.94.2 #2 (Red Hat Linux)) id 1nyquJ-00Btm1-BQ; Wed, 08 Jun 2022 08:19:15 +0000 Date: Wed, 8 Jun 2022 01:19:15 -0700 From: Christoph Hellwig To: "Matthew Wilcox (Oracle)" Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-aio@kvack.org, linux-btrfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-mm@kvack.org, linux-xfs@vger.kernel.org, linux-nfs@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, linux-mtd@lists.infradead.org, virtualization@lists.linux-foundation.org Subject: Re: [PATCH 09/20] mm/migrate: Add filemap_migrate_folio() Message-ID: References: <20220606204050.2625949-1-willy@infradead.org> <20220606204050.2625949-10-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220606204050.2625949-10-willy@infradead.org> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Mon, Jun 06, 2022 at 09:40:39PM +0100, Matthew Wilcox (Oracle) wrote: > There is nothing iomap-specific about iomap_migratepage(), and it fits > a pattern used by several other filesystems, so move it to mm/migrate.c, > convert it to be filemap_migrate_folio() and convert the iomap filesystems > to use it. Looks good: Reviewed-by: Christoph Hellwig