Received-SPF: softfail (google.com: domain of transitioning linux-nfs-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Bruce Fields <bfields@fieldses.org>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Trond Myklebust <trondmy@hammerspace.com>,
        Anna Schumaker <anna.schumaker@netapp.com>
Subject: Re: [PATCH v2 0/5] Fix NFSv3 READDIRPLUS failures
Thread-Topic: [PATCH v2 0/5] Fix NFSv3 READDIRPLUS failures
Thread-Index: AQHYetYGj/3jDvrME0iRnh1HU/dRZK1FtL4AgAABBYA=
Date:   Wed, 8 Jun 2022 16:35:09 +0000
Message-ID: <BFC4A686-A0FF-43A5-BBBE-8CDC7A809FD9@oracle.com>
References: <165463444560.38298.18296069287423675496.stgit@bazille.1015granger.net>
 <20220608163130.GB16378@fieldses.org>
In-Reply-To: <20220608163130.GB16378@fieldses.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Fr3KbGUMK9nMdLsOG5sg59sbaCYMkKOe6y7yrmhBzjCSzQkZUw3ATSU69Ug8?=
 =?us-ascii?Q?9K+Ggjh0u306+EER+6pbbIVwSi7PYvAifuo5ajG2ehialaeM9yxtPaHBacJL?=
 =?us-ascii?Q?qRRE5bik3j7tNQiuM/pVkma09rHzMBGkZS1XS6T00mwWtochN6lQSCe7jMVV?=
 =?us-ascii?Q?+PurY3Xi45oziUDdfh2kEsTj4gZuwYp5XyGSkHBxIPX2d5/Gxn9UsWPVqy+L?=
 =?us-ascii?Q?wyr2BuoJGfl30Vhd36uw7GwJAibH8kgOW02hzfC2PsqCOv37jJPo72tmSKm8?=
 =?us-ascii?Q?Yc0uDR3mZbLK6TNxJ1He3hx4APo5h3g0iu6vHFLaQsxuSQqCkWYvcptUmYub?=
 =?us-ascii?Q?WA9zRhdyo2WcW6xYuiQwdFUqvl8gNnCIgpWXHawxNrPEwYKWCmIEX1l3ULie?=
 =?us-ascii?Q?nfsKy/EB6dPJHp3oQJp1CnE9XSfXT3h4mL52K66rH75PDNkvfSyEL7sPPTMD?=
 =?us-ascii?Q?MZwa4KaT6kcSFpqDMfMp0ar2hjVjEUkRRWoYB1a9k+FYbXC1Wvz33hJ072H8?=
 =?us-ascii?Q?FF0UMWnfJRLjcgsdHTvhv8GABafBqpgfnvyIS3VPtaZ8tgJzbSyTUeLOWzhQ?=
 =?us-ascii?Q?9l4VCmxZK+7KeLg1s+CK12cU5bQ9MOJXu7BAR0psSU5qx8UZnpF4rRt4vt1i?=
 =?us-ascii?Q?khVL+tfpFXkd8hZqeL7j+pnanPhfi2Z0t6CmOAs5d8gnEC90AqNNr/FzWuJO?=
 =?us-ascii?Q?1JRx9mHDrcPSncwxoZH5BU3yfKb5Fl0AKPmkq320xLKypabHy/Uumm3QbFG5?=
 =?us-ascii?Q?Og7yEun26kshAkT2HhbXeOyDFj1Oa5hDUF/LasgBXrRchK5X4DlPJAO1dFZM?=
 =?us-ascii?Q?tbc3A2GXZYXvq3aI3JnaXdRRa0/iJpqbGRQSrnMUWZiXiTVD4T1kxk+NRWWr?=
 =?us-ascii?Q?FxHRwO+5ZW0KS0EO9YKWUxA+jvzcoMg0ZHXjkmv3d2K9TfoePBLctVIo0xHu?=
 =?us-ascii?Q?eVj1WIZXqWFOXmQoper/jdY/xTwK/JIV6s/sqTxd7N1HC+tLhqZt2Sq8AoIg?=
 =?us-ascii?Q?rPMDsIdITTyOH2tDuwG2iSbxsZbjyGPGdf2C2H5lpF+MtR12cNuiIc0OG9Gp?=
 =?us-ascii?Q?KQDZYW6vhz5MIUtSZv1ioDiQKHiLlR/ig38FsoasNwGAM6/X08tmZLoZTWnk?=
 =?us-ascii?Q?dU9+EdwQXUu3A0hEL5Amb13pv7NN4VSO1XvURNn5ClJ5odWEa3qH6dEWR3sC?=
 =?us-ascii?Q?Bb9SZKbHteUfrKCwx0BJ7LsC8h5soTKEAr4G52fqg2MOOT26q3zmAf7CmavR?=
 =?us-ascii?Q?H4eG6iJ2pVymoLYPpHhB5dugAIeo3MYGgb14NaKr9pAHLCAu5guFgVUOlyIh?=
 =?us-ascii?Q?MYh1SHBhjDA3SaQwcL6qibv5aBtvKBXqUXaN/GHSohUSJHGUSJ/FKQJGryO/?=
 =?us-ascii?Q?TE2nuf/mBAd2TDV8B7Wa4qLIES0aOCVEy2z2OxVyzVbo6Id/R+8qVYe7MoqF?=
 =?us-ascii?Q?RPfWuVKqtiFpVa/xxk7bV6LaD362/bgCaJxQyx1fEhT8ykbD+lqPxmxdHr4V?=
 =?us-ascii?Q?x10kUU107iBZO/bWkau4WMp8eOtTqPvsbxrk00qUMSrgR+TSP11KpwU5CNVE?=
 =?us-ascii?Q?xBB7oYS02Myjb2QIPn1D9XVweOiwg7GHHRD3bsyrVgNzm3QOKhzBxU/LvsVn?=
 =?us-ascii?Q?LCTnbWxabopk31ZugKjifYDNybSSffg/5biZ4+KITp0qnbektvb9RaEXWzrC?=
 =?us-ascii?Q?nactypJOUATmoieRBlADis6HhgKalkHyvp2Pvpeit6DtK1JK4Q/Vo4PhADIl?=
 =?us-ascii?Q?Jvv8r+DLZjme0AwL8sWSACT1caUde98=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3A4DC4113093A84685FBF6DB202938B3@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 637e9423-1fc1-421b-9db0-08da496cda82
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jun 2022 16:35:09.7166
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZyfP87PNUKESB3hv/XSACX7r95sCKVKJ01lN3NUAVNdF6C0nN6vg2cCVeaGm0bsE2y6/gFYVfx8fBOyuKmTHbg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1303
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-08_04:2022-06-07,2022-06-08 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 bulkscore=0
 malwarescore=0 phishscore=0 adultscore=0 suspectscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2206080067
X-Proofpoint-ORIG-GUID: Ba0v5wPoXfGOKMga3ymg027TNJylOWBm
X-Proofpoint-GUID: Ba0v5wPoXfGOKMga3ymg027TNJylOWBm
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Jun 8, 2022, at 12:31 PM, J. Bruce Fields <bfields@fieldses.org> wrote=
:
>=20
> Looks good.  Feel free to add my reviewed-by:.

Thanks!


> Do we have a test that reads a large enough directory?

Yes. I've been using a script that downloads and builds git, then runs
its unit test suite. That generates multi-page directory entry payloads.


> Seems like that
> plus the right kernel debugging options should have caught the original
> bug.

Yep, it triggered svcrdma_small_wrch_err.


--
Chuck Lever