Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1770563iog; Thu, 16 Jun 2022 13:30:27 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vENHWaMPBei7EO5VDekyS10W4oEKBE2yLYAU/B+0+HcfePwY9POOrUQeQysch09uW3BifA X-Received: by 2002:a05:6402:21a:b0:431:5c52:82bb with SMTP id t26-20020a056402021a00b004315c5282bbmr8840137edv.70.1655411426942; Thu, 16 Jun 2022 13:30:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655411426; cv=none; d=google.com; s=arc-20160816; b=BZuyFCQqbLG5s9TGpLJZrMAnOwMsKKiwrrXhIVDLq0xH4fdPKdSTaSgpmDtQn1iuwf ExWBmnocMaNP+Gn4uu6iLClewhwX9Vsga12OUORIE43MPstA7fqVdq//1XSOci/WgnRW fqAvgByvQnJl//akNBTYARKCU4rpXY07ZauAg+UDSppnJYb3XSB4nS6QxmgKGSw+4kWT Q/EYtGEnDYt+UTwDKEpv1z2xYN7CADNO4qlv2DnSirhu/6OL8ebp8oGODPUd/PxZ7DEZ RS8DUgCH3izLlKMAQB0VrGM9ho7A4IP6vEIWl8234gX25+8QqCEE/Ns6ZrBHRBJohwYk dsiA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:to:from :dkim-signature; bh=kx/LUPv0bPXL1iyWPVt9+hVuqushkKMELxnCgrepSVQ=; b=saihL8rYL0CFTgJ08i8zO+L6lZuvzt0CZjxHtcrR2CnqEtEdsyH188oq4c48b8GdJt NI5U54gYnFhV57D2lAaMfCwntbqJhUiRB9dK14U7CgN5MOqSOfN4Jjf1/ifGvKny7/Ta AU7KVxpSPzryRLBDu9hwlLNYhBOrSbMCyxCmbJ56zvBRZaHcFZyWOOuDWjI3TOlsN6z/ Lp+haWD83J+71qrjqa9qJv+V9knzg8ontXsDsus8kXX/cJ8GyTOwkoYbiZ3pq31hYTCd yN1Me9/KiFJOQuqyyRTQ1/ytcfSo5VvqqSXFcJI5ZX6GGSK8enhULHQ4DgjgXRsIntBX ZBlQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Zq3ufc1v; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r8-20020a50aac8000000b0042b9c69af1dsi3684797edc.90.2022.06.16.13.29.52; Thu, 16 Jun 2022 13:30:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Zq3ufc1v; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378664AbiFPU3I (ORCPT + 99 others); Thu, 16 Jun 2022 16:29:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378667AbiFPU3H (ORCPT ); Thu, 16 Jun 2022 16:29:07 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1EDAD5C750 for ; Thu, 16 Jun 2022 13:29:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655411345; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kx/LUPv0bPXL1iyWPVt9+hVuqushkKMELxnCgrepSVQ=; b=Zq3ufc1vS15RtRUTuvwV3cmsTuKL1+SMaeh+GLQiOoqXWcnj4rsTXH5UQzeaRClI9xfY7C CpW/CkXWXc2tzdN0Jlr1/Sof0chc8G6qZsQ5ia0fPMLb+K3n94ZqMxFTwDR9OCvBQIGCRe LZyzgUCKem2BDe0Q8OSECDCgwkVhpt0= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-526-H8Odn6DhPqm84xQB1StjiA-1; Thu, 16 Jun 2022 16:29:04 -0400 X-MC-Unique: H8Odn6DhPqm84xQB1StjiA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B648F3C0CD50 for ; Thu, 16 Jun 2022 20:29:03 +0000 (UTC) Received: from madhat.home.dicksonnet.net (unknown [10.2.16.194]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8994C40334E for ; Thu, 16 Jun 2022 20:29:03 +0000 (UTC) From: Steve Dickson To: Linux NFS Mailing list Subject: [PATCH 4/4] acl_nfs4_get_who: removed an always false evaluate warning Date: Thu, 16 Jun 2022 16:29:02 -0400 Message-Id: <20220616202902.53969-4-steved@redhat.com> In-Reply-To: <20220616202902.53969-1-steved@redhat.com> References: <20220616202902.53969-1-steved@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 2.85 on 10.11.54.10 X-Spam-Status: No, score=-3.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org Signed-off-by: Steve Dickson --- libnfs4acl/acl_nfs4_get_who.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libnfs4acl/acl_nfs4_get_who.c b/libnfs4acl/acl_nfs4_get_who.c index 695db2e..3e2fd7c 100644 --- a/libnfs4acl/acl_nfs4_get_who.c +++ b/libnfs4acl/acl_nfs4_get_who.c @@ -49,7 +49,7 @@ int acl_nfs4_get_who(struct nfs4_ace* ace, int* type, char** who) char* iwho = NULL; int wholen; - if (ace == NULL || ace->who == NULL) + if (ace == NULL) goto inval_failed; itype = acl_nfs4_get_whotype(ace->who); -- 2.36.1