Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <8337cf24-d8d2-034a-a6e7-47900d2d2165@redhat.com>
Date:   Tue, 21 Jun 2022 09:26:20 -0400
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH 1/3] cifs-utils/svcgssd: Fix use-after-free bug (config
 variables)
Content-Language: en-US
To:     marcel@linux-ng.de, linux-nfs@vger.kernel.org
References: <20220607081909.1216287-1-marcel@linux-ng.de>
From:   Steve Dickson <steved@redhat.com>
In-Reply-To: <20220607081909.1216287-1-marcel@linux-ng.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

All 3 patch committed (tag: nfs-utils-2-6-2-rc7)

steved.

On 6/7/22 4:19 AM, marcel@linux-ng.de wrote:
> From: Marcel Ritter <marcel@linux-ng.de>
> 
> This patch fixes a bug when trying to set "principal" in /etc/nfs.conf.
> Memory gets freed by conf_cleanup() before being used - moving cleanup
> code resolves that.
> 
> ---
>   utils/gssd/svcgssd.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/utils/gssd/svcgssd.c b/utils/gssd/svcgssd.c
> index 881207b3..a242b789 100644
> --- a/utils/gssd/svcgssd.c
> +++ b/utils/gssd/svcgssd.c
> @@ -211,9 +211,6 @@ main(int argc, char *argv[])
>   	rpc_verbosity = conf_get_num("svcgssd", "RPC-Verbosity", rpc_verbosity);
>   	idmap_verbosity = conf_get_num("svcgssd", "IDMAP-Verbosity", idmap_verbosity);
>   
> -	/* We don't need the config anymore */
> -	conf_cleanup();
> -
>   	while ((opt = getopt(argc, argv, "fivrnp:")) != -1) {
>   		switch (opt) {
>   			case 'f':
> @@ -328,6 +325,9 @@ main(int argc, char *argv[])
>   
>   	daemon_ready();
>   
> +	/* We don't need the config anymore */
> +	conf_cleanup();
> +
>   	nfs4_init_name_mapping(NULL); /* XXX: should only do this once */
>   
>   	rc = event_base_dispatch(evbase);