Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp4862610iog; Wed, 22 Jun 2022 07:15:45 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uTfDXodP7QcK2tEeoSbUGyZkg1SCqW15tkSUY1aHzdEls072JLcf+9JIMgbgos9TzVXn0A X-Received: by 2002:a17:90b:2391:b0:1ec:a241:5e79 with SMTP id mr17-20020a17090b239100b001eca2415e79mr19083458pjb.24.1655907344919; Wed, 22 Jun 2022 07:15:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655907344; cv=none; d=google.com; s=arc-20160816; b=viLzuI0b+o2U4RU4gq+r7QBT8cZQGxqmpLt7jXT4NZ8+24QZb86eAb4RhzkoZkIpLn ozR6Ev9P3Yu6+EaHBSRh5PTDJW7O+CswgrMVf8KR2QttAhqVT8APHXKmf6kooURLPc1K En/vASv295CjPGpxMzabr9k9HtpdJ+qkdvYoyhCxpFWaqd1au1drCpBmfxHakH1K66s1 QWWpOcixNHUR8rEjjcetZ+59uVo7JvakKd8VKScJyqRaZlmzufCKl0c72XDRta+8aQHX WppDFANeO/BGDa6eV1ui3KjENoXwAFseXKFr18LSWTdghM5ADTjkX6bMbKummn0Hfmd0 s3tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject; bh=0uF8Bbq6S8fJKoBK1K6ewRcISmdSREwhQ/KKlOuQvF4=; b=wGFiGYVVcAgzLuvV4Nlr3UZZB3WmBYr2LI3y2fCvRbFKlMZ5SlBBJ/Sjs6qEMvp/y6 Eu1AUNHgnwROWXkNYOq5ehSujDScoB1LdZVLSWuT+PfZLBTR2MRfP1cHz24Nesg0kLep hLuALAjnkFmLpRma3p5vc5WvSeONWK+WCU9CeoePX6gdt6VGgGt36tvnzBWTJOTAHXvi IMr4S01ewmrYZoCkRJ+x8SPwK0PzczkMutOpbSk4U2V22zdpCHvSDxYjDEypOrWp2nmm gPUeoIvurS6dLWZhyYZomHxYqYHoywDD89o/9rJ4XLwYCN4+4OC05RgsdvWWpJKekbps mkdg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s13-20020a17090302cd00b0015848a89d82si23592399plk.107.2022.06.22.07.15.31; Wed, 22 Jun 2022 07:15:44 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1358364AbiFVOOb (ORCPT + 99 others); Wed, 22 Jun 2022 10:14:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1358337AbiFVOOS (ORCPT ); Wed, 22 Jun 2022 10:14:18 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6075FE0B2; Wed, 22 Jun 2022 07:14:09 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id F1D6CB81F5B; Wed, 22 Jun 2022 14:14:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 396DFC34114; Wed, 22 Jun 2022 14:14:06 +0000 (UTC) Subject: [PATCH RFC 12/30] NFSD: Hook up the filecache stat file From: Chuck Lever To: linux-nfs@vger.kernel.org, netdev@vger.kernel.org Cc: david@fromorbit.com, tgraf@suug.ch, jlayton@redhat.com Date: Wed, 22 Jun 2022 10:14:05 -0400 Message-ID: <165590724513.75778.16837692771867171102.stgit@manet.1015granger.net> In-Reply-To: <165590626293.75778.9843437418112335153.stgit@manet.1015granger.net> References: <165590626293.75778.9843437418112335153.stgit@manet.1015granger.net> User-Agent: StGit/1.5.dev2+g9ce680a5 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org There has always been the capability of exporting filecache metrics via /proc, but it was never hooked up. Let's surface these metrics to enable better observability of the filecache. Signed-off-by: Chuck Lever --- fs/nfsd/nfsctl.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c index 0621c2faf242..631bf8422c0f 100644 --- a/fs/nfsd/nfsctl.c +++ b/fs/nfsd/nfsctl.c @@ -25,6 +25,7 @@ #include "state.h" #include "netns.h" #include "pnfs.h" +#include "filecache.h" /* * We have a single directory with several nodes in it. @@ -46,6 +47,7 @@ enum { NFSD_MaxBlkSize, NFSD_MaxConnections, NFSD_SupportedEnctypes, + NFSD_Filecache, /* * The below MUST come last. Otherwise we leave a hole in nfsd_files[] * with !CONFIG_NFSD_V4 and simple_fill_super() goes oops @@ -229,6 +231,13 @@ static const struct file_operations reply_cache_stats_operations = { .release = single_release, }; +static const struct file_operations filecache_ops = { + .open = nfsd_file_cache_stats_open, + .read = seq_read, + .llseek = seq_lseek, + .release = single_release, +}; + /*----------------------------------------------------------------------------*/ /* * payload - write methods @@ -1371,6 +1380,7 @@ static int nfsd_fill_super(struct super_block *sb, struct fs_context *fc) [NFSD_Ports] = {"portlist", &transaction_ops, S_IWUSR|S_IRUGO}, [NFSD_MaxBlkSize] = {"max_block_size", &transaction_ops, S_IWUSR|S_IRUGO}, [NFSD_MaxConnections] = {"max_connections", &transaction_ops, S_IWUSR|S_IRUGO}, + [NFSD_Filecache] = {"filecache", &filecache_ops, S_IRUGO}, #if defined(CONFIG_SUNRPC_GSS) || defined(CONFIG_SUNRPC_GSS_MODULE) [NFSD_SupportedEnctypes] = {"supported_krb5_enctypes", &supported_enctypes_ops, S_IRUGO}, #endif /* CONFIG_SUNRPC_GSS or CONFIG_SUNRPC_GSS_MODULE */