Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220607081909.1216287-1-marcel@linux-ng.de> <20220607081909.1216287-3-marcel@linux-ng.de>
In-Reply-To: <20220607081909.1216287-3-marcel@linux-ng.de>
From:   Andreas Hasenack <andreas@canonical.com>
Date:   Mon, 27 Jun 2022 18:57:03 +0000
Message-ID: <CANYNYEG553LGsgf47nM+Y-nDO=oQLaCrfPAFG+_vsXWrh3u+Zg@mail.gmail.com>
Subject: Re: [PATCH 3/3] cifs-utils/svcgssd: Add (undocumented) config options
 to man page
To:     linux-nfs@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On the heels of this patch, you might want to add this tiny bit to
also update the nfs.conf(5) manpage:
--- a/systemd/nfs.conf.man
+++ b/systemd/nfs.conf.man
@@ -283,7 +283,10 @@
 .TP
 .B svcgssd
 Recognized values:
-.BR principal .
+.BR principal ,
+.BR verbosity ,
+.BR rpc-verbosity ,
+.BR idmap-verbosity .

 See
 .BR rpc.svcgssd (8)

On Tue, Jun 7, 2022 at 8:19 AM <marcel@linux-ng.de> wrote:
>
> From: Marcel Ritter <marcel@linux-ng.de>
>
> There seem to be some undocumented options implemented.
> Why not mention them in the man page?
>
> ---
>  utils/gssd/svcgssd.man | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/utils/gssd/svcgssd.man b/utils/gssd/svcgssd.man
> index 15ef4c94..8771c035 100644
> --- a/utils/gssd/svcgssd.man
> +++ b/utils/gssd/svcgssd.man
> @@ -61,6 +61,19 @@ this is equivalent to the
>  option.  If set to any other value, that is used like the
>  .B -p
>  option.
> +.TP
> +.B verbosity
> +Value which is equivalent to the number of
> +.BR -v .
> +.TP
> +.B rpc-verbosity
> +Value which is equivalent to the number of
> +.BR -r .
> +.TP
> +.B idmap-verbosity
> +Value which is equivalent to the number of
> +.BR -i .
> +
>
>  .SH SEE ALSO
>  .BR rpc.gssd(8),
> --
> 2.34.1
>