Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 1 Jul 2022 11:54:14 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
CC:     Trond Myklebust <trond.myklebust@hammerspace.com>,
        Anna Schumaker <anna@kernel.org>, Jens Axboe <axboe@kernel.dk>,
        Chaitanya Kulkarni <kch@nvidia.com>,
        Kees Cook <keescook@chromium.org>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        "Gustavo A. R. Silva" <gustavoars@kernel.org>,
        Chuck Lever <chuck.lever@oracle.com>,
        Baptiste Lepers <baptiste.lepers@gmail.com>,
        <linux-nfs@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nfs: Replace kmap() with kmap_local_page()
Message-ID: <Yr9C1h8fIAneJ9MU@iweiny-desk3>
References: <20220628182426.944-1-fmdefrancesco@gmail.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20220628182426.944-1-fmdefrancesco@gmail.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?/etYTQpQXB9ZPstAuaA7/O90CeSt0hevCtzxcNiBeDN+c1q3KohRhajG8Rk4?=
 =?us-ascii?Q?O4Pe8tU+0g8c7IobdIrtfqzbd6oxjPNwBduzXfSnCekKVJzz6uxhsxkJzBvi?=
 =?us-ascii?Q?qthW1Y2Ea87+xAQyY7h9f3pjzSVTM45x7fXZ2o/E+QpMmSxEbVc22EOzwh3D?=
 =?us-ascii?Q?L7w5HWERyvxlsNP2XnPGeaXFAuHdozRYE7cW58l+4ooIrt++vZNNY0tqnzz7?=
 =?us-ascii?Q?II+OHLwT+eKWFzvZY62Rr//Rx1S3tUZ4n0z1nJAnw3uDhyErztBugbTsSRsm?=
 =?us-ascii?Q?D08IfHvgv0V3e8TguErwdNkrrJwS6ikEsPih18tqR8VRARYMLt0VkDWulXa4?=
 =?us-ascii?Q?IBuxGCIgw/ZGNV87yN8hOUYkmpbbTU1bruChEq5z1l1au+BI4E2eSxG2Bz+m?=
 =?us-ascii?Q?1XLOn1sSCXBKncXPw5r4idJejcT7G/TIAr2a6fvAA6/55xiHdmX3y/kTTapW?=
 =?us-ascii?Q?JlfQrjQMW4JXHln+q1ygH4wRMkSPClR5eODgYbl+XMtB9EnOy5YMHqDJ9rhN?=
 =?us-ascii?Q?WtkrYjeGHC4SnKF04VptN/Y5f/b64B390/GSZiSG/83rrkanRUEBwBGiVY5c?=
 =?us-ascii?Q?JI0525n4ugkarx/GJTy7ZyjCG4qQFQUHnXtp2GVrsFG2MCkn/EiQyxzCs4No?=
 =?us-ascii?Q?Ukv5LfVPIDPhEsx78rCZbfiBrj9SyK+qPnatPkBgxLWBHs+Yk82kfQinKLuc?=
 =?us-ascii?Q?ZSVVjgLI3HjWKhJT9MpY+vlbiETWeeQfPpoa8Y9jpNFhbWIQGxGrX/GmcK4F?=
 =?us-ascii?Q?8f0af7Y5kkg4J3vo0ISF/Zf9lh+vRNYKlTY4HyhxZroi6ZaH2IdPPSff9cPU?=
 =?us-ascii?Q?SZhZzE+vjn7aLK/1ryt9QnmWb7usVyllGi9ZY9TfvNf6l83Zc/L36uyIh/Ef?=
 =?us-ascii?Q?h64mJw8XKyPuDA4z2aYvP/jP8Zu19aSdO9Vyr4l1LZhmnLu1kx1GSC+oBtQO?=
 =?us-ascii?Q?HfQWIdvkN7Fbl6xDevzll2FzEr3gHEwXUv8LkQo+BejjBVevqsl/ofikR3IW?=
 =?us-ascii?Q?k/b3PTrTyMtY9MXRnGNDXuWIwmYHRTLfaAZQ1Twp8IIrRM5QbEy7z7F3qKJ1?=
 =?us-ascii?Q?eqD/fo3+1fPUmlT7AFzOrnS6+RbuLdpzVKSaAopHPEhVAUsAFzaTXbo6oGBU?=
 =?us-ascii?Q?3byai6tJfhl8IiXat1ph92MkAULojTXjtwHieHQxFMuAaeqQsugpUWNRGHhS?=
 =?us-ascii?Q?hxkruOdg2AD8RqofRCTVgFytkS7oH48BlhOPXYDlkvFp4Xm/4NwdwOLuFHuV?=
 =?us-ascii?Q?Kp+EOGqyL7XKpMz7HmWNCeHFV+4K4ILk2uHhWqnomFMNU67ziFvuRCENENyq?=
 =?us-ascii?Q?SL/JXyDlKFWWzRG0G2CUUQ2oSc8Fo46Tbej5jN3VnWLbWuLnluNtJzkV0rll?=
 =?us-ascii?Q?UbUTWT+3dJ8gLfGiG/ZeHhB35u74nYfipWYpZ/xcPZgs2gAf16qG6zdniZ2h?=
 =?us-ascii?Q?UVEZ9cqouwi1MRRDJvlCZKwhDWHE7SkuJ14amvlNirlAN6KvNJZqTo0Jzw5y?=
 =?us-ascii?Q?J6YSxVlWKnBM5HxCXQsOzDfLVVX9YVWD4S3Lcsq1/x/LzQ244UO+lozvIjJp?=
 =?us-ascii?Q?4dkPLxHssJ6YKAdnaYJ6Kb3p7/VSbE2zleeYc3kphGt1DREEpXtrZuKryWbI?=
 =?us-ascii?Q?G3s1CCcQeeUPC78V0/iYZC97PMMH6A8nI9ekxw6AbkK/?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a9fccab3-385a-4a27-94c5-08da5b931d43
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6311.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jul 2022 18:54:23.7509
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: H9q6og2WSRTGcYwIz2HR10cVLxxEVwLpkn+N6Y8yNb/sHGZBiF5z4L95DKVYwkAlC3UbgA/3q2n0usBFVFJyqQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1101MB2133
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI,
        RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

On Tue, Jun 28, 2022 at 08:24:26PM +0200, Fabio M. De Francesco wrote:
> The use of kmap() is being deprecated in favor of kmap_local_page().
> 
> With kmap_local_page(), the mapping is per thread, CPU local and not
> globally visible. Furthermore, the mapping can be acquired from any context
> (including interrupts).
> 
> Therefore, use kmap_local_page() in nfs_do_filldir() because this mapping
> is per thread, CPU local, and not globally visible.
> 
> Suggested-by: Ira Weiny <ira.weiny@intel.com>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> Signed-off-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
> ---
> 
> I cannot test this patch for several reasons. While these changes seem safe
> and trivial, I would feel better if people familiar with NFS could take the
> time to properly test this patch. Thank you.
> 
>  fs/nfs/dir.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
> index 0c4e8dd6aa96..8b89f10d8899 100644
> --- a/fs/nfs/dir.c
> +++ b/fs/nfs/dir.c
> @@ -1084,7 +1084,7 @@ static void nfs_do_filldir(struct nfs_readdir_descriptor *desc,
>  	struct nfs_cache_array *array;
>  	unsigned int i;
>  
> -	array = kmap(desc->page);
> +	array = kmap_local_page(desc->page);
>  	for (i = desc->cache_entry_index; i < array->size; i++) {
>  		struct nfs_cache_array_entry *ent;
>  
> @@ -1110,7 +1110,7 @@ static void nfs_do_filldir(struct nfs_readdir_descriptor *desc,
>  	if (array->page_is_eof)
>  		desc->eof = !desc->eob;
>  
> -	kunmap(desc->page);
> +	kunmap_local(array);
>  	dfprintk(DIRCACHE, "NFS: nfs_do_filldir() filling ended @ cookie %llu\n",
>  			(unsigned long long)desc->dir_cookie);
>  }
> -- 
> 2.36.1
>