Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Neil Brown <neilb@suse.de>
CC:     Al Viro <viro@zeniv.linux.org.uk>, Daire Byrne <daire@dneg.com>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 08/12] nfsd: allow parallel creates from nfsd
Thread-Topic: [PATCH 08/12] nfsd: allow parallel creates from nfsd
Thread-Index: AQHYf3xEYb3JC5iP2UakViwbS7bjd61lf+CAgAAJfQCACQt7AA==
Date:   Mon, 4 Jul 2022 17:17:16 +0000
Message-ID: <0A08512F-E081-4451-976F-498611D9365E@oracle.com>
References: <165516173293.21248.14587048046993234326.stgit@noble.brown>
 <165516230200.21248.15108802355330895562.stgit@noble.brown>
 <CF45DA56-C7C7-434C-A985-A0FE08703F8D@oracle.com>
 <165645779028.15378.2009203210771986783@noble.neil.brown.name>
In-Reply-To: <165645779028.15378.2009203210771986783@noble.neil.brown.name>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?C/N2v4xUWW/a0OkMoOldcXN5k5Uvd2cJiiP7h9w0KJFy6Lt2Ltz+t/4+lqvV?=
 =?us-ascii?Q?YXDZwgscWfvigA4aBwZyDbbDsWhrQN435+EcjNPB8RmSjY0iTpZfZM0Knkyn?=
 =?us-ascii?Q?S3jt3VzmGZafQGAKvEJjD1UeNbXg2grxRksMJpQJJAjPaTN+pQrFDpTlt+Sd?=
 =?us-ascii?Q?3LPTCwKf9DLYcvsYuVfOVSK9oPh1aAFxXu2hY0zlL7n9GZ1sbXaPvWw+tSz9?=
 =?us-ascii?Q?gPmCa4q5oBgmPCflepQ1X8ikzqrRMf5NxQ9Ku7Du40YUb+Fe0v2xLbNL0XAE?=
 =?us-ascii?Q?71DEZfbZlfcF7RJ/nDt3PkIkYk9t0mOFgcQmY3c4jM08dj2DCpOsCyiPubdX?=
 =?us-ascii?Q?5V6+h4ZBglWaKRpTdgK4X2Bsarfe31z64IMw/exDESEvvG/HSk+ZkU9AGpcC?=
 =?us-ascii?Q?SHXe0IpdUm2N7uhL87rrb8AJFlPgNG3fIB1nibLmIH6nBap4q24jIzCd7yas?=
 =?us-ascii?Q?PlRx4JHUaCcJKhxSjMpnwal39x3rB9NmKYnAmzDfVBvISfpwGEp/K0SkCkir?=
 =?us-ascii?Q?VAagZJb6a+8ZA8JmuvQfTxEqH+7/CIv6TSA/hMapmkkAtcskIYG0Cj+R7eZX?=
 =?us-ascii?Q?4MdNntvYXmEtLvGiiuIuvks5NKgS1yPAUyCbYaAYaD22lE5OP4NPVq0W3Aa5?=
 =?us-ascii?Q?rI1P2Nt3dUIUqvjgOB4ZSWZtXmfe+jeQwpGiZvxy1bM95K7olc3xTUZXrErb?=
 =?us-ascii?Q?kXaaABEp/mIwwbfIWpLPzU11xEUyOE8GehPSWOMlt4Bkl03KTkfZCjohrXM3?=
 =?us-ascii?Q?n/RIUBR+MEFxqaKQTFBzevNHm9VexIduaK5kkvFkuTG+3wSYcb9GDzdgYM5j?=
 =?us-ascii?Q?LtnxCxVA3Uw15NDnuRvMZNzwb0SbTZHhuN9czC+q90ph24wxrVuFFeePzJGB?=
 =?us-ascii?Q?gTorhCpusITTyQWcbNeRkyO/a84GTQv7T+CRg7siY0BVTHU2bwEbr7o9QAiX?=
 =?us-ascii?Q?yhaIxhra966+13K6/bRxBWXlJHO+6inBmpLUXkc2cZJ4Z6x4tnhVYwAi4M6S?=
 =?us-ascii?Q?qf5vjWje7Xa8vg7XFkN8ZR6pdFUC+IktfnhaGFFrdvSOsWJm3En2/O9R5/vz?=
 =?us-ascii?Q?pV2sjRwnF2n99mVyLaUYU9t1b6CHQOrQ39JfW95XOM7zPSTUTPfcbQcV1Q5V?=
 =?us-ascii?Q?3QlQyYQYGMRnonNdYCvl0rDYBNd83vlqyNe7qVgWUF43cGpw2h2ZiXcw33sd?=
 =?us-ascii?Q?Koc2wy0Jgrpr+X9fbLuqGVuTxehQdlKhviAr9FNjiAPoVYJ2fh0LRo6gYWYu?=
 =?us-ascii?Q?J2KT2VyifZZKorRYGqIX8ISSPVne/I7AgcG6EgzT7DbKhofoWvuy9MGZGzpz?=
 =?us-ascii?Q?lFRYK0NEx6Nzrt4kwfZxwCHrcw/4bvKcaPMoFle412Rp0aUeFOHdvTAANjdO?=
 =?us-ascii?Q?+qBqoHoiyeW/kUuXLDmBp5/YWwE9dKnLPN+RcLSL74Ozl2oaaj9FPMXIvmsH?=
 =?us-ascii?Q?jrja1J1wxdhyT1qdnOHYsZYWhke3iNsm2H/Fimq8CDTkjKe3dBDlxAdPjfPs?=
 =?us-ascii?Q?QjMaGfMPiJ4Q1nBCUjt3TiRGLmrpWT+pmEVv9sl177bGZiZs22YSYMx2MUB2?=
 =?us-ascii?Q?5x7+vBVK8uosexlsb+60cCqIck+T7+9JtFz7CCuA8Y4Clq4drDe722DlYUpR?=
 =?us-ascii?Q?mQ=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1E6A8D2A7577D54F81BEFA31A45EDDBF@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e6e513d0-4b59-4031-0fc3-08da5de10b8f
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jul 2022 17:17:16.9140
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: bjKLJi6AifKMeEfKCTBXoeT6RN6dAbdUwmxmo9SFKzxhPze8SUD5cdn2nTjNIyotIWnGy32ZOWCywFELSjzgyw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR10MB6216
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-04_16:2022-06-28,2022-07-04 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 suspectscore=0 mlxscore=0
 mlxlogscore=999 adultscore=0 spamscore=0 phishscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2207040075
X-Proofpoint-GUID: Qyh3khehpj7vfKIin_X7SaMh_kxRuxuq
X-Proofpoint-ORIG-GUID: Qyh3khehpj7vfKIin_X7SaMh_kxRuxuq
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Jun 28, 2022, at 7:09 PM, NeilBrown <neilb@suse.de> wrote:
>=20
> On Wed, 29 Jun 2022, Chuck Lever III wrote:
>>=20
>>> On Jun 13, 2022, at 7:18 PM, NeilBrown <neilb@suse.de> wrote:
>>> diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c
>>> index c29baa03dfaf..a50db688c60d 100644
>>> --- a/fs/nfsd/nfsfh.c
>>> +++ b/fs/nfsd/nfsfh.c
>>> @@ -616,7 +616,7 @@ fh_update(struct svc_fh *fhp)
>>> * @fhp: file handle to be updated
>>> *
>>> */
>>> -void fh_fill_pre_attrs(struct svc_fh *fhp)
>>> +void fh_fill_pre_attrs(struct svc_fh *fhp, bool atomic)
>>=20
>> Hi Neil, just noticed this:
>>=20
>>  CC [M]  fs/nfsd/nfsfh.o
>>  CHECK   /home/cel/src/linux/linux/fs/nfsd/nfsfh.c
>> /home/cel/src/linux/linux/fs/nfsd/nfsfh.c:621: warning: Function paramet=
er or member 'atomic' not described in 'fh_fill_pre_attrs'
>=20
> Thanks.  I"ll address that, and also the other issues that you raised in
> your patch-by-patch review.  Thanks for those.
>=20
>>=20
>> And... do you intend to repost this series with the supplemental
>> fixes applied?
>=20
> I've been a bit distracted this week, but my current plan is to
> reorganise the patches to put as many of the NFS and NFSD patches as
> possible before the VFS patches.  There should then just be one each for
> NFS and NFSD after the VFS changes.  I hope to post that series early
> next week.
>=20
>>=20
>> Should we come up with a plan to merge these during the next
>> window, or do you feel more work is needed?
>=20
> I think it would be reasonable to merge the preliminary NFS and NFSD
> patches in the next window.  I'd really like to hear from Al before
> pushing the rest too hard.  Probably after rc1 I'll post the remainder
> of the series and include Linus if we haven't heard from Al.  I'd be
> perfectly happy if the main content of the series landed in the
> subsequent merge window.

Please base your patches on the "for-next" branch in this repo:

https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git

Thanks!


--
Chuck Lever