Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <c09e1af7-7d1f-1bbf-5562-ead9a4d99562@oracle.com>
Date:   Tue, 5 Jul 2022 12:37:12 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.11.0
Content-Language: en-US
From:   dai.ngo@oracle.com
To:     linux-btrfs@vger.kernel.org
Cc:     gniebler@suse.com,
        "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: bug in btrfs during low memory testing.
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dSsrYWpEdUNqYXphWHBwVXdublQyVjJFQTlCVnlmU2lMVTVJc3gyeDg3ZG1p?=
 =?utf-8?B?dUJtV2U3TEZ3c213SVdPNTlMdUxYZDRNdmk5T3lYS3R2WENFYk1SdFVDV0Js?=
 =?utf-8?B?R0VUbUthUzZvR29sMkdNQnRudWY0SnM0ZGdTZkJ3TU5UN29YYW5Sc1lxYnNu?=
 =?utf-8?B?dVV3WEF2d0hzSTdIOGZCTktTb3pkbnB2NVE3ZEpNWUZKMDlWVnpHakhGZWw4?=
 =?utf-8?B?UTZPQWlUSGRzK2dtZXNMWXg3Ri9aUTJ6Z3h6UFIzN1JXZHBvQTJRTXJTNmM3?=
 =?utf-8?B?VitpN3luM2d4ak1NZmprV2VVNkEvSC8yRGJtRUo3dGRGUi9aL2lqWEI0eW9j?=
 =?utf-8?B?WFNHUFowUHloY3liODVwdzBQdHNiUkJTMEFaZXdGTzN6bFBjeHZhNE9RSGxN?=
 =?utf-8?B?dUhoaHZUemFoQWlXbE1aY2xzRzBQTXBteXRuVXE0RWN4ZDRwVmxmT1Ezc1lv?=
 =?utf-8?B?STViby92L01UUCs3bGRiVncxSGNYS2RRYzdDTk9JV3V2aVQ2SUlaTkNUZjFi?=
 =?utf-8?B?dDkvNDNrSWxYeThMM0pINmFYdlRtYmdwSXJYOVdIZ3ZVYWcvbHRPOEI0aUMx?=
 =?utf-8?B?VXVzRlUzZWxwcURsT3Jzd201K3QrUmVMRlVwckZIU1pHUDc1MHRLaElsUjJQ?=
 =?utf-8?B?TEtIZDJnRlJ5clNJSGRzS0NGakRycEhIakVMOHBIZlFjNXJuVHBaMkJCUk9F?=
 =?utf-8?B?cHh3ZDJiMG5JemFVNVBtUEVVT0NPNUx1VDJzZEp3cE95ZDllczlwa0FqaTRS?=
 =?utf-8?B?b0hOZS8zcnJVckx3UHdxUmZOd0p4NDNUTWFQN04zbEEvL2NwSjdXOVZxQWFM?=
 =?utf-8?B?aENpY21Qc2lmTU9FdzkxckFmUDZJdXVicWdIRTFRcCsrclZUSWtVS2o4ZVZs?=
 =?utf-8?B?dUphVXZVaU9GMUpkWk9VTUMyaXFzSW51ZnBRWGFEOWk5TzMwdnFxbDBkOTVZ?=
 =?utf-8?B?bElEcGhTb002NVVTOFdnaXphNFAxdGtDWEpodG1pcStwemw4aENiaEhjN2Jj?=
 =?utf-8?B?bExndlh0OXN3cjJyc1FwZk5PbkdrWnRhSFMrWnhtR3c0d0JwTVVra0xIZW4w?=
 =?utf-8?B?U2ZYYzNGVUxBcitvWXV2dXViSnJQcFN2eU5tUFlVK3grZ0tmRzhOYkR5aHo2?=
 =?utf-8?B?YmhmU05udlg5YTBUSFY5Qzd0TWc5YjJWVzRyUzl0V3Jld2cxbTNlUmw2eVhx?=
 =?utf-8?B?aDlQMkhUQ3FmeDE4NjJCSU11b1o3c3VQR3hwTWdOQWNVRDJxM2xVRDFnYmdJ?=
 =?utf-8?B?TVdrZFV0eUEyczFOcHgzQlI1UzN6UmE4TTFLd1pwbkhjN1hEUzAxSjAySFBw?=
 =?utf-8?B?L1ZkV2VIdUhDTmQxYjhxK1kwaE9HR3lUb0ZjTUFKVHpqeHpTcUxzeVdIbjZB?=
 =?utf-8?B?ay9pa3gvTmNIZVZxV3I2bDF6c3pnM0d1REZRaW0zM0N6VVptc3RmQ0piV0Zq?=
 =?utf-8?B?N1YvTXJCWXIvSTlQekxFcDJXNEZNU1dhOVpDWCtKL0ZKRnR6SXhOTTBHODVG?=
 =?utf-8?B?QTVYK1pndXFOS25mSUZhUVlBVkpLQnlUZjdRV2VOdFd4ZTBGUFd6MlE1eGxB?=
 =?utf-8?B?V28vMTQ2TXpRdzRJQ0NUUk92UkROZmoyN3k2dzQ1cnZFU25PVGZUTjJSZ2Zy?=
 =?utf-8?B?Z2tDZFd6ZHFtWWlTK0plcEsvK2xxTmR0MTdaV0NQZFdpaG9hU2hldXJsWExm?=
 =?utf-8?B?bFdQSC94bTNTZDR5MlFmNjhrTjFNMGhQSmU2cDlONGw0Z3l0MjZUMEUzZGJB?=
 =?utf-8?B?MUNKc3lENWJQQk1ydjcyckpaR29ITzNvRFNlSGR2RGtHMFgyWFArWTJDQmZl?=
 =?utf-8?B?UHJ6akJJdytZbVZnOXNDc0MzVmFCNEZMR2I0TG40L1VwYm4zS0FMYi9MV1Uw?=
 =?utf-8?B?Q084WjQxY2V5aE9zck1pQWRHZFhrMWMwZDhvSDUwMFBUWVdrZDZGT1lqQmRZ?=
 =?utf-8?B?NFRhYjV3bEpjL2pJNmxCMkJwdU5uTmc0ZDNhVk41aHlKakNuTDhSTk9xdTFP?=
 =?utf-8?B?VmhQd0pvNVpzQ0RldUF6L1pOeFV2b21NWnBpL0IzSjAvaWMyNHYxT1NTaGY4?=
 =?utf-8?B?RUo3ckM5eU9kR0dPSTQ4dHphM2krSHkvMVFYa1dCZ0pxTjZjVmJxQ1NnSlg5?=
 =?utf-8?Q?/a5YyqzMcoui63t0/2Jbf2ZFr?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1958ad08-4617-4d6d-c9f2-08da5ebdc44c
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4257.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jul 2022 19:37:16.3417
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: augGw+ZMcDtoC7SS6XrdlyzRYa0vWd5fclv10n5m/O3OLGiV90WGWLC2Gj0G+AKQs8eU5HhOFRUayJfmtpysMg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4015
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-05_16:2022-06-28,2022-07-05 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 spamscore=0
 phishscore=0 malwarescore=0 mlxscore=0 mlxlogscore=963 bulkscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207050084
X-Proofpoint-ORIG-GUID: lMjBGBpvdCHNSZMsGo4CeewnC2gS2ccy
X-Proofpoint-GUID: lMjBGBpvdCHNSZMsGo4CeewnC2gS2ccy
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org

Hi,

During my low memory testing with 5.19.0-rc4, I ran into this
problem in btrfs where the thread tries to sleep on invalid
context:


Jul  3 04:08:44 nfsvmf24 kernel: BUG: sleeping function called from invalid context at include/linux/sched/mm.h:274
Jul  3 04:08:44 nfsvmf24 kernel: in_atomic(): 1, irqs_disabled(): 0, non_block: 0, pid: 4308, name: nfsd
Jul  3 04:08:44 nfsvmf24 kernel: preempt_count: 1, expected: 0
Jul  3 04:08:44 nfsvmf24 kernel: RCU nest depth: 0, expected: 0
Jul  3 04:08:44 nfsvmf24 kernel: 4 locks held by nfsd/4308:
Jul  3 04:08:44 nfsvmf24 kernel: #0: ffff8881052d4438 (sb_writers#14){.+.+}-{0:0}, at: nfsd4_setattr+0x17f/0x3c0 [nfsd]
Jul  3 04:08:44 nfsvmf24 kernel: #1: ffff888141e5aa50 (&sb->s_type->i_mutex_key#16){+.+.}-{3:3}, at:  nfsd_setattr+0x56a/0xe00 [nfsd]
Jul  3 04:08:44 nfsvmf24 kernel: #2: ffff8881052d4628 (sb_internal#2){.+.+}-{0:0}, at: btrfs_dirty_inode+0xda/0x1d0
Jul  3 04:08:44 nfsvmf24 kernel: #3: ffff888105ed6628 (&root->inode_lock){+.+.}-{2:2}, at: btrfs_get_or_create_delayed_node+0x27a/0x430

Jul  3 04:08:44 nfsvmf24 kernel: Preemption disabled at:
Jul  3 04:08:44 nfsvmf24 kernel: [<0000000000000000>] 0x0
Jul  3 04:08:44 nfsvmf24 kernel: CPU: 0 PID: 4308 Comm: nfsd Kdump: loaded Not tainted 5.19.0-rc4+ #1
Jul  3 04:08:44 nfsvmf24 kernel: Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006
Jul  3 04:08:45 nfsvmf24 kernel: Call Trace:
Jul  3 04:08:45 nfsvmf24 kernel: <TASK>
Jul  3 04:08:45 nfsvmf24 kernel: dump_stack_lvl+0x57/0x7d
Jul  3 04:08:45 nfsvmf24 kernel: __might_resched.cold+0x222/0x26b
Jul  3 04:08:45 nfsvmf24 kernel: kmem_cache_alloc_lru+0x159/0x2c0
Jul  3 04:08:45 nfsvmf24 kernel: __xas_nomem+0x1a5/0x5d0
Jul  3 04:08:45 nfsvmf24 kernel: ? lock_acquire+0x1bb/0x500
Jul  3 04:08:45 nfsvmf24 kernel: __xa_insert+0xff/0x1d0
Jul  3 04:08:45 nfsvmf24 kernel: ? __xa_cmpxchg+0x1f0/0x1f0
Jul  3 04:08:45 nfsvmf24 kernel: ? lockdep_init_map_type+0x2c3/0x7b0
Jul  3 04:08:45 nfsvmf24 kernel: ? rwlock_bug.part.0+0x90/0x90
Jul  3 04:08:45 nfsvmf24 kernel: btrfs_get_or_create_delayed_node+0x295/0x430
Jul  3 04:08:45 nfsvmf24 kernel: btrfs_delayed_update_inode+0x24/0x670
Jul  3 04:08:45 nfsvmf24 kernel: ? btrfs_check_and_init_root_item+0x1f0/0x1f0
Jul  3 04:08:45 nfsvmf24 kernel: ? start_transaction+0x219/0x12d0
Jul  3 04:08:45 nfsvmf24 kernel: btrfs_update_inode+0x1aa/0x430
Jul  3 04:08:45 nfsvmf24 kernel: btrfs_dirty_inode+0xf7/0x1d0
Jul  3 04:08:45 nfsvmf24 kernel: btrfs_setattr+0x928/0x1400
Jul  3 04:08:45 nfsvmf24 kernel: ? mark_held_locks+0x9e/0xe0
Jul  3 04:08:45 nfsvmf24 kernel: ? _raw_spin_unlock+0x29/0x40
Jul  3 04:08:45 nfsvmf24 kernel: ? btrfs_cont_expand+0x9a0/0x9a0
Jul  3 04:08:45 nfsvmf24 kernel: ? fh_update+0x1e0/0x1e0 [nfsd]
Jul  3 04:08:45 nfsvmf24 kernel: ? current_time+0x88/0xd0
Jul  3 04:08:45 nfsvmf24 kernel: ? timestamp_truncate+0x230/0x230
Jul  3 04:08:45 nfsvmf24 kernel: notify_change+0x4b3/0xe40
Jul  3 04:08:45 nfsvmf24 kernel: ? down_write_nested+0xd4/0x130
Jul  3 04:08:45 nfsvmf24 kernel: ? nfsd_setattr+0x984/0xe00 [nfsd]
Jul  3 04:08:45 nfsvmf24 kernel: nfsd_setattr+0x984/0xe00 [nfsd]
Jul  3 04:08:45 nfsvmf24 kernel: ? lock_downgrade+0x680/0x680
Jul  3 04:08:45 nfsvmf24 kernel: ? nfsd_permission+0x310/0x310 [nfsd]
Jul  3 04:08:45 nfsvmf24 kernel: ? __mnt_want_write+0x192/0x270
Jul  3 04:08:45 nfsvmf24 kernel: nfsd4_setattr+0x1df/0x3c0 [nfsd]
Jul  3 04:08:45 nfsvmf24 kernel: ? percpu_counter_add_batch+0x79/0x130
Jul  3 04:08:45 nfsvmf24 kernel: nfsd4_proc_compound+0xce8/0x23e0 [nfsd]
Jul  3 04:08:45 nfsvmf24 kernel: nfsd_dispatch+0x4ed/0xc10 [nfsd]
Jul  3 04:08:45 nfsvmf24 kernel: ? svc_reserve+0xb5/0x130 [sunrpc]
Jul  3 04:08:45 nfsvmf24 kernel: svc_process_common+0xd3f/0x1b00 [sunrpc]
Jul  3 04:08:45 nfsvmf24 kernel: ? svc_generic_rpcbind_set+0x4d0/0x4d0 [sunrpc]
Jul  3 04:08:45 nfsvmf24 kernel: ? nfsd_svc+0xc50/0xc50 [nfsd]
Jul  3 04:08:45 nfsvmf24 kernel: ? svc_sock_secure_port+0x37/0x50 [sunrpc]
Jul  3 04:08:45 nfsvmf24 kernel: ? svc_recv+0x1096/0x2350 [sunrpc]
Jul  3 04:08:45 nfsvmf24 kernel: svc_process+0x361/0x4f0 [sunrpc]
Jul  3 04:08:45 nfsvmf24 kernel: nfsd+0x2d6/0x570 [nfsd]
Jul  3 04:08:45 nfsvmf24 kernel: ? nfsd_shutdown_threads+0x2a0/0x2a0 [nfsd]
Jul  3 04:08:45 nfsvmf24 kernel: kthread+0x2a1/0x340
Jul  3 04:08:45 nfsvmf24 kernel: ? kthread_complete_and_exit+0x20/0x20
Jul  3 04:08:45 nfsvmf24 kernel: ret_from_fork+0x22/0x30
Jul  3 04:08:45 nfsvmf24 kernel: </TASK>
Jul  3 04:08:45 nfsvmf24 kernel:


I think the problem was introduced by commit 253bf57555e
btrfs: turn delayed_nodes_tree into an XArray.

The spin_lock(&root->inode_lock) was held while xa_insert tries
to allocate memory and block.

-Dai