Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <60ee503b9cd5c0d2963070184eb246df22aa716b.camel@redhat.com>
Subject: Re: [PATCH v3 12/32] NFSD: Hook up the filecache stat file
From:   Jeff Layton <jlayton@redhat.com>
To:     Chuck Lever <chuck.lever@oracle.com>, linux-nfs@vger.kernel.org,
        netdev@vger.kernel.org
Cc:     david@fromorbit.com, tgraf@suug.ch
Date:   Fri, 08 Jul 2022 15:16:47 -0400
In-Reply-To: <165730469820.28142.10369457240055089259.stgit@klimt.1015granger.net>
References: <165730437087.28142.6731645688073512500.stgit@klimt.1015granger.net>
         <165730469820.28142.10369457240055089259.stgit@klimt.1015granger.net>
Content-Type: text/plain; charset="ISO-8859-15"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.3 (3.44.3-1.fc36) 
MIME-Version: 1.0
Precedence: bulk

On Fri, 2022-07-08 at 14:24 -0400, Chuck Lever wrote:
> There has always been the capability of exporting filecache metrics
> via /proc, but it was never hooked up. Let's surface these metrics
> to enable better observability of the filecache.
>=20
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
>  fs/nfsd/nfsctl.c |   10 ++++++++++
>  1 file changed, 10 insertions(+)
>=20
> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> index 66c352bf61b1..ecc08cf97a86 100644
> --- a/fs/nfsd/nfsctl.c
> +++ b/fs/nfsd/nfsctl.c
> @@ -25,6 +25,7 @@
>  #include "state.h"
>  #include "netns.h"
>  #include "pnfs.h"
> +#include "filecache.h"
> =20
>  /*
>   *	We have a single directory with several nodes in it.
> @@ -46,6 +47,7 @@ enum {
>  	NFSD_MaxBlkSize,
>  	NFSD_MaxConnections,
>  	NFSD_SupportedEnctypes,
> +	NFSD_Filecache,
>  	/*
>  	 * The below MUST come last.  Otherwise we leave a hole in nfsd_files[]
>  	 * with !CONFIG_NFSD_V4 and simple_fill_super() goes oops
> @@ -229,6 +231,13 @@ static const struct file_operations reply_cache_stat=
s_operations =3D {
>  	.release	=3D single_release,
>  };
> =20
> +static const struct file_operations filecache_ops =3D {
> +	.open		=3D nfsd_file_cache_stats_open,
> +	.read		=3D seq_read,
> +	.llseek		=3D seq_lseek,
> +	.release	=3D single_release,
> +};
> +
>  /*----------------------------------------------------------------------=
------*/
>  /*
>   * payload - write methods
> @@ -1370,6 +1379,7 @@ static int nfsd_fill_super(struct super_block *sb, =
struct fs_context *fc)
>  		[NFSD_Ports] =3D {"portlist", &transaction_ops, S_IWUSR|S_IRUGO},
>  		[NFSD_MaxBlkSize] =3D {"max_block_size", &transaction_ops, S_IWUSR|S_I=
RUGO},
>  		[NFSD_MaxConnections] =3D {"max_connections", &transaction_ops, S_IWUS=
R|S_IRUGO},
> +		[NFSD_Filecache] =3D {"filecache", &filecache_ops, S_IRUGO},
>  #if defined(CONFIG_SUNRPC_GSS) || defined(CONFIG_SUNRPC_GSS_MODULE)
>  		[NFSD_SupportedEnctypes] =3D {"supported_krb5_enctypes", &supported_en=
ctypes_ops, S_IRUGO},
>  #endif /* CONFIG_SUNRPC_GSS or CONFIG_SUNRPC_GSS_MODULE */
>=20
>=20

<facepalm>
Ouch, that's quite an oversight.
</facepalm>

--=20
Jeff Layton <jlayton@redhat.com>