Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Benjamin Coddington" <bcodding@redhat.com>
To:     "Andreas Hasenack" <andreas@canonical.com>,
        "Steve Dickson" <steved@redhat.com>
Cc:     linux-nfs@vger.kernel.org
Subject: Re: Why keep var-lib-nfs-rpc_pipefs.mount around?
Date:   Mon, 11 Jul 2022 09:13:17 -0400
Message-ID: <EE39279C-4E40-48C8-ABC9-707EB1AD6D79@redhat.com>
In-Reply-To: <CANYNYEFSdBua3Ay6jGk2cacossVJ8_CzDgDBnFCjXfk5XSoGEQ@mail.gmail.com>
References: <CANYNYEFSdBua3Ay6jGk2cacossVJ8_CzDgDBnFCjXfk5XSoGEQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; format=flowed
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On 8 Jul 2022, at 12:50, Andreas Hasenack wrote:

> Hi,
>
> I was tracking down a Debian/Ubuntu bug with nfs-utils 2.6.1 where in
> one case, after installing the packages, you would end up with
> rpc_pipefs mounted at the same time in two locations: /run/rpc_pipefs
> and /var/lib/nfs/rpc_pipefs. The /run location is what debian/ubuntu
> default to.
>
> After poking around a bit, I think I found out why that is
> happening[1], but it led me to ask this question: why is
> var-lib-nfs-rpc_pipefs.mount (and its corresponding rpc_pipefs.target
> unit) still shipped, given that nfs-utils now has a generator?

Could just be an oversight, or perhaps a better reason exists.  The
nfs-utils userspace has to handle a lot of different cases and legacy
setups.

Steve D, do you know?

Ben

> Shouldn't the generator be enough for all cases, where rpc_pipefs is
> mounted in the default compile-time location, or changed via a config
> change to nfs.conf? I know currently it checks[2] whether the config
> points at the default location, but that check could just be skipped
> and then the generator would always produce the correct mount and
> target units.
>
>
> 1. =

> https://bugs.launchpad.net/ubuntu/+source/nfs-utils/+bug/1971935/commen=
ts/22
> 2. =

> https://salsa.debian.org/kernel-team/nfs-utils/-/blob/master/systemd/rp=
c-pipefs-generator.c#L138