Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9bc4ed9d-1bde-2957-b9bb-11c89c6809c0@oracle.com>
Date:   Mon, 11 Jul 2022 11:16:18 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.11.0
Subject: Re: [PATCH 1/2] nfs4lib.py: enhance open_file to work with courteous
 server
Content-Language: en-US
To:     "J. Bruce Fields" <bfields@fieldses.org>
Cc:     linux-nfs@vger.kernel.org
References: <1655314495-17735-1-git-send-email-dai.ngo@oracle.com>
 <20220615193453.GB16220@fieldses.org>
 <d0db9a5c-01f3-2380-20ab-36c1e78e395d@oracle.com>
 <20220711180522.GA14184@fieldses.org>
From:   dai.ngo@oracle.com
In-Reply-To: <20220711180522.GA14184@fieldses.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MFJLazRVcDhUYytPQUdWblJQNkVlU0dyR2FQRDZxbEJoWjBHcFRVNWJJMm41?=
 =?utf-8?B?ZHhSY2xKdjRacmh3MEQzMU1ZQXVMYjNCMzRBODkyMGtidGhQdmtlUEU2RXIx?=
 =?utf-8?B?K1BldU9WOU5FWTZEdEorNmJYKzkrZ3NuRHpqeVkvSGhWUDJ3MjVYb2tZSXg5?=
 =?utf-8?B?bEJMaGM3Ykh6aVZwWUxGYnEzV3NlOXpEWVZHTExNVW9uUVdYclV3M2hLQWp0?=
 =?utf-8?B?MWNMZFFsOHJqUlFHMlJhbkVURnY2aklVUEF3U09vcms0cjNua21lcHNaRXNJ?=
 =?utf-8?B?cnZpeGhraU01ZXJZN2RRYVQ0MHVHVHpxa2dxa1R3N09nNUxuYzNPSmFXcG5X?=
 =?utf-8?B?YzV2N1VIb0ZmYzhwY1l0dE5OSXBPMUFqZlRGb3J6ZEI4Ykk5aDkvTE4zajdQ?=
 =?utf-8?B?djloa1hFeEtkRUZjRlF4YVdnTzl6U2pCQ0RqbXBnS21jUlVIZFE1V3BpMVNu?=
 =?utf-8?B?UmFlUDd6cElTR0QyT1lhNll4SnRhajEyQkpiWGhOYUlESHEzd0RvSzRSOTdz?=
 =?utf-8?B?bDN6MERFVXdUUURjbU8ya3pnWEZMUmtMMjlxOGxGcmRoaVVHbjBIRlIwU2J0?=
 =?utf-8?B?TWlWU2JxL29BNlVBYUN6UE9uSC9RQkNxU1BPQ3hLN1hEckpUTXBwY2lQWjBj?=
 =?utf-8?B?SWF5OEhXcU0zYWE3cTZ3NEhVekw1YnYxa05OcVNrUlpieks3NjRXMENpRDFs?=
 =?utf-8?B?eHQ1Vk9meEF5bGxYSjBWVWsyejR2Qld4LzdGWWxPK0phSjJnNmhlWGc5TXJD?=
 =?utf-8?B?ekszc1B5c2hHdmYvNm4zRXcwN21kZERWNWxKMUsrUS90RzgrdDVMWHQzL2R0?=
 =?utf-8?B?TDlsRFcvemdDZDM0b3E5RWRDdWFoMlVvQUJ2ZW12OGpaQWFibjhHRytHcy8v?=
 =?utf-8?B?TzJWcVNpdmxtczVTUzhPdUgySEM3emNBY3pUVnMwem1VYVRZSXdBZWVVdUd3?=
 =?utf-8?B?S3paazRnRUUyMW5RaEIyYlBRVVdYSk9XY0F4ZGV0MHJQY3JSMVF2UW5TaDhT?=
 =?utf-8?B?UlFWb3MxYXM0VDdQSWlNei95ZUIyRUhBRFFnL1AzOEdud0VVMnE3dzVZb1kr?=
 =?utf-8?B?Wi9OK1FIY2Yrbkk3ckdTVDJYd0FiV3R1bUpDd1ZvWkk5b1YzYkk5VjgyN0t3?=
 =?utf-8?B?dHRIMEduTnJCQVUzSDVrSVBKVW4wYXUwS1dJMmc5aEsrZ09EdlorVTA0OTlm?=
 =?utf-8?B?OFRXbjAveGx6R0ppdVpLNDhVN2FvcUlINWZTcFRkZURqbGhNbHZWbkMzL25a?=
 =?utf-8?B?VkFkcE9Kc1RjcGphd0xDby9IcUdyN1ZhTzR6N202Q3FiZ1BVTEJJNlV0WGkz?=
 =?utf-8?B?c0FUeFRUQm5OME80YldaSUthYXVqL2VvZk1rTzU5WENpQmhBb1pnVkdpVGVT?=
 =?utf-8?B?VytFbjJkbXVmYllzMVNlYkJrT2ZsL3FZcXptMW1yTUI2RjFCN1FvY1FvVnc5?=
 =?utf-8?B?THl3dHAzK2ZMTEtVZk5BVkN6NlhlREQ5Nk1CY2xXQUYvemZjTjFJdnNTbWJo?=
 =?utf-8?B?QllYTURvd3RWOTFKT1pGa3QxU1dFanRYZEg4bm9YSXludnNTcWVwQnp0VUFF?=
 =?utf-8?B?Y2xEcjZGMENxQmlpL05jQ2RGVmJxTjdUSko1Z1dIbjFweUZwZHBGWFkyM3I2?=
 =?utf-8?B?Z2VENjRZWnhLakduRG5sVmhpMVRocVVtSUV3eDNwb3pab3FtOWVHTmVMY0h1?=
 =?utf-8?B?Y2hNSG0vSHZDU3k5VzZxRHQ0Q0dnUjJNNkt2d3laaGVscEJ0bkJXSnpEUnc0?=
 =?utf-8?B?S21veDZ4eVBhdWx2NjliNEo4L3R0Z1RMQmkxY1JRVEFiTnJXOGRNOGluWkFD?=
 =?utf-8?B?YUs4SVdpVG1iQzVTYUdkK1R3RHlwbGFDSjhLemtpUlVPaEEwd0VRNFNiOGEr?=
 =?utf-8?B?MEt1SVprMGlReHhBb1NFdGpJU2owWmh5VmF2U3cvOHp5bE1wblQ0ci9ldG1H?=
 =?utf-8?B?VEx4WE9WQXF1K01UamdlNlA5bkQ4MjhGaGk4ZEozNllOWHd5dGN5bmpoNERx?=
 =?utf-8?B?SzR2NDg3ZUVOL0ZscTJ5a256bGd2V2kyTHk3Y1BCSXZsRUZaQUtZVVJtQnFZ?=
 =?utf-8?B?bjBDNjBXVEpsRU5HVnhDL2FBSVdDbFJtQXBocTJOcmZsT2F2YWlUVjRwamY1?=
 =?utf-8?Q?7OZaRxZL+5U4d4oJv3Qk5QbO5?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 43d0f078-7795-4d1e-5807-08da636975f4
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4257.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Jul 2022 18:16:22.9884
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: i2cxYFtr653EdUqN80Sh+pjMRJR0cvjhdKzsMtKTqGBVCrTsd63tahOxqqst0Pfutw5242FUmEroD95OJnM7NA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR10MB4394
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-11_23:2022-07-08,2022-07-11 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 phishscore=0
 suspectscore=0 mlxlogscore=999 mlxscore=0 spamscore=0 malwarescore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2207110078
X-Proofpoint-ORIG-GUID: ydnAbBG1d7M7W6i9CUKATZ2MPF2MHY0p
X-Proofpoint-GUID: ydnAbBG1d7M7W6i9CUKATZ2MPF2MHY0p
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


On 7/11/22 11:05 AM, J. Bruce Fields wrote:
> Applying, thanks, sorry for the delay.--b.

thank you Bruce!

-Dai

>
> On Wed, Jun 15, 2022 at 12:48:17PM -0700, dai.ngo@oracle.com wrote:
>> On 6/15/22 12:34 PM, J. Bruce Fields wrote:
>>> THere are tests that want to explicitly test for DELAY returns.  (Grep
>>> for ERR_DELAY.  Look at the delegation tests especially.)  Does this
>>> work for them?
>> Those tests expect NFS4_OK but also handle NFS4ERR_DELAY themselves
>> if the OPEN causes recall. With this patch, the NFS4ERR_DELAY is handled
>> internally by open_file so the ERR_DELAY never get to those tests.
>> All tests passed with this patch.
>>
>> -Dai
>>
>>>   I assumed we'd want an optional parameter that allowed
>>> to caller to circument the DELAY handling.
>>>
>>> --b.
>>>
>>> On Wed, Jun 15, 2022 at 10:34:54AM -0700, Dai Ngo wrote:
>>>> Enhance open_file to handle NFS4ERR_DELAY returned by the server
>>>> in case of share/access/delegation conflict.
>>>>
>>>> Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
>>>> ---
>>>>   nfs4.0/nfs4lib.py | 7 ++++++-
>>>>   1 file changed, 6 insertions(+), 1 deletion(-)
>>>>
>>>> diff --git a/nfs4.0/nfs4lib.py b/nfs4.0/nfs4lib.py
>>>> index 934def3b7333..e0299e8d6676 100644
>>>> --- a/nfs4.0/nfs4lib.py
>>>> +++ b/nfs4.0/nfs4lib.py
>>>> @@ -677,7 +677,12 @@ class NFS4Client(rpc.RPCClient):
>>>>                             claim_type=claim_type, deleg_type=deleg_type,
>>>>                             deleg_cur_info=deleg_cur_info)]
>>>>           ops += [op4.getfh()]
>>>> -        res = self.compound(ops)
>>>> +        while 1:
>>>> +            res = self.compound(ops)
>>>> +            if res.status == NFS4ERR_DELAY:
>>>> +                time.sleep(2)
>>>> +            else:
>>>> +                break
>>>>           self.advance_seqid(owner, res)
>>>>           if set_recall and (res.status != NFS4_OK or \
>>>>              res.resarray[-2].switch.switch.delegation == OPEN_DELEGATE_NONE):
>>>> -- 
>>>> 2.27.0