Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Jeff Layton <jlayton@kernel.org>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
        Trond Myklebust <trond.myklebust@hammerspace.com>,
        "anna@kernel.org" <anna@kernel.org>
Subject: Re: [PATCH 0/2] lockd: fix hang on shutdown when there are active
 locks
Thread-Topic: [PATCH 0/2] lockd: fix hang on shutdown when there are active
 locks
Thread-Index: AQHYlVRHs4Srxdi+TEupsHx0CAQu7q15k5IA
Date:   Mon, 11 Jul 2022 19:47:57 +0000
Message-ID: <EE221E7E-8FEB-459A-86BC-B21AB4D662C8@oracle.com>
References: <20220711183014.15161-1-jlayton@kernel.org>
In-Reply-To: <20220711183014.15161-1-jlayton@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?kcirRV4GzlHkKuAD1DHpNgIFSgbx+aLKRcpQT7kvUuRsW8j0BT0/HfmXubnn?=
 =?us-ascii?Q?XrZbkgps+jjn8+2NZ9fQt7J34t6yMIdneIbW3FaLtCpqkTLSwPTjpmx+0SJb?=
 =?us-ascii?Q?ggeKrn/pSu7hu1VTTyPh7fGeEOkuzjnjJRDQ7A0eKV/Xa0IKqae8Pi/BjzM3?=
 =?us-ascii?Q?pH9B2bD4OHDQi4cvxaHBVHrLsvpEJV1ucV4XzeoQriPb6RGVaqm0ea8NZ2e5?=
 =?us-ascii?Q?9+DzOCo8QPVeNEwlFKrmGlJe341D78IRQ1pOqGga/EqMgVVgWmITecQChQQy?=
 =?us-ascii?Q?1uSbrOjoEyAFMdSCSIStluTwQfOOgPd6k1rLq1sjCdyn4UMIwfOIibp/0gV9?=
 =?us-ascii?Q?BC0REjB2sRNn/wv/Ry+pUWsNRmvS/9hoXNUmAuO4qnNAiCFKrP0AJeFvgee+?=
 =?us-ascii?Q?6nIaTYyTr0L1lcH7XbG2Nrc6opl71JJk/OO6gGtvLItYCci9sFejQBV/84Fd?=
 =?us-ascii?Q?727XF8uSon9lF1jz6yJDrnL1L5VvMqjXFkr5q62j4uAj6MuaPeytCwOr08q1?=
 =?us-ascii?Q?Yi+sNhR86ClagneosvX+FBtH1q//lExBARhmH+fnQavMtS2M3293UaCTtmI9?=
 =?us-ascii?Q?3DsgSWf0TXxcPLPV9HeDWpcql5paIoy3GZcU0a9wB29DSYa9+8i8emjQ13V0?=
 =?us-ascii?Q?0EEWpGvBPJDMZRUhqLKKtk3IWpumTC8EuNOxMYeXUJtwfBSf/RkUdonasXrz?=
 =?us-ascii?Q?y053eEuXtsYV5u9UQnrhsKbXGn1c0OqrgqSr12osxAiGP0WxW8pzRD26V8Hz?=
 =?us-ascii?Q?3edRhvlZCAZZnj9BpOoEfUZ7Ujga1ja/ed08xP/MiU8GY4Vfw/efUhMNFaJH?=
 =?us-ascii?Q?0ldhSUpV1nZlCnXPurZ7YLYQCKGXNDSnWwv70iRXnSFLrw0XXTilDd5wS1u2?=
 =?us-ascii?Q?IfXaGNON+wpOMMPEX+/7m/ks4ZV7O3RY2VErNr/BJPpnEIOqcDem26MgN4VG?=
 =?us-ascii?Q?7Q1UxieLUFxd53XaOCuJ4fDfnX/LN9zanr7NjbEqAFgmr5k7c5mRBwAnqpIh?=
 =?us-ascii?Q?1lfqsHITZEWesll81a2C4eD2xC12VavoBJL26I+TpZDuJpzhB+gtLfuPs3ia?=
 =?us-ascii?Q?eTbddbuF0bw9Nnf5ZUMEvfoTp2b7yePIqEkbOuJRDHYHNurIvTZQXNtvV1Ow?=
 =?us-ascii?Q?T4TVnceG8JxCQuXQII5qVv3O2KG7wGN6BMv7YrAYWE0arqP7hTlJUpHmng0A?=
 =?us-ascii?Q?l8HvPpYHDi2vRVx2QAGq39FT2Jj3vryBxyDbNYbIaRNF0UoZuxbHFwvrSjvu?=
 =?us-ascii?Q?ZU3IqYW805oE77hQmbGstoC5vHb6iqzcZNg/2IxyCiOAPLahrTGUROV6gdiX?=
 =?us-ascii?Q?fD2/7gXcw9h2DzbjvTQb0CgxxueKR6yDa3keFZYAebarY9b6vctSpzHyHClx?=
 =?us-ascii?Q?95jGc9wrRgFUtN1wLbK5Md1scR0DxvGfg23c1psCFAm/OaKVYBHt1Pi7VMs8?=
 =?us-ascii?Q?AwD95xFS7beM4LOiPxiZa75JzLriSIg3hPQi0WyVJQPYtOwoX1l8n1gbsl53?=
 =?us-ascii?Q?YbQkR6qFV/OMjky5CWR8Oz1Fit1N5b6zWU36AeBeJC6ZxlxmHcJ6TKPC9OlY?=
 =?us-ascii?Q?5ZBhXmHEZX19NFth66V2HCFQsl7WD9XjHeBAs4sxgQ4je355YERb4vXb2SSj?=
 =?us-ascii?Q?Lg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <C1096FE89ED66440BBFE70AADFD7A4EA@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 68b9ce0b-7e7c-4316-f97b-08da63764107
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jul 2022 19:47:57.4054
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VLK0oRjlqR2lKNTLHJIrO8jvdIOpF+oNSEyra0JouafqupP4BkdB79JDwcmpWS+17lM+2MozeKnaFsvu/0r1nw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1001MB2379
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-11_24:2022-07-08,2022-07-11 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 bulkscore=0 mlxlogscore=994 mlxscore=0
 suspectscore=0 phishscore=0 spamscore=0 malwarescore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207110082
X-Proofpoint-GUID: qx3Pa-WYyEZJG-9vDrHpjc69fY8kkEdv
X-Proofpoint-ORIG-GUID: qx3Pa-WYyEZJG-9vDrHpjc69fY8kkEdv
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Jul 11, 2022, at 2:30 PM, Jeff Layton <jlayton@kernel.org> wrote:
>=20
> We had a report that shutting down nfsd would hang when there were
> active NFSv3 locks. The first patch fixes that.  While testing that I
> hit a crash in nlm_close_files. The second patch fixes that one.
>=20
> Jeff Layton (2):
>  lockd: set fl_owner when unlocking files
>  lockd: fix nlm_close_files
>=20
> fs/lockd/svcsubs.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)

Grabbed both for the next 5.18-rc PR.

--
Chuck Lever