Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <d5006f96-0f90-9b50-76ef-b0f505dfb8ff@redhat.com>
Date:   Tue, 12 Jul 2022 15:39:03 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [PATCH rpcbind] autotools/systemd: call rpcbind with -w only on
 enabled warm starts
Content-Language: en-US
To:     Bastian Krause <bst@pengutronix.de>, linux-nfs@vger.kernel.org
References: <20210611122803.24747-1-bst@pengutronix.de>
From:   Steve Dickson <steved@redhat.com>
In-Reply-To: <20210611122803.24747-1-bst@pengutronix.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/11/21 7:28 AM, Bastian Krause wrote:
> If rpcbind is configured with --disable-warmstarts it responds on -w
> with its usage string. This is not helpful in a systemd service, so pass
> -w conditionally.
> 
> Signed-off-by: Bastian Krause <bst@pengutronix.de>
This did fall of my radar... In the future feel free
to ping me privately...

Committed! (tag  rpcbind-1_2_7-rc2)

steved.
> ---
>   configure.ac               | 6 ++++++
>   systemd/rpcbind.service.in | 2 +-
>   2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index c0ef896..c2069a2 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -20,6 +20,12 @@ AM_CONDITIONAL(LIBSETDEBUG, test x$lib_setdebug = xyes)
>   AC_ARG_ENABLE([warmstarts],
>     AS_HELP_STRING([--enable-warmstarts], [Enables Warm Starts @<:@default=no@:>@]))
>   AM_CONDITIONAL(WARMSTART, test x$enable_warmstarts = xyes)
> +AS_IF([test x$enable_warmstarts = xyes], [
> +	warmstarts_opt=-w
> +], [
> +	warmstarts_opt=
> +])
> +AC_SUBST([warmstarts_opt], [$warmstarts_opt])
>   
>   AC_ARG_ENABLE([rmtcalls],
>     AS_HELP_STRING([--enable-rmtcalls], [Enables Remote Calls @<:@default=no@:>@]))
> diff --git a/systemd/rpcbind.service.in b/systemd/rpcbind.service.in
> index 7b1c74b..c892ca8 100644
> --- a/systemd/rpcbind.service.in
> +++ b/systemd/rpcbind.service.in
> @@ -12,7 +12,7 @@ Wants=rpcbind.target
>   [Service]
>   Type=notify
>   # distro can provide a drop-in adding EnvironmentFile=-/??? if needed.
> -ExecStart=@_sbindir@/rpcbind $RPCBIND_OPTIONS -w -f
> +ExecStart=@_sbindir@/rpcbind $RPCBIND_OPTIONS @warmstarts_opt@ -f
>   
>   [Install]
>   WantedBy=multi-user.target