Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <30ec26a2-cf4d-151d-9045-bcc382c633e5@oracle.com>
Date:   Thu, 14 Jul 2022 10:56:53 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.11.0
Subject: Re: [PATCH v2 0/2] limit the number of v4 clients to 1024 per 1GB of
 system memory
Content-Language: en-US
To:     Chuck Lever III <chuck.lever@oracle.com>
Cc:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>
References: <1657815462-14069-1-git-send-email-dai.ngo@oracle.com>
 <86EDD9A1-CB3D-4E3F-B4EB-0FEB3EED37F2@oracle.com>
From:   dai.ngo@oracle.com
In-Reply-To: <86EDD9A1-CB3D-4E3F-B4EB-0FEB3EED37F2@oracle.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QWIvQWRMVVgrSW55cFlTOVFaWUZjUlpST2kzNlRSWGplN3dSMjRnR0R0V1F3?=
 =?utf-8?B?djBhUFlqVk5LcENlMXYxQmtNWWpZOFBITkVIZ2lSWi9PenpxSGMwcVhCZlBm?=
 =?utf-8?B?Qjhxa29waG96QUFTcTVUS1oweTlpYVY5MkhmWmIreWxNanRFZ1FpcUQ0YVd6?=
 =?utf-8?B?TGU2bnhZSldKQjhJaHkzRkF1MlRrQ3lzaTZuNlZlV01IQ0JVNG5GWURNLzNS?=
 =?utf-8?B?YnQ5RTh1a0lnd1g2QUUrRzhGaU5hdHRLa1B1SzJhY2pLZWlZVFp0Rm1HT3ZE?=
 =?utf-8?B?LzhNaEloTUErL2h1MENPb2I0QkIwNGZ0VmkyNWwvS0VYU3FKWisvN0NRM3pJ?=
 =?utf-8?B?SnJOaXk1d3kxdEJGdVhaQndBQnZjN0V0SFVZVG1DWEJ1cG9FcFpkM0xaRFVy?=
 =?utf-8?B?MDhQSGV4eEp5RGJncUxrc013TlJIcm9CdnZqUHpJajBhbXBaTTR3TGRhZlZU?=
 =?utf-8?B?cXdUbzhOZEI1aElpN3dDY1JyKzVJSS9uWlRNMm1HeFZNUW9qMkpzVkFJbmp2?=
 =?utf-8?B?MDN6YzM2aG05UHhRaThlMXdPN2xwdFZreUtEeEpFcFJtT0wyMVlJRHlQN2lS?=
 =?utf-8?B?NW9iWlQ3Z1hCa1JiNFpBTEFnN3liM1pPeFNhL05qYkhuWDN0SktBVGFRekVS?=
 =?utf-8?B?WllJQkowaVh2eTl6dkNDYllWaGs3c3lYZ2lzWit6QnF4emoveFJzcDZTVlhn?=
 =?utf-8?B?cFZuTjF1MmhJd3RuR0tWMmxsSXdKQXFDRlIzOGprNXRvYURuMVhYTUsxeHd3?=
 =?utf-8?B?TUJnZi9MckV5eTlVRjgzMzJIUVpjcUpDQkJ2SWd1UU5XRXlUbGd3WUdaNmlZ?=
 =?utf-8?B?NE8xUWJXWlE2d05vN0laNFptU2tNWlpjMFVGODA4S3RaeXdwOExCV2cwWThw?=
 =?utf-8?B?a3NWaFl1Q01IS1l4VjREai9HdmE4S04xbjRUbVlYMlY1T3Mwb2R0OHYwQVIr?=
 =?utf-8?B?UmxmYmhjRmJNS2VNWm14MUN4eHovWG5vQk9xTmg5YUVWVXpSajRkcWFtVDUy?=
 =?utf-8?B?c01SL1hzUkRmL0w1VDFvcFFnOTdnME44V2QramxTZVZTR3o1Vm1kd1A2UjFv?=
 =?utf-8?B?bHg1VU9YRWxWNFFqa1ZXeGJyeU1DR3Jobmt1WTYyUE05Y1RGR2pXb2FqWElZ?=
 =?utf-8?B?VGlkanhoWTFLTU9hb2g0eG5vZFA4b09MNnd0a0pDdGNFQ0RSUVR0eTJacmhB?=
 =?utf-8?B?bWZtT0tqZGhvSkx6TTlsQ0RJS2VPTnBoMkFDZHRubXh6eGtyRFFHZHRNd0k5?=
 =?utf-8?B?NjlNOE5RcVBiYWJPYVNtVCs5bHl0M1lvM1RkY3o0dnFnRXhCa1V4Tjhnb0xj?=
 =?utf-8?B?ckpLamQvZnJXc1YxOUo1eVBreEFTU0s5emVGWlcyQUdQMWFqZENYV0ZYd0dO?=
 =?utf-8?B?aDRSVTNSeFJRZXNOQjVic1kwZ0kwVEpjYnExT1pzZFpWUVUyMnJobitSNWVw?=
 =?utf-8?B?UmhBaVAzUENrY28xRit4eEVMcmNJUUM2OVA1RU9BVFpJUk1NRURQQ2Y5ZDYz?=
 =?utf-8?B?dXo4d0J0QkhWY3grZjVRdzNrS3IxM1hONkUzWDVObjI3UElqWWpQS01SaTRj?=
 =?utf-8?B?R3BkUmhud1dlcTJYYjVsa3pXbTZUalR0VmhKaHNCWHBDTUg2M1B2MVZ1dmd1?=
 =?utf-8?B?YmRSU21OcFdQSXY2c1RLVVN1ZEw3cUlxMUJIdGFFR3MyVUtMUHAxN0hyOGpW?=
 =?utf-8?B?OGlUTVkzTnBGMUV0bGNUUmhHT1NvdDNDWVg4aEJJZ3AreXIvUnRac2l2NzNP?=
 =?utf-8?B?QWQ2MlVCdUFJOVUzMDJMNTVEemlud044ZGtsa1ZUdDFFcFk5QmRmbVpLMjhL?=
 =?utf-8?B?SUs4Qi9xTWdqdDIrMm8zOGV3WXNoTHRWNXhzUm1DNVRWbG5XTnBjcUluWm1V?=
 =?utf-8?B?c0wrcWZiTCt1SDJnRjFKME9tbFlwN0k0TnJuL3RqMWVKaEpxWDNGS3hvRG5y?=
 =?utf-8?B?VEtPZWpuRFdnWWVmZURWeklMTitQczZXblFUUEZIdzdEc0FOZzVoKy90Wndp?=
 =?utf-8?B?M25rS1BaV3EreFdPR2dDQmFkMlZkNGtaTllaVkdHMTZVZHB1WEtuTUFHUmZP?=
 =?utf-8?B?YU9YcVlaUGxSZUlscU9hSXpyUktWLzhMNUFuQStMeFRZd0VrMVFwTTRwUTlX?=
 =?utf-8?Q?s6xd/ieO7ZGyKXCLd7WUiMR9v?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ea6bae3e-f3b4-4be6-1e22-08da65c23db9
X-MS-Exchange-CrossTenant-AuthSource: BY5PR10MB4257.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 17:56:56.1667
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: t0cAoEr9CBHYpwD4v3gLI2Q3AB3DFQUrcflHG5b4wObKPz+41C+j/zXHo6FXuHHHnC3X5dYRXvgQrEFB4DxINQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR10MB4644
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.883
 definitions=2022-07-14_15:2022-07-14,2022-07-14 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 phishscore=0
 mlxlogscore=946 suspectscore=0 adultscore=0 mlxscore=0 spamscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2207140078
X-Proofpoint-GUID: qhjARcaepoQasUX9TVeQf7Cxhe-A8J-D
X-Proofpoint-ORIG-GUID: qhjARcaepoQasUX9TVeQf7Cxhe-A8J-D
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


On 7/14/22 10:18 AM, Chuck Lever III wrote:
>
>> On Jul 14, 2022, at 12:17 PM, Dai Ngo <dai.ngo@oracle.com> wrote:
>>
>> This patch series enforces a limit on the number of v4 clients allowed
>> in the system. With Courteous server support there are potentially a
>> lots courtesy clients exist in the system that use up memory resource
>> preventing them to be used by other components in the system. Also
>> without a limit on the number of clients, the number of clients can
>> grow to a very large number even for system with small memory configuration
>> eventually render the system into an unusable state.
>>
>> v2:
>> . move all defines to nfsd.h
>> . replace unsigned int nfs4_max_client to int
>> . kick start laundromat in alloc_client when max client reached.
>> . restyle compute of maxreap in nfs4_get_client_reaplist to oneline.
>> . redo enforce of maxreap in nfs4_get_client_reaplist for readability
>> . use bit-wise interger to compute usable memory in nfsd_init_net.
>> . replace NFS4_MAX_CLIENTS_PER_4GB to NFS4_CLIENTS_PER_GB.
>> . use all memory, including high mem, to compute max client.
> Hello Dai, I applied these two to NFSD's for-next branch for early
> adopters and other testing and review.

Thank you Chuck,

-Dai

>
>
>> ---
>>
>> Dai Ngo (2):
>>       NFSD: keep track of the number of v4 clients in the system
>>       NFSD: limit the number of v4 clients to 1024 per 1GB of system memory
>>
>> fs/nfsd/netns.h     |  3 +++
>> fs/nfsd/nfs4state.c | 28 ++++++++++++++++++++--------
>> fs/nfsd/nfsctl.c    |  8 ++++++++
>> fs/nfsd/nfsd.h      |  2 ++
>> 4 files changed, 33 insertions(+), 8 deletions(-)
>> --
>> Dai Ngo
>>
> --
> Chuck Lever
>
>
>