Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Dai Ngo <dai.ngo@oracle.com>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH v3 0/3] NFSD: limit the number of v4 clients to 1024 per
 1GB of system memory
Thread-Topic: [PATCH v3 0/3] NFSD: limit the number of v4 clients to 1024 per
 1GB of system memory
Thread-Index: AQHYmKZJ4kBZaTAXN0G0yzg6V25QJa2BLsUA
Date:   Sat, 16 Jul 2022 16:21:01 +0000
Message-ID: <847C5989-9251-4CDE-81BE-5C6A16750081@oracle.com>
References: <1657929293-30442-1-git-send-email-dai.ngo@oracle.com>
In-Reply-To: <1657929293-30442-1-git-send-email-dai.ngo@oracle.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AeIoGhrcayHZaC7mIP1HbwYFU8/Kgj87Ubjan475mOitqrndxZwAb0pZEQ7x?=
 =?us-ascii?Q?wxZNSf9g6f1nxAU6fpPICsojeu7gVa5fr1bvqBaJYoI6xz6qtdkF0veXG8j/?=
 =?us-ascii?Q?S0s67A7HbkS+8PscLxKWtYwHxiHan/P2lgjIOA9DM0+MFBAMjmTdmhD+tp+y?=
 =?us-ascii?Q?kp/XELd3AAt9eEoewqbLiDGwES0VZRKgc2V7SZzkdAV5dr8GckuwScM26BuD?=
 =?us-ascii?Q?FcUckCslyLQv15Mn5K0HkHeJb+Z9qukrl23/kbJV4f8dhQ7N5UjTw9goSUzu?=
 =?us-ascii?Q?fnJHpfWurURF4+qOOIhpCwrhq4msPXBOCfIG5zxR0c/QkgwvdG41YKk19+dE?=
 =?us-ascii?Q?N9lAggUihc5nP4xLqwfRP0rXAx0V5UyoN+34TcKH6IT8PVy5vuweW9bF9VwW?=
 =?us-ascii?Q?CHcC6iE4jv7mStG0L3EQAfW+Qc5y4rEC5VcsPpOGwpn4BJ6KNXT6Czm8+ZyQ?=
 =?us-ascii?Q?SSTQdE7ruiIzz8JjnwD/FhSxvKhp7Eyb+EJyxHWmAw/SZrSaTdBHGMsJ+RcP?=
 =?us-ascii?Q?Heix4au3zsql6RC8sL4KLaB8FT5+8jaRbeYhpnXiyQigE6Cs7YjBDMFxE0s5?=
 =?us-ascii?Q?HIsQ9KbHjZKcYDGhASTE7YKVli7ojMgpQXsU7omIZRHoYbn5VAAsccW+s9/F?=
 =?us-ascii?Q?uKhAtz4RO7+ChI48zbqRlBw0e6KHmXdguzg8ypVsYmkzzHXvUdqn7n6aC/zk?=
 =?us-ascii?Q?GoNINPIkhOjjgkf0F8bs1rfZDyqCVdnrpqOGWZAqxniU1J6b62QA2o3KHnLw?=
 =?us-ascii?Q?EzHmyp55lSlQuWS26tGW8b12xWjLAFOkCiaoXXpTOq/G6bbWXtQJoZhg0Bab?=
 =?us-ascii?Q?LAS6C6v8ouEwi2gIc5RBBz1hE8A8XRirg+Wk/mbowMUOmzRXTlnyd8OCtv3N?=
 =?us-ascii?Q?E7+4Uk/YQucAByfi7R28J3w622pqt4Tu1QgRleu+TUltYyDuteDb+LGZPUHP?=
 =?us-ascii?Q?WBd9X58GiXgrgC6kYiDwbL5wAdEs4o0atRCH+tdZ7KDH0NyCZc55FcBAkI94?=
 =?us-ascii?Q?2ZBHe9okVki7etMl6jWHtT3yHSc4GuQh5pt0FJKzRN7U5ckhfDXyKskeEbJs?=
 =?us-ascii?Q?dSYLIjUri/ebbrvLA/KvVZcuCFWy6+a6YAtOvQ9+tCD5KXoLL9cRCrTDswr1?=
 =?us-ascii?Q?ZgEMs3kP6u0Pcn5vdVdfH9Dt7UxOrA4wn1d9iFyzMVkqsV4oMzDqn/q5HBaG?=
 =?us-ascii?Q?1em0eRk/NFcU+x3nFe1hXU3cRKqhTRpWoHOmu8bOZzVAOcEKWGiQyoS9+fDh?=
 =?us-ascii?Q?V1RVZFvsVsIIPmoFHi6Kr7I9vC8hq2W8MQPLe1kOeTyrwymp1AYNXk5kXgcl?=
 =?us-ascii?Q?rq0N7iRUC3QWbBtY6LXR7z9L8Pg3NYyzUKPvHVKKgsqfeUR0kkpdQAjjgNEa?=
 =?us-ascii?Q?h+G83JYohxlcITrKidp4sh+XqSLYnpjKKC5/oSpPNvQL8VBovNo2QThhv6Y6?=
 =?us-ascii?Q?RxdZehWv4jShJ4PLwlCQPakqjPfZuIwDjRv5p7fVRRWUL3LvIU7LRalgiRRE?=
 =?us-ascii?Q?LZe/JP4FtxKhBgu5T7qrXBBIEST3D8sXdCoTJjiYifFyLprKyYDdQhyHtwHJ?=
 =?us-ascii?Q?yFJAEK1L+w5r7okWmKPBx5TVEF8TmoedJKY+4a5aNWPkXnqOMENlPu5k14y8?=
 =?us-ascii?Q?Gg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <DAFC1A7E78617C42866501A3A2A1A7F6@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0c434cd1-cdc0-4b7c-1389-08da67472c95
X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jul 2022 16:21:01.4340
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: PgsyrYF2jIVf7hnBs/26pnLnJQ04mBZHjF8DGR5R1PWi7mFsBTfphZO58DWP1E2DKEvwr7irHZYXe7e57dniQg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR10MB1418
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-16_13,2022-07-15_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 spamscore=0
 mlxlogscore=999 mlxscore=0 adultscore=0 suspectscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207160070
X-Proofpoint-GUID: _a9K-VHZ6pLFVghbNgXcCcoQO7Ra8ntX
X-Proofpoint-ORIG-GUID: _a9K-VHZ6pLFVghbNgXcCcoQO7Ra8ntX
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Jul 15, 2022, at 7:54 PM, Dai Ngo <dai.ngo@oracle.com> wrote:
>=20
> This patch series enforces a limit on the number of v4 clients allowed
> in the system. With Courteous server support there are potentially a
> lots courtesy clients exist in the system that use up memory resource
> preventing them to be used by other components in the system. Also
> without a limit on the number of clients, the number of clients can
> grow to a very large number even for system with small memory configurati=
on
> eventually render the system into an unusable state.
>=20
> v2:
> . move all defines to nfsd.h
> . replace unsigned int nfs4_max_client to int
> . kick start laundromat in alloc_client when max client reached.
> . restyle compute of maxreap in nfs4_get_client_reaplist to oneline.
> . redo enforce of maxreap in nfs4_get_client_reaplist for readability
> . use bit-wise interger to compute usable memory in nfsd_init_net.
> . replace NFS4_MAX_CLIENTS_PER_4GB to NFS4_CLIENTS_PER_GB.
> . use all memory, including high mem, to compute max client.
>=20
> v3:
> . refactoring v4 initialization specific code to a helper in nfs4state.c
> . fix kernel test robot issue with NFS4_CLIENTS_PER_GB when
>  CONFIG_NFSD_V4 is not defined by moving v4 specific code
>  to helper nfsd4_init_leases_net in nfs4state.c=20

Hey Dai-

I pulled these and applied them with a couple of cosmetic changes.
I'm going to run some tests over the weekend before pushing them
to for-next.


> ---
>=20
> Dai Ngo (2):
>      NFSD: refactoring v4 specific code to a helper in nfs4state.c
>      NFSD: keep track of the number of v4 clients in the system
>      NFSD: limit the number of v4 clients to 1024 per 1GB of system memor=
y
>=20
> fs/nfsd/netns.h     |  3 +++
> fs/nfsd/nfs4state.c | 49 ++++++++++++++++++++++++++++++++++++++++--------
> fs/nfsd/nfsctl.c    |  9 +--------
> fs/nfsd/nfsd.h      |  6 ++++++
> 4 files changed, 51 insertions(+), 16 deletions(-)
>=20
> --
> Dai Ngo
>=20

--
Chuck Lever