Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <165815281251.8395.9611588593452344848.stgit@klimt.1015granger.net>
 <YtYqNZCazm64S/Di@infradead.org> <4936C3D6-AE4B-4F7F-89D1-17CBF38A5CD5@oracle.com>
In-Reply-To: <4936C3D6-AE4B-4F7F-89D1-17CBF38A5CD5@oracle.com>
From:   Anna Schumaker <schumaker.anna@gmail.com>
Date:   Tue, 19 Jul 2022 10:26:41 -0400
Message-ID: <CAFX2Jfm5pcAkf7k+DT4RFY1EDhMCDKFQT8B5XTdMwqZ2Z++_3w@mail.gmail.com>
Subject: Re: [PATCH] NFSD: Remove CONFIG_SUNRPC_GSS_MODULE
To:     Chuck Lever III <chuck.lever@oracle.com>
Cc:     Christoph Hellwig <hch@infradead.org>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jul 19, 2022 at 10:10 AM Chuck Lever III <chuck.lever@oracle.com> wrote:
>
>
>
> > On Jul 18, 2022, at 11:51 PM, Christoph Hellwig <hch@infradead.org> wrote:
> >
> > On Mon, Jul 18, 2022 at 10:00:12AM -0400, Chuck Lever wrote:
> >> Clean up: I cannot find CONFIG_SUNRPC_GSS_MODULE anywhere.
> >
> > CONFIG_SUNRPC_GSS_MODULE is set if SUNRPC_GSS is built as a module.
> > CONFIG_*_MODULE is Kconfig-generated magic.
>
> I can drop this patch, but I still have questions (and I know you are
> just the messenger, you might not know the answers).
>
> Where is this convention documented?
>
> When would CONFIG_SUNRPC_GSS_MODULE be defined but CONFIG_SUNRPC_GSS isn't?

There is a macro "IS_ENABLED()" that evaluates as true if something is
either compiled in or compiled as a module. That's probably what you
want to change the "#if defined()" options to.

Anna

>
>
> --
> Chuck Lever
>
>
>