Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Christoph Hellwig <hch@infradead.org>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] NFSD: Remove CONFIG_SUNRPC_GSS_MODULE
Thread-Topic: [PATCH] NFSD: Remove CONFIG_SUNRPC_GSS_MODULE
Thread-Index: AQHYmq7FTbvVJcL0IE6jwSQssKBM4q2FEDuAgAChFgCAABP9AIAABZYA
Date:   Tue, 19 Jul 2022 14:59:22 +0000
Message-ID: <5DCB9FF7-D56F-4A5B-B36D-9D28550B643E@oracle.com>
References: <165815281251.8395.9611588593452344848.stgit@klimt.1015granger.net>
 <YtYqNZCazm64S/Di@infradead.org>
 <4936C3D6-AE4B-4F7F-89D1-17CBF38A5CD5@oracle.com>
 <YtbCGoJ7+ynzqqHX@infradead.org>
In-Reply-To: <YtbCGoJ7+ynzqqHX@infradead.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?eBKcOcym+NZhgkrj3Qmx/4puw7As7fEiMDMWXWx4RTMNCBr9t49/0vhUbyJz?=
 =?us-ascii?Q?RwHxiMIV7HuT073VC8ih+rN4H4C6ARxJ2MfOa5sYDHRDsI0SP8jYzdEQcjIv?=
 =?us-ascii?Q?bOqSbK1MIR0Us+RvYZuwAmNk88/P0VuxAs3W+JE5OKHnXJpWE+GzGJ7h5iL/?=
 =?us-ascii?Q?egDHadLLbVzn+hWfuxkoUkScaCOGInUyx9ibmvNyr7Tb9nVa+wJzZzNDKlQW?=
 =?us-ascii?Q?oUOVk1tkk9YuVMKUw3PCTasPNpllu03EWIIggbNm0DykmkO1ayiBIRGt92GS?=
 =?us-ascii?Q?hAhVi/T5cKFEGcfrGOWybOOzhuOFvZqtl8keoIl/cFIcYC/9jsPiLSsGeO/L?=
 =?us-ascii?Q?57P6R3d4f83Uv7BSYlgy+7nU7ZQQ9PF/E/P1Rnv2aocQIyv6H43gZ8lCjWt+?=
 =?us-ascii?Q?Y6ppIigAFQvHiyY8V2oj+jA92MyzaiovDAxi/2VUQEjIZgyTExO1piXejIwi?=
 =?us-ascii?Q?vc0wCGUSaZcnOisZ28vtWqNjnvi44w/5Ol6vhGOQvyTxmphKl9wyKZM6h+YS?=
 =?us-ascii?Q?7p5lYKBF8+SCiuiQoDYLTMe63N9WQOewq8WBqZdCM7771M4NBqSZnv98HL99?=
 =?us-ascii?Q?cQyM8MBa+zc7mfNIQridH/8RHDW9/B7due2aAcDqj5MQ/DmpXjenLAr6sioT?=
 =?us-ascii?Q?eCEEoicVKON9votyRaFHsFWc3i9b8P9tINtKV4jZ00AlPi4jC1RlOgXZd3Ds?=
 =?us-ascii?Q?owLBLN63SJiD8CC+LyjhOQzvR4ULSWHPhrAnxwUx5s+54HxzlAlw8eWEG7rH?=
 =?us-ascii?Q?9RECmpnOhqdof/Be3dAm8pAL2LfxbseE5eBy5roLH4Czil1uK9kjZA7ZVjlX?=
 =?us-ascii?Q?uZpg56LoiL94tQlMna3tRnDjChv2UN7Vf4X9MmaNmJXXd50Xrt/jh+GQcNQT?=
 =?us-ascii?Q?x6WD5aaV38wZbIzklnztbQCIOy2oQm0cMkRTRIdLIBx+OMbOAZDkdP9fUVJY?=
 =?us-ascii?Q?DXp2L6XgFBtQU/nk97K5Fb6jiptIrztmFf3eSAeWcWTIPT3rydD1mO8BgnbV?=
 =?us-ascii?Q?befqzG1zIa3RBrztSWi4p7xKdKi7PS0CTEJR4RnN2kqUij/Eff+ppjgbUyWu?=
 =?us-ascii?Q?V6DqeyL4CMmMOv6qEp6tjfqa4z+BM0zv7ACTg4lVUwgPtxn/K/Mej530N00Z?=
 =?us-ascii?Q?t+opRcSmEo9WqQYYI+5tPgvI6f+JygnYWgUB6EqGAq0LnyqzrqRMNuLBG/6y?=
 =?us-ascii?Q?/FHEOcIoPW9O/QmTJFgK9OHrBYwsOoxr+z+CTnCBmEEQ+OQeAIx2C3tNMsdd?=
 =?us-ascii?Q?6VG4VV35SITbB1k42WOeguXWexBadIG3Hs1yHwLnfkz8sGtLcwV4gCphDVC8?=
 =?us-ascii?Q?InC2COXaWhk4/4hhCbT3PSMv1baAjX3pe4iFWUXFQxFnU3ZCUvthnow2wBQ/?=
 =?us-ascii?Q?T/t2L/WT1Lf/4AiBfJNK8ykH7Xg4GqQ8RS/m9tZs6i7PddpKgg9Y3dWmsmJj?=
 =?us-ascii?Q?sZTZWMBOAx6KTbvgh5inGMgbW8T4pl/5sVKri8ozxDspgrg1LPyxZdLTh/Ic?=
 =?us-ascii?Q?4u9XqUJh64tYAgj07QXdexoJ/rabfhiHzzutJm4VAyjUuT1kR6/9qMeImXLn?=
 =?us-ascii?Q?hoPOsOKXLhADXgS1MlYwsf/VRs1EmvNYgtsHfHPgFEnEj2EIk6nZkDzOMkLZ?=
 =?us-ascii?Q?0w=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <DB5643652369B343A2991D425D78830A@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 036949bb-db54-4e09-e2db-08da6997441d
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Jul 2022 14:59:22.9822
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BBT4+i26Znqytas6SOd2IeuP7yOzdn72yTnMA0ZnucshbvSWSP8vbc6eNuRF/33KPko4ZcvTnDj+Os2A7M7Bww==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3822
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-19_03,2022-07-19_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 spamscore=0 bulkscore=0
 malwarescore=0 adultscore=0 mlxscore=0 phishscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2206140000
 definitions=main-2207190062
X-Proofpoint-ORIG-GUID: ZNuDEEGP7v8LzYtV5irhOXrDODXmqFo-
X-Proofpoint-GUID: ZNuDEEGP7v8LzYtV5irhOXrDODXmqFo-
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Jul 19, 2022, at 10:39 AM, Christoph Hellwig <hch@infradead.org> wrote=
:
>=20
> On Tue, Jul 19, 2022 at 01:27:51PM +0000, Chuck Lever III wrote:
>>> CONFIG_SUNRPC_GSS_MODULE is set if SUNRPC_GSS is built as a module.
>>> CONFIG_*_MODULE is Kconfig-generated magic.
>>=20
>> I can drop this patch, but I still have questions (and I know you are
>> just the messenger, you might not know the answers).
>>=20
>> Where is this convention documented?
>>=20
>> When would CONFIG_SUNRPC_GSS_MODULE be defined but CONFIG_SUNRPC_GSS isn=
't?
>=20
> If .config has CONFIG_SUNRPC_GSS=3Dy, CONFIG_SUNRPC_GSS is set, but
> CONFIG_SUNRPC_GSS_MODULE is not.
>=20
> If .config has CONFIG_SUNRPC_GSS=3Dm, CONFIG_SUNRPC_GSS_MODULE is set,
> but CONFIG_SUNRPC_GSS is not.
>=20
> As Anna said these days we have the IS_ENABLED helper to mostly hide
> this.

IS_ENABLED was added by 2a11c8ea20bf ("kconfig: Introduce IS_ENABLED(),
IS_BUILTIN() and IS_MODULE()"), in July of 2011.

The commit that added the explicit check for CONFIG_SUNRPC_GSS_MODULE
is b084f598df36 ("nfsd: fix dependency of nfsd on auth_rpcgss"),
written in May of 2011.

So it's likely this is indeed just an open-coded IS_ENABLED().


--
Chuck Lever