Received: by 2002:ac0:da4c:0:0:0:0:0 with SMTP id a12csp905371imi; Fri, 22 Jul 2022 12:12:23 -0700 (PDT) X-Google-Smtp-Source: AGRyM1sadEDxZJczA/YkvLKyxoDYwAwBqbWJE3UK4qjM2k4eQdnBXxBjZSGt1g+OC6bjVDUTejMm X-Received: by 2002:a17:906:5d16:b0:72f:9f40:d1eb with SMTP id g22-20020a1709065d1600b0072f9f40d1ebmr993436ejt.403.1658517143134; Fri, 22 Jul 2022 12:12:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1658517143; cv=none; d=google.com; s=arc-20160816; b=NHqn5R1RFqQu+I6GXggfokkYXWhWXdbVs5UcsO1v9/RjqC1w074X4CtdIDEj3HqiHs WFHM1OaADckX75biAfenrPh2fwl9/PcJnQ2HLW21NGuWflMkrhL3hAm9sqlQ92R1TNXa LsSigVmh8tIt0toa7hrbnEsz4NTtkXgf4rNuFYxeXT8bYzplUK99pxpDJ2kcKdYcbpop rRs8eo/xvghgU5iOGT1uiITcneFJoFPWqiMwo+tI+2ndpxI4b17xbm/4lp/OUW47VILy G71dLv9BBvLyF3xjm3zsySGYJvkVfAEJLEAdtvLgawQBZzv9fzvKnT89NxscF8aaJJk9 p7qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:cc:to:from :subject; bh=x5jEuvPCV/z/5AexbqzB0oXw/QQyWUpykebdDWfRPG4=; b=y2hedZK5LLHW06q2sIM2kGmlcmfBcpCIknkG0B3L1/GGVaxhbL2JJgCrNHfODuHCTR QZy8cMm7UX4sn99tNHum/CI+Wjw8ObF5KszwBpF5oc0EVxxODMMCR5qjS2dUx/+Uv48T 91k2mNv827OOqwNeS69k3NnRVa7eneywDtsvSIVhI8QI8XGPfPq3uYuQqzN3M8iwtyMp kJNotK8QOSvexnz6qSA7yncG3Pw3hCvzw+9wXi8roChKeVLX2hGTPYifQKN0RaMTUFrF kqs6QMxxNdzCwXQA/qobFQ5FOnHyqZ0wud7/MrnfJv9l6TqMmVz8w1SDlgDuXn9nQQNh oIcw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h7-20020a05640250c700b0043a9e920c24si7330596edb.3.2022.07.22.12.11.58; Fri, 22 Jul 2022 12:12:23 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-nfs-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230413AbiGVTIK (ORCPT + 99 others); Fri, 22 Jul 2022 15:08:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46648 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229593AbiGVTIJ (ORCPT ); Fri, 22 Jul 2022 15:08:09 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7AB9125C66 for ; Fri, 22 Jul 2022 12:08:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 3DA30B829B3 for ; Fri, 22 Jul 2022 19:08:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CEC0EC341C6; Fri, 22 Jul 2022 19:08:05 +0000 (UTC) Subject: [PATCH v2 1/4] SUNRPC: Fail faster on bad verifier From: Chuck Lever To: anna.schumaker@netapp.com, trondmy@hammerspace.com Cc: linux-nfs@vger.kernel.org Date: Fri, 22 Jul 2022 15:08:04 -0400 Message-ID: <165851688478.2312015.9119100251679837612.stgit@morisot.1015granger.net> In-Reply-To: <165851677341.2312015.16636288284789960852.stgit@morisot.1015granger.net> References: <165851677341.2312015.16636288284789960852.stgit@morisot.1015granger.net> User-Agent: StGit/1.5 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_HI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org A bad verifier is not a garbage argument, it's an authentication failure. Retrying it doesn't make the problem go away, and delays upper layer recovery steps. Signed-off-by: Chuck Lever Reviewed-by: Jeff Layton Signed-off-by: Chuck Lever --- net/sunrpc/clnt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c index b6781ada3aa8..a97d4e06cae3 100644 --- a/net/sunrpc/clnt.c +++ b/net/sunrpc/clnt.c @@ -2650,7 +2650,7 @@ rpc_decode_header(struct rpc_task *task, struct xdr_stream *xdr) out_verifier: trace_rpc_bad_verifier(task); - goto out_garbage; + goto out_err; out_msg_denied: error = -EACCES;