Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Jeff Layton <jlayton@kernel.org>
CC:     Neil Brown <neilb@suse.de>,
        Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 00/13] NFSD: clean up locking
Thread-Topic: [PATCH 00/13] NFSD: clean up locking
Thread-Index: AQHYoLt1dDclFfeLe0KoCxvHL7Kak62SX5kAgAAW7gA=
Date:   Wed, 27 Jul 2022 17:12:06 +0000
Message-ID: <46514AE1-441F-4079-B880-35585632E2FD@oracle.com>
References: <165881740958.21666.5904057696047278505.stgit@noble.brown>
 <9f3fa578841067378e7f5a1c26ecde90e66c90e9.camel@kernel.org>
In-Reply-To: <9f3fa578841067378e7f5a1c26ecde90e66c90e9.camel@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vWcFngspx2MXagtgrvdDWFdcHJ5iM0asevRDVkYkvVMWnDOCuIvDwmAjXC2y?=
 =?us-ascii?Q?1woYfz00xSoYyP/+OMpmR+beWO78kwUf4ZuoFzRbDRn8Zo1XUMB4h45iqUxd?=
 =?us-ascii?Q?+0MJH6WLzL4uqlUXRVpPPsJIYmvnXK7vV8oQve59LRJ4nCPTKSOW8vLuWO/h?=
 =?us-ascii?Q?l+rKZRMxen45HIcBYGCcAVNgudaPSBeJPjBBDT7j6kOnpjY4oxX9t5NHYCAh?=
 =?us-ascii?Q?0OPOzYDncWSO3DD0DhjOAE8Aow9FP520NnnUGi7c5IAu2olbAdzVbwV/sKCX?=
 =?us-ascii?Q?a/vIzC2Nk6gQxwEs3398kTj7ub01Bm3IVEjJpnPKi/SDNeVNU2FeqciN8tvj?=
 =?us-ascii?Q?OBcEDVjcju3UBEV+AFGqcTKsfboTS0u1iayY7sxUoUd7l1qZyDCIMyZC5YH8?=
 =?us-ascii?Q?/soLNeO1S5RHYwtagbMnUhNsRAbt6ZlVpdvhJ8s5yf84q4V+X/kGIyyiJaeY?=
 =?us-ascii?Q?SIY0ufpXtNJQ7jQzcq68VG+a7J9sEve2N48pejdjLxPsKCFMPE/PkTzu3KLV?=
 =?us-ascii?Q?I8jjl6I5waGI+F6WOa2vnpMCYZVNPsKN5zrW4anAzMFj4YzgmXiRtUh97G9m?=
 =?us-ascii?Q?kh+snrw8NlY2zlmRgCJn92IUyiriARx33FOdG4U9gj75g6G4fxmjqeQtI9sY?=
 =?us-ascii?Q?FxJknByhxwuNBfIUnIBY5o36QHHCWnGD84BMi4orxtRgTurfm1xVcbo0jkJL?=
 =?us-ascii?Q?YdJ1fkQVmmbNStv8WnFkhO9zv7Zq85Dvxt/fWFFcz4JrWic/+Y+Ct4HiOVXN?=
 =?us-ascii?Q?sbT0atakK4LLb+/KZGe6whfcgAucuSvt88T3+1qwZgOdpujl+eplFMxuAWdM?=
 =?us-ascii?Q?1Zm9tn/p5MNawq74F9m3gpse5gE3PJCZ5Ok8xNmbrjlmwQ5liDuapM/+AOcC?=
 =?us-ascii?Q?xB9TjxOaIzpdT1XZ3g/H61Nb17xldXSp27YqIMJeB3Rg8+xIX8lqsSOYn7GQ?=
 =?us-ascii?Q?PIoKFFoUJp5TDBeYGuKk7X6t6u527gQqqhOZuI0V8RmdGubtuKEMr2toofsJ?=
 =?us-ascii?Q?Qq7n7RAFJO4A4d9nIPU8kvaT342QKPFFkgcsMe2eCXWRbmX8Mr1LJX44tjbf?=
 =?us-ascii?Q?Fcd9zEjElUfydcvqgpjp/nKxuuL+gzC7m72J9gYHNS65FFdNV3QDCOJzxCYY?=
 =?us-ascii?Q?jsqRp0hne9Um1lz6KQbSDo8DIb+ZGXGgQuQxvDCfoKHbmTyhH/hmHuxntnEi?=
 =?us-ascii?Q?z7+JSiWKQUVV+xLTBTcd2e+TQwZrAmgKhqyRTfzkjRZNMqXBpkgpg2bc9D9r?=
 =?us-ascii?Q?EwlEvWdTyXlVqIM8t3hLQRQrdwnL6EAx0UVfGtB+WCzrq/s+0DwZkX/i37wd?=
 =?us-ascii?Q?UgKW9PpVT2z/Gm7aXDdmU00vlTP193MIVXiYexoJHOYwxacfOkLjLngXStj6?=
 =?us-ascii?Q?dBM+6suuUCIB/NcyMdpCYW0r3cpgJq8Sju7Pbw1u8GB1bkJuTXnu5XfxSw2S?=
 =?us-ascii?Q?Jzr8J6UvKT+wV4z1pCqqKtTmBdxMSWR4HqsqXiaQl9ixOsIxyo6oeBX0xhHM?=
 =?us-ascii?Q?K7P+JLy/H8oWJOmHB+MLFVY/6TtYxRBiXeS1XjFhbQ+m91fcb6l6UUrQN1/B?=
 =?us-ascii?Q?ozme6s2LJHqkOAchG8Pkuxmq0NqPlPC6P9mUi9QuJBfnFfLlu+MIecQXt2ft?=
 =?us-ascii?Q?ow=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <D6F3FD74BB42324AA2AFC1D7C2A5E04C@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: BN0PR10MB5128.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 75cf90de-a342-487c-2cbc-08da6ff3224b
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Jul 2022 17:12:06.9122
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: x1Nyt53AAUFonucGlGm8jSkvEfFPtLibzzSXQealDAAvBEL19isTq3Jf0ffFEWyO8CQEzm7x4qUIhsP8W3rdpg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7PR10MB2434
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-07-27_06,2022-07-27_01,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=754 malwarescore=0
 suspectscore=0 mlxscore=0 bulkscore=0 adultscore=0 spamscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2207270072
X-Proofpoint-GUID: 5ZRwjAKmzaEo29y-Sth3lrxbbWgWK3Wb
X-Proofpoint-ORIG-GUID: 5ZRwjAKmzaEo29y-Sth3lrxbbWgWK3Wb
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Jul 27, 2022, at 11:50 AM, Jeff Layton <jlayton@kernel.org> wrote:
>=20
> On Tue, 2022-07-26 at 16:45 +1000, NeilBrown wrote:
>> This is the latest version of my series to clean up locking -
>> particularly of directories - in preparation for proposed patches which
>> change how directory locking works across the VFS.
>>=20
>> I've included Jeff's patches to validate the dentry after getting a
>> delegation.  The second patch has been changed quite a bit to use
>> nfsd_lookup_dentry(). I've left Jeff's From: line in place - let me know
>> if you'd rather I change it.
>>=20
>=20
> That's fine.
>=20
>> Setting of ACLs and security labels has been moved from nfs4 code to
>> nfsd_setattr() which allows quite a lot of code cleanup.
>>=20
>> I think I've addressed all the concerns that have been raised, though
>> maybe not in the way that was suggested.
>>=20
>> I've tested this with cthon tests over v2, v3, v4.0, v4.1, and xfstests
>> on v3 and v4.1, and pynfs 4.0, 4.1.  No problems appeared.
>>=20
>> Thanks,
>> NeilBrown
>>=20
>>=20
>> ---
>>=20
>> Jeff Layton (2):
>>      NFSD: drop fh argument from alloc_init_deleg
>>      NFSD: verify the opened dentry after setting a delegation
>>=20
>> NeilBrown (11):
>>      NFSD: introduce struct nfsd_attrs
>>      NFSD: set attributes when creating symlinks
>>      NFSD: add security label to struct nfsd_attrs
>>      NFSD: add posix ACLs to struct nfsd_attrs
>>      NFSD: change nfsd_create()/nfsd_symlink() to unlock directory befor=
e returning.
>>      NFSD: always drop directory lock in nfsd_unlink()
>>      NFSD: only call fh_unlock() once in nfsd_link()
>>      NFSD: reduce locking in nfsd_lookup()
>>      NFSD: use explicit lock/unlock for directory ops
>>      NFSD: use (un)lock_inode instead of fh_(un)lock for file operations
>>      NFSD: discard fh_locked flag and fh_lock/fh_unlock
>>=20
>=20
> It looks like the last 5 patches are missing from the posting
> (everything after patch #8).

Fwiw, I don't see them in my inbox either, and they don't appear on lore.


>> fs/nfsd/acl.h       |   6 +-
>> fs/nfsd/nfs2acl.c   |   6 +-
>> fs/nfsd/nfs3acl.c   |   4 +-
>> fs/nfsd/nfs3proc.c  |  25 ++---
>> fs/nfsd/nfs4acl.c   |  46 ++-------
>> fs/nfsd/nfs4proc.c  | 153 ++++++++++++-----------------
>> fs/nfsd/nfs4state.c |  71 +++++++++++---
>> fs/nfsd/nfsfh.c     |  22 ++++-
>> fs/nfsd/nfsfh.h     |  58 +----------
>> fs/nfsd/nfsproc.c   |  19 ++--
>> fs/nfsd/vfs.c       | 230 +++++++++++++++++++++-----------------------
>> fs/nfsd/vfs.h       |  31 ++++--
>> fs/nfsd/xdr4.h      |   1 +
>> 13 files changed, 314 insertions(+), 358 deletions(-)
>>=20
>> --
>> Signature
>>=20
>=20
> --=20
> Jeff Layton <jlayton@kernel.org>

--
Chuck Lever