Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
From:   "NeilBrown" <neilb@suse.de>
To:     "Jeff Layton" <jlayton@kernel.org>
Cc:     "Chuck Lever III" <chuck.lever@oracle.com>,
        "Linux NFS Mailing List" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 00/13] NFSD: clean up locking
In-reply-to: <9f3fa578841067378e7f5a1c26ecde90e66c90e9.camel@kernel.org>
References: <165881740958.21666.5904057696047278505.stgit@noble.brown>,
 <9f3fa578841067378e7f5a1c26ecde90e66c90e9.camel@kernel.org>
Date:   Thu, 28 Jul 2022 09:48:42 +1000
Message-id: <165896572203.4359.16866453628573745859@noble.neil.brown.name>
Precedence: bulk

On Thu, 28 Jul 2022, Jeff Layton wrote:
> On Tue, 2022-07-26 at 16:45 +1000, NeilBrown wrote:
> > This is the latest version of my series to clean up locking -
> > particularly of directories - in preparation for proposed patches which
> > change how directory locking works across the VFS.
> >=20
> > I've included Jeff's patches to validate the dentry after getting a
> > delegation.  The second patch has been changed quite a bit to use
> > nfsd_lookup_dentry(). I've left Jeff's From: line in place - let me know
> > if you'd rather I change it.
> >=20
>=20
> That's fine.
>=20
> > Setting of ACLs and security labels has been moved from nfs4 code to
> > nfsd_setattr() which allows quite a lot of code cleanup.
> >=20
> > I think I've addressed all the concerns that have been raised, though
> > maybe not in the way that was suggested.
> >=20
> > I've tested this with cthon tests over v2, v3, v4.0, v4.1, and xfstests
> > on v3 and v4.1, and pynfs 4.0, 4.1.  No problems appeared.
> >=20
> > Thanks,
> > NeilBrown
> >=20
> >=20
> > ---
> >=20
> > Jeff Layton (2):
> >       NFSD: drop fh argument from alloc_init_deleg
> >       NFSD: verify the opened dentry after setting a delegation
> >=20
> > NeilBrown (11):
> >       NFSD: introduce struct nfsd_attrs
> >       NFSD: set attributes when creating symlinks
> >       NFSD: add security label to struct nfsd_attrs
> >       NFSD: add posix ACLs to struct nfsd_attrs
> >       NFSD: change nfsd_create()/nfsd_symlink() to unlock directory befor=
e returning.
> >       NFSD: always drop directory lock in nfsd_unlink()
> >       NFSD: only call fh_unlock() once in nfsd_link()
> >       NFSD: reduce locking in nfsd_lookup()
> >       NFSD: use explicit lock/unlock for directory ops
> >       NFSD: use (un)lock_inode instead of fh_(un)lock for file operations
> >       NFSD: discard fh_locked flag and fh_lock/fh_unlock
> >=20
>=20
> It looks like the last 5 patches are missing from the posting
> (everything after patch #8).
>=20

Sorry.  You should have them now.

NeilBrown