Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
From:   "NeilBrown" <neilb@suse.de>
To:     "Chuck Lever III" <chuck.lever@oracle.com>
Cc:     "Jeff Layton" <jlayton@kernel.org>,
        "Linux NFS Mailing List" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 06/13] NFSD: add posix ACLs to struct nfsd_attrs
In-reply-to: <2CE51ADF-AC32-48EF-9D9B-107BC8EC0370@oracle.com>
References: <165881740958.21666.5904057696047278505.stgit@noble.brown>,
 <165881793057.21666.7472233362797480106.stgit@noble.brown>,
 <2CE51ADF-AC32-48EF-9D9B-107BC8EC0370@oracle.com>
Date:   Mon, 01 Aug 2022 10:13:29 +1000
Message-id: <165931280988.4359.13998492410477063943@noble.neil.brown.name>
Precedence: bulk

On Sat, 30 Jul 2022, Chuck Lever III wrote:
> > @@ -837,10 +821,8 @@ nfsd4_create(struct svc_rqst *rqstp, struct nfsd4_co=
mpound_state *cstate,
> >=20
> > 	if (attrs.label_failed)
> > 		create->cr_bmval[2] &=3D ~FATTR4_WORD2_SECURITY_LABEL;
> > -
> > -	if (create->cr_acl !=3D NULL)
> > -		do_set_nfs4_acl(rqstp, &resfh, create->cr_acl,
> > -				create->cr_bmval);
> > +	if (attrs.label_failed)
> > +		create->cr_bmval[0] &=3D ~FATTR4_WORD0_ACL;
>=20
> I think this needs to be "if (attrs.acl_failed)". I've fixed this
> in my tree.

Yes, of course :-(.
Thanks,
NeilBrown