Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Chuck Lever III <chuck.lever@oracle.com>
To:     Bruce Fields <bfields@fieldses.org>
CC:     Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: pynfs clean_init issue
Thread-Topic: pynfs clean_init issue
Thread-Index: AQHYqBYvcZZh6BVquE68kijT9LgD6K2e4EEAgAABlIA=
Date:   Thu, 4 Aug 2022 15:43:56 +0000
Message-ID: <1C391A45-B2CC-4C90-86DD-1FB9C2000E7E@oracle.com>
References: <F80796C9-DFCE-4C7A-A2EE-4EB2075B9007@oracle.com>
 <20220804153816.GB9019@fieldses.org>
In-Reply-To: <20220804153816.GB9019@fieldses.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4P3X4fJkHITlexYj7/VpRevuaScsBiSsWXN4jm5Uin1601y+SFJm9oj3bvCI?=
 =?us-ascii?Q?tkeDkd8YTPFLpun5X3AP1Nx6OOx7QdzDCBJVv865k+0BsxrC8vZDPVI8aHxk?=
 =?us-ascii?Q?NtYudrJdO5D0Ktz90Oeen2qNSmtZQqvrfH5p6GBcArSW0VGZ4rv0XW9li2hy?=
 =?us-ascii?Q?Thviv+89Ks+A47MY67pKqWsniQirwtvTh4WV4HxAvQoluLU7eo9rIJdjH1DP?=
 =?us-ascii?Q?6U11e+pGY2gbyNe32zo5dNnDpVBoqErpvMnim2DC2MzkA19KtAN/2/Aj0QuK?=
 =?us-ascii?Q?fVCnYfHk1Rd7kTwxq+SkgUe0KLOEcdMXIcV+CfRo8KVzngMYyEkQmI8EYy31?=
 =?us-ascii?Q?oaakUVPJLh8fLhnBhYgRYE31/VzcIcyBKxw7B04LJiib6/6/2Ycsj3IiV18Z?=
 =?us-ascii?Q?qf+WN+eE83KxMUBQDl7b2OZiSwiG7PTjgmieNe6SPVl47Yo0BZWw8XRJkUv0?=
 =?us-ascii?Q?7wfQC42aUO7oVzTnZqCmxXwntk3ioRYCO7MZUXtl0swnR1Vv7f2tbntRlnl9?=
 =?us-ascii?Q?JQxnQ96g4aXGMhZHl4F5SuMVJh91Sg3uu2kwNT6iMPX2tz/0Kv4B04UuTYjq?=
 =?us-ascii?Q?3dLSEc956K2HOfAUwAl0dlXv99BGUN9YUJJ89asB4+13X//2dIUljf+lXuss?=
 =?us-ascii?Q?Ig7XEdXPIpvvuQ4y4KNxjaXhFbgByegfCg6lWXIIFRgoxOlLbFsv0yp5JBWT?=
 =?us-ascii?Q?yd7wxApAXCxXOfE8JbLZ5X2BLUL/50VE3SGi8wLbKt2Lujd18Y5L20/0sKLf?=
 =?us-ascii?Q?UyRMYZjw5HsSgXAxVhGOX9Nyf/Ar8FDO9YMKWpAvpmyE27Hz5RON3lPWMD7W?=
 =?us-ascii?Q?thxAL6Ky30poDadZnMVqA3ro/xy7e1/cNvJ2wgfppaCx78s0YiIlmfIRQq3d?=
 =?us-ascii?Q?xUUsvtZUpIhtE6TsaJFpT6O3YpnjX4s4D4TXMTE+3p0x6KlI9fQwe21nYbvw?=
 =?us-ascii?Q?rEKoNRIUVmvpwNATMgG3SJF0mvndgEyjytt88vWJBEx09ifP7qKUG8l/0Uu8?=
 =?us-ascii?Q?hebs7ogqHFoNk4Lu8M6PmVFqKZTZubIWl38G34TC19hOXguQntfphjGDBGN8?=
 =?us-ascii?Q?l3JMhGlaLLp+ilS65+HbrNtVYgxGlAuCGm86SlN28hO9H5MFi4He+W1bh4Yl?=
 =?us-ascii?Q?JQIwdP+gQmsb5AV4CrESW6y8fWdw7mr5FwkbS5OwWkMnhalYZjJCfdYkBHXd?=
 =?us-ascii?Q?fr1RS+JTNGAd+kDOqkEKoFLroQfFnP0hhVk20+UXS3TLIjKhCW0CwWQ7d2Qd?=
 =?us-ascii?Q?lJzZg3hjpz7zrNCH7ZYa53GUcf2nDLrtOtyspeM8Q/lJsVqF5HQHdmJr+iaZ?=
 =?us-ascii?Q?Y/mz2oRxVe7PtpKe9rjiIDF7OVQtwWULTn3Oe88pcyyfQdIDeK9EJC8lHMk8?=
 =?us-ascii?Q?AEekg648HqpqCE1/0swRoWGZQnQOPs8xeiP/r+2dp7kXPkBHwqGmZA6N4JFj?=
 =?us-ascii?Q?M0GEiADdIRfmrVP2paGaQdJN/avWd3DpeMuqX0iRavOouXewMPQ+kmR9KzsC?=
 =?us-ascii?Q?1gulGOSXtKUCGQzmzrGulcrbL2FOCEg11p1mx7syjjg2gVP+3WLrOHO/3UCN?=
 =?us-ascii?Q?mYar4gCx1hMldFu3WwDaVRBVygNVJC9XcJE6vpwOIYxndtW02/CRBh/IlCwf?=
 =?us-ascii?Q?bA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <AA7DDBABFBBA29468FEFDA19265E2760@namprd10.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DS7PR10MB5134.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 41e8fcee-46f1-43d4-1706-08da76302430
X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Aug 2022 15:43:56.3829
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: uciWWhpVFjOk9e33seeaSjknVUpipnUFjTDoSGTWQuSo+J78XOSDCOG4cunZ1KsIxfWU4jv6x1alLmUOvCClhA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB3272
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1
 definitions=2022-08-04_03,2022-08-04_02,2022-06-22_01
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=0
 mlxlogscore=999 bulkscore=0 mlxscore=0 phishscore=0 spamscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2206140000 definitions=main-2208040068
X-Proofpoint-ORIG-GUID: MrTJV0fH51JCILeT7jIR3evuihxWzVNV
X-Proofpoint-GUID: MrTJV0fH51JCILeT7jIR3evuihxWzVNV
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-nfs.vger.kernel.org>
X-Mailing-List: linux-nfs@vger.kernel.org


> On Aug 4, 2022, at 11:38 AM, J. Bruce Fields <bfields@fieldses.org> wrote=
:
>=20
> On Thu, Aug 04, 2022 at 03:23:44PM +0000, Chuck Lever III wrote:
>> Hi Bruce-
>>=20
>> I'm running DELEG21 to unit-test delegations, and this message comes
>> out at the end:
>>=20
>> Making sure b'DELEG21-1' is writable: operation OP_SETATTR should return=
 NFS4_OK, instead got NFS4ERR_DELAY
>>=20
>> I guess there's no callback service running during the test's clean-up p=
hase.
>>=20
>> Then if I run the test again immediately:
>>=20
>> [cel@morisot pynfs]$ sudo nfs4.0/testserver.py manet:/export/tmp --maket=
ree --rundeps -v cel
>> Initialization failed, no tests run.
>> Perhaps you need to use the --secure option or configure server to allow=
 connections from high ports
>> Traceback (most recent call last):
>>  File "/home/cel/src/pynfs/nfs4.0/testserver.py", line 394, in <module>
>>    main()
>>  File "/home/cel/src/pynfs/nfs4.0/testserver.py", line 346, in main
>>    env.init()
>>  File "/home/cel/src/pynfs/nfs4.0/servertests/environment.py", line 150,=
 in init
>>    c.clean_dir(self.opts.path)
>>  File "/home/cel/src/pynfs/nfs4.0/nfs4lib.py", line 579, in clean_dir
>>    check_result(res, "Making sure %s is writable" % repr(e.name))
>>  File "/home/cel/src/pynfs/nfs4.0/nfs4lib.py", line 906, in check_result
>>    raise BadCompoundRes(resop, res.status, msg)
>> nfs4lib.BadCompoundRes: Making sure b'DELEG21-1' is writable: operation =
OP_SETATTR should return NFS4_OK, instead got NFS4ERR_DELAY
>>=20
>> And I think this condition persists until the old lease expires and
>> the server permits the client to delete that file.
>=20
> DELEG21 should pass on any recent kernel.

It passes, but leaves the test file so that clean_dir does not work
again until the old lease expires.


> But possibly cleanup should also be better.

This bug might prevent running these tests in an automation harness.
I'd say cleanup does need to be better about this.


> I'm not sure what the right fix is.

Brute force: keep trying to delete that file if clean_dir receives
NFS4ERR_DELAY?

init_connection somewhere needs to set up a callback service and
leave it running.


--
Chuck Lever