Received-SPF: pass (google.com: domain of linux-nfs-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   "Frank Filz" <ffilzlnx@mindspring.com>
To:     "'Jeff Layton'" <jlayton@kernel.org>,
        <linux-fsdevel@vger.kernel.org>
Cc:     <dhowells@redhat.com>, <lczerner@redhat.com>, <bxue@redhat.com>,
        <ceph-devel@vger.kernel.org>, <linux-nfs@vger.kernel.org>,
        <linux-afs@lists.infradead.org>, <linux-ext4@vger.kernel.org>,
        <linux-xfs@vger.kernel.org>, <linux-btrfs@vger.kernel.org>
References: <20220805183543.274352-1-jlayton@kernel.org>
In-Reply-To: <20220805183543.274352-1-jlayton@kernel.org>
Subject: RE: [RFC PATCH 0/4] vfs: allow querying i_version via statx
Date:   Fri, 5 Aug 2022 11:52:21 -0700
Message-ID: <030701d8a8fc$7fae8b80$7f0ba280$@mindspring.com>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="us-ascii"
Content-Transfer-Encoding: 7bit
Content-Language: en-us
Thread-Index: AQEtGZTJQmRjw345ne5MFo8sgZw3IK73xOQQ
Precedence: bulk

> Recently I posted a patch to turn on the i_version counter unconditionally
in
> ext4, and Lukas rightly pointed out that we don't currently have an easy
way to
> validate its functionality. You can fetch it via NFS (and see it in
network traces),
> but there's no way to get to it from userland.
> 
> Besides testing, this may also be of use for userland NFS servers, or by
any
> program that wants to accurately check for file changes, and not be
subject to
> mtime granularity problems.

This would definitely be useful for NFS Ganesha.

Thanks

Frank

> Comments and suggestions welcome. I'm not 100% convinced that this is a
> great idea, but we've had people ask for it before and it seems like a
reasonable
> thing to provide.
> 
> Jeff Layton (4):
>   vfs: report change attribute in statx for IS_I_VERSION inodes
>   nfs: report the change attribute if requested
>   afs: fill out change attribute in statx replies
>   ceph: fill in the change attribute in statx requests
> 
>  fs/afs/inode.c            |  2 ++
>  fs/ceph/inode.c           | 14 +++++++++-----
>  fs/nfs/inode.c            |  3 +++
>  fs/stat.c                 |  7 +++++++
>  include/linux/stat.h      |  1 +
>  include/uapi/linux/stat.h |  3 ++-
>  samples/vfs/test-statx.c  |  4 +++-
>  7 files changed, 27 insertions(+), 7 deletions(-)
> 
> --
> 2.37.1